dsmiley commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794991015
##
File path: solr/core/src/java/org/apache/solr/update/UpdateHandler.java
##
@@ -115,12 +115,12 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog)
[
https://issues.apache.org/jira/browse/SOLR-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney resolved SOLR-15777.
---
Fix Version/s: 9.0
Resolution: Fixed
> ICUCollationField useDocValuesAsStored=true lea
[
https://issues.apache.org/jira/browse/SOLR-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484058#comment-17484058
]
ASF subversion and git services commented on SOLR-15777:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484057#comment-17484057
]
ASF subversion and git services commented on SOLR-15777:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-15777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484055#comment-17484055
]
ASF subversion and git services commented on SOLR-15777:
Commit 9
magibney merged pull request #506:
URL: https://github.com/apache/solr/pull/506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
gerlowskija commented on pull request #577:
URL: https://github.com/apache/solr/pull/577#issuecomment-1024797869
One note about this PR: unlike a lot of the other API-conversions I've done
recently, this one **isn't** a straight refactor/reimplementation.
The `CoreApiMapping` Java fi
gerlowskija commented on a change in pull request #577:
URL: https://github.com/apache/solr/pull/577#discussion_r794976722
##
File path:
solr/core/src/java/org/apache/solr/handler/admin/api/RequestApplyCoreUpdatesAPI.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Soft
gerlowskija commented on a change in pull request #577:
URL: https://github.com/apache/solr/pull/577#discussion_r794975134
##
File path:
solr/core/src/java/org/apache/solr/handler/admin/api/RequestApplyCoreUpdatesAPI.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Soft
gerlowskija commented on a change in pull request #577:
URL: https://github.com/apache/solr/pull/577#discussion_r794975134
##
File path:
solr/core/src/java/org/apache/solr/handler/admin/api/RequestApplyCoreUpdatesAPI.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Soft
gerlowskija opened a new pull request #577:
URL: https://github.com/apache/solr/pull/577
# Description
Solr's been in the slow process of moving its v2 APIs away from the
existing apispec/mapping framework towards one that relies on more
explicit annotations to specify API prope
[
https://issues.apache.org/jira/browse/SOLR-15961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484028#comment-17484028
]
ASF subversion and git services commented on SOLR-15961:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-15961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484025#comment-17484025
]
Jan Høydahl commented on SOLR-15961:
Sure. Bug files are welcome in 9.0
> PKIAuthent
[
https://issues.apache.org/jira/browse/SOLR-15961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe reassigned SOLR-15961:
Assignee: Tomas Eduardo Fernandez Lobbe
> PKIAuthenticatio
[
https://issues.apache.org/jira/browse/SOLR-15961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484022#comment-17484022
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-15961:
--
[~janhoy], I
[
https://issues.apache.org/jira/browse/SOLR-15961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484021#comment-17484021
]
ASF subversion and git services commented on SOLR-15961:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-15961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484019#comment-17484019
]
ASF subversion and git services commented on SOLR-15961:
Commit 8
tflobbe merged pull request #575:
URL: https://github.com/apache/solr/pull/575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
nickumia-reisys commented on issue #399:
URL: https://github.com/apache/solr-operator/issues/399#issuecomment-1024745521
Hmmm so upon further research, it seems like there's a race condition
happening in either the `solr` or `solr-operator` helm charts.
Inspecting the pvc that `s
madrob commented on a change in pull request #575:
URL: https://github.com/apache/solr/pull/575#discussion_r794949342
##
File path:
solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java
##
@@ -187,7 +198,7 @@ private static PKIHeaderData parseCipher(String c
markrmiller commented on a change in pull request #574:
URL: https://github.com/apache/solr/pull/574#discussion_r794948735
##
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##
@@ -737,10 +746,10 @@ public void load() {
zkSys.initZooKeeper(this, cfg
risdenk commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1024691338
Thanks @madrob and @dsmiley. I think your comments have been addressed by
@warperwolf and I. Any other questions/comments/concerns/thoughts?
--
This is an automated message from t
janhoy commented on a change in pull request #576:
URL: https://github.com/apache/solr/pull/576#discussion_r794921410
##
File path: solr/webapp/web/partials/query.html
##
@@ -359,6 +362,10 @@
+
+JSON Query (https://solr.apache.org/guide/json-re
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794920667
##
File path: solr/core/build.gradle
##
@@ -146,11 +146,6 @@ dependencies {
testImplementation 'org.apache.commons:commons-compress'
testImplementation (
tflobbe commented on a change in pull request #575:
URL: https://github.com/apache/solr/pull/575#discussion_r794920612
##
File path:
solr/core/src/test/org/apache/solr/security/TestPKIAuthenticationPlugin.java
##
@@ -155,6 +161,70 @@ PublicKey getRemotePublicKey(String ignored
tflobbe commented on a change in pull request #575:
URL: https://github.com/apache/solr/pull/575#discussion_r794920272
##
File path:
solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java
##
@@ -75,6 +76,15 @@ public static void withServerIdentity(final boole
risdenk commented on a change in pull request #553:
URL: https://github.com/apache/solr/pull/553#discussion_r794911327
##
File path:
solr/test-framework/src/java/org/apache/solr/util/BadHdfsThreadsFilter.java
##
@@ -41,6 +41,10 @@ public boolean reject(Thread t) {
retur
[
https://issues.apache.org/jira/browse/SOLR-15956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483983#comment-17483983
]
Houston Putman commented on SOLR-15956:
---
As a part of this ticket, I have also rena
risdenk commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1024662117
@madrob I'm with you I expected more jars to be there in `hdfs/lib`, but
`hadoop-auth`, `hadoop-annotations`, and `hadoop-common` are all needed by the
existing Hadoop authenticatio
warperwolf commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794903379
##
File path: solr/modules/hdfs/build.gradle
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
madrob commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1024642024
I've been looking through and I _think_ that we can exclude
Hadoop-annotations and leave it in only as a test dependency? I'm not sure.
--
This is an automated message from the Apa
HoustonPutman commented on pull request #572:
URL: https://github.com/apache/solr/pull/572#issuecomment-1024634035
Thanks for the suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
madrob commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1024628290
I ran `gradlew assemble` and took a look at the output in
`solr/packaging/build`... There were only 3 jars in `modules/hdfs/lib/` - I'm
not sure what I expected but for some reason I
HoustonPutman commented on a change in pull request #572:
URL: https://github.com/apache/solr/pull/572#discussion_r794870102
##
File path: solr/docker/templates/Dockerfile.body.template
##
@@ -26,10 +26,11 @@
#-#
#-#
-# add symlink to /opt/solr, remove what we don't want
+#
epugh commented on a change in pull request #576:
URL: https://github.com/apache/solr/pull/576#discussion_r794853479
##
File path: solr/webapp/web/partials/query.html
##
@@ -359,6 +362,10 @@
+
+JSON Query (https://solr.apache.org/guide/json-req
epugh commented on pull request #576:
URL: https://github.com/apache/solr/pull/576#issuecomment-1024604685
I saw that we have `question-white.png` used in the schema page, maybe we
want to use it here to signfiy more inforamtion and link to the docs?
--
This is an automated message from
madrob commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794727164
##
File path: solr/modules/hdfs/build.gradle
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor lice
Caa52 commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r794843972
##
File path: solr/core/src/java/org/apache/solr/query/FilterQuery.java
##
@@ -96,6 +95,6 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode
scoreM
Caa52 commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r794843334
##
File path: solr/core/src/java/org/apache/solr/search/FunctionRangeQuery.java
##
@@ -25,18 +25,16 @@
import org.apache.lucene.queries.function.ValueSource;
i
madrob commented on a change in pull request #575:
URL: https://github.com/apache/solr/pull/575#discussion_r794817601
##
File path:
solr/core/src/test/org/apache/solr/security/TestPKIAuthenticationPlugin.java
##
@@ -155,6 +161,70 @@ PublicKey getRemotePublicKey(String ignored)
[
https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-14660:
Status: Patch Available (was: Open)
> Migrating HDFS into a module
>
[
https://issues.apache.org/jira/browse/SOLR-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-11905:
--
Assignee: Jan Høydahl
> Input box for json.facet and json query in Admin UI
>
janhoy opened a new pull request #576:
URL: https://github.com/apache/solr/pull/576
https://issues.apache.org/jira/browse/SOLR-11905
I did not bother updating any screenshots in RefGuide, since the existing
images did not cover these parts anyway.
--
This is an automated messa
[
https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483936#comment-17483936
]
Kevin Risden commented on SOLR-14660:
-
For those that might just be watching this jir
[
https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reassigned SOLR-14660:
---
Assignee: Kevin Risden
> Migrating HDFS into a module
>
>
>
[
https://issues.apache.org/jira/browse/SOLR-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483934#comment-17483934
]
Jan Høydahl commented on SOLR-11905:
I took a shot at this one, took literally 30 min
[
https://issues.apache.org/jira/browse/SOLR-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-11905:
---
Attachment: Skjermbilde 2022-01-28 kl. 20.18.24.png
> Input box for json.facet and json query in Admi
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794787601
##
File path:
solr/modules/hdfs/src/test/org/apache/solr/store/blockcache/BlockCacheTest.java
##
@@ -257,7 +259,7 @@ public void testCacheConcurrent() throws
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794786304
##
File path:
solr/modules/hdfs/src/test/org/apache/solr/store/blockcache/BlockCacheTest.java
##
@@ -257,7 +259,7 @@ public void testCacheConcurrent() throws
[
https://issues.apache.org/jira/browse/SOLR-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-11905:
---
Description:
We need an input box for JSON facet. I imagine to add another text-box that
appears whe
[
https://issues.apache.org/jira/browse/SOLR-11905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-11905:
---
Summary: Input box for json.facet and json query in Admin UI (was: Input
box for json.facet in Admin
anshumg commented on a change in pull request #575:
URL: https://github.com/apache/solr/pull/575#discussion_r794758234
##
File path:
solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java
##
@@ -75,6 +76,15 @@ public static void withServerIdentity(final boole
nickumia-reisys commented on issue #399:
URL: https://github.com/apache/solr-operator/issues/399#issuecomment-1024491330
Hi @HoustonPutman, thanks for your continued support! As we are figuring
out how to deploy solr with persistent storage, we're running into a few bumps
and would apprec
Tomas Eduardo Fernandez Lobbe created SOLR-15961:
Summary: PKIAuthenticationPlugin.parseCipher is too lenient,
causing unnecessary authentication errors
Key: SOLR-15961
URL: https://issues.apache.o
risdenk commented on pull request #324:
URL: https://github.com/apache/solr/pull/324#issuecomment-1024422694
I went through these two and I'm not sure there is a good way to address
them right now. I don't think it should hold up the merge of this PR.
* render-javadoc needs a little
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794687908
##
File path: solr/modules/hdfs/README.md
##
@@ -0,0 +1,31 @@
+Apache Solr HDFS Module
+===
+
+Introduction
+
+This mod
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794661450
##
File path: solr/core/src/java/org/apache/solr/update/UpdateHandler.java
##
@@ -115,12 +115,12 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog)
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794672231
##
File path: gradle/documentation/render-javadoc.gradle
##
@@ -151,8 +151,25 @@ configure(project(":solr:test-framework")) {
"org.apache.solr.analysi
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794671450
##
File path: solr/contrib/README.md
##
@@ -0,0 +1,31 @@
+Apache Solr HDFS Contrib module
+===
+
+Introduction
+
+This
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794669642
##
File path: solr/test-framework/src/java/org/apache/solr/handler/package.html
##
@@ -0,0 +1,24 @@
+
+
+
Review comment:
I think this should be handle
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794667891
##
File path: gradle/documentation/render-javadoc.gradle
##
@@ -151,8 +151,25 @@ configure(project(":solr:test-framework")) {
"org.apache.solr.analysi
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794661450
##
File path: solr/core/src/java/org/apache/solr/update/UpdateHandler.java
##
@@ -115,12 +115,12 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog)
madrob commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r794647968
##
File path: solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java
##
@@ -234,9 +234,8 @@ public Query createDomainQuery(FacetContext fcontext)
th
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794644433
##
File path: solr/solr-ref-guide/src/solr-on-hdfs.adoc
##
@@ -16,11 +16,12 @@
// specific language governing permissions and limitations
// under the Licens
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794644098
##
File path: gradle/validation/validate-source-patterns.gradle
##
@@ -108,6 +108,11 @@ allprojects {
configure(project(':solr:core')) {
project.tasks.with
madrob commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r794642566
##
File path: solr/core/src/java/org/apache/solr/search/FunctionRangeQuery.java
##
@@ -25,18 +25,16 @@
import org.apache.lucene.queries.function.ValueSource;
Caa52 commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r793927255
##
File path: solr/core/src/java/org/apache/solr/search/FunctionRangeQuery.java
##
@@ -18,40 +18,70 @@
import java.io.IOException;
import java.util.Map;
+imp
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794633440
##
File path: gradle/validation/validate-source-patterns.gradle
##
@@ -108,6 +108,11 @@ allprojects {
configure(project(':solr:core')) {
project.tasks.with
epugh commented on a change in pull request #574:
URL: https://github.com/apache/solr/pull/574#discussion_r794568850
##
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##
@@ -737,10 +746,10 @@ public void load() {
zkSys.initZooKeeper(this, cfg.getCl
[
https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483804#comment-17483804
]
Mark Robert Miller commented on SOLR-14569:
---
I'm working on getting this into a
markrmiller opened a new pull request #574:
URL: https://github.com/apache/solr/pull/574
Security setups do not work correctly with per request handler
shardHandlerFactory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/SOLR-15960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483660#comment-17483660
]
Jan Høydahl commented on SOLR-15960:
Looking into solr.xml for another jira. We have
janhoy commented on a change in pull request #558:
URL: https://github.com/apache/solr/pull/558#discussion_r794307508
##
File path: solr/solr-ref-guide/src/configuring-solr-xml.adoc
##
@@ -543,7 +553,6 @@ If only `dividend` routing is desired, `hash` may be
explicitly set to t
janhoy edited a comment on pull request #558:
URL: https://github.com/apache/solr/pull/558#issuecomment-1024004901
> The only way I can think is to add a flag (e.g. `solr9Compatible`) that
lets us know that we can use this new functionality, because we don't parse
image tags to determine a
janhoy commented on pull request #558:
URL: https://github.com/apache/solr/pull/558#issuecomment-1024004901
> The only way I can think is to add a flag (e.g. `solr9Compatible`) that
lets us know that we can use this new functionality, because we don't parse
image tags to determine a Solr v
janhoy commented on a change in pull request #558:
URL: https://github.com/apache/solr/pull/558#discussion_r794302250
##
File path: solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java
##
@@ -161,14 +162,21 @@ public static NodeConfig fromConfig(Path solrHome,
XmlConfigF
janhoy commented on a change in pull request #558:
URL: https://github.com/apache/solr/pull/558#discussion_r794299684
##
File path: solr/bin/solr
##
@@ -2069,8 +2069,11 @@ if [ "$SOLR_MODE" == 'solrcloud' ]; then
CLOUD_MODE_OPTS+=('-Dbootstrap_confdir=./solr/collection1/co
77 matches
Mail list logo
