markrmiller commented on a change in pull request #574:
URL: https://github.com/apache/solr/pull/574#discussion_r794948735
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -737,10 +746,10 @@ public void load() {
zkSys.initZooKeeper(this, cfg.getCloudConfig());
if (isZooKeeperAware()) {
- pkiAuthenticationPlugin = new PKIAuthenticationPlugin(this,
zkSys.getZkController().getNodeName(),
+ pkiAuthenticationSecurityBuilder = new PKIAuthenticationPlugin(this,
zkSys.getZkController().getNodeName(),
(PublicKeyHandler) containerHandlers.get(PublicKeyHandler.PATH));
// use deprecated API for back-compat, remove in 9.0
- pkiAuthenticationPlugin.initializeMetrics(solrMetricsContext,
"/authentication/pki");
+ pkiAuthenticationSecurityBuilder.initializeMetrics(solrMetricsContext,
"/authentication/pki");
Review comment:
Yeah, this is 9x, but I don't really see what that comment refers too -
I don't see that initializeMetrics is deprecated in the super class chain or
what this would be changed to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
