[ 
https://issues.apache.org/jira/browse/SOLR-15956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17483983#comment-17483983
 ] 

Houston Putman commented on SOLR-15956:
---------------------------------------

As a part of this ticket, I have also renamed 
{{solr-<version>/docker/Dockerfile.local}} to 
{{solr-<version>/docker/Dockerfile}} in the distribution, as I don't think 
there would be any confusion there and it is just cleaner. It's completely 
compatible with the official Docker image, just uses the binary distribution 
instead of downloading official releases.

As a last non-doc change, I added back in the logic to remove the Dockerfile 
from the Docker image. This is because without this logic, the official docker 
image would contain the _local_ Dockerfile, which doesn't particularly make 
sense. Easier to just remove it as it doesn't provide value.

> Add documentation for creating a docker image from the binary distribution
> --------------------------------------------------------------------------
>
>                 Key: SOLR-15956
>                 URL: https://issues.apache.org/jira/browse/SOLR-15956
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Docker
>            Reporter: Houston Putman
>            Assignee: Houston Putman
>            Priority: Blocker
>             Fix For: 9.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> From a separate PR comment from [~janhoy] :
> {quote}I was going to builda Docker image from the binary distro to test the 
> exporter from docker, but looking in {{docker/}} folder in binary distro, 
> there is no description on how to build the image. No description in main 
> {{README.md}} either. I think there is one in the ref.guide, but should there 
> not be a {{docker/README.md}} with a sample command?
> {quote}
> https://github.com/apache/solr/pull/564#pullrequestreview-861551799



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to