[GitHub] [solr] markrmiller commented on pull request #375: SOLR-15728: Remove dead, unused log rotation code from SolrCLI

2021-11-02 Thread GitBox
markrmiller commented on pull request #375: URL: https://github.com/apache/solr/pull/375#issuecomment-958681681 Seems to be a test problem: https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/ -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [solr] dsmiley merged pull request #349: Dependency tune-up of solr-core

2021-11-02 Thread GitBox
dsmiley merged pull request #349: URL: https://github.com/apache/solr/pull/349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (SOLR-15728) Remove dead, unused log rotation code from SolrCLI

2021-11-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437724#comment-17437724 ] David Smiley commented on SOLR-15728: - Looks like the build broke:  7 tests failed.

[jira] [Commented] (SOLR-7056) Disable Collections API during rolling upgrade

2021-11-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437687#comment-17437687 ] Jan Høydahl commented on SOLR-7056: --- +1 Also cluster-level commands should be disabled,

[jira] [Commented] (SOLR-15730) Modularize SolrJ

2021-11-02 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437685#comment-17437685 ] Joel Bernstein commented on SOLR-15730: --- +1 this makes a lot of sense. Happy to hel

[jira] [Resolved] (SOLR-11780) Upgrade httpclient to 5.0

2021-11-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-11780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-11780. Resolution: Won't Fix We are abandoning httpcomponents in favor of Jetty-client. Closing. > Upgrad

[jira] [Resolved] (SOLR-13128) Upgrade to Apache Tika 1.20

2021-11-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-13128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-13128. Resolution: Resolved Already on 1.27, closing > Upgrade to Apache Tika 1.20 >

[jira] [Commented] (SOLR-15578) Add Support for HSTS Security Protocol

2021-11-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437682#comment-17437682 ] Jan Høydahl commented on SOLR-15578: Any comments to my Oct 7 question? My proposal i

[jira] [Commented] (SOLR-14049) Disable Config APIs by default

2021-11-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437680#comment-17437680 ] Jan Høydahl commented on SOLR-14049: Coming back to this, I think we now have enough

[jira] [Resolved] (SOLR-15431) High Security vulnerability with Bouncy Castle library within Apache Solr 8.8.2

2021-11-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15431. Resolution: Resolved Already on 1.69. Closing > High Security vulnerability with Bouncy Castle lib

[jira] [Commented] (SOLR-14593) Package store API to disable file upload over HTTP

2021-11-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437671#comment-17437671 ] Jan Høydahl commented on SOLR-14593: [~ichattopadhyaya] will you try to get this in a

[jira] [Resolved] (SOLR-15508) Upgrade netty artifacts to >= netty-4.1.61.Final

2021-11-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15508. Resolution: Done Already on 4.1.68.Final > Upgrade netty artifacts to >= netty-4.1.61.Final > ---

[jira] [Comment Edited] (SOLR-15715) Dedicated query aggregator nodes in the solr cluster.

2021-11-02 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437664#comment-17437664 ] Ishan Chattopadhyaya edited comment on SOLR-15715 at 11/2/21, 11:26 PM: ---

[jira] [Commented] (SOLR-15715) Dedicated query aggregator nodes in the solr cluster.

2021-11-02 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437664#comment-17437664 ] Ishan Chattopadhyaya commented on SOLR-15715: - I'd like to point out here tha

[jira] [Resolved] (SOLR-15728) Remove dead, unused log rotation code from SolrCLI

2021-11-02 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15728. Fix Version/s: main (9.0) Resolution: Fixed > Remove dead, unused log rotation code from Sol

[jira] [Commented] (SOLR-15728) Remove dead, unused log rotation code from SolrCLI

2021-11-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437661#comment-17437661 ] ASF subversion and git services commented on SOLR-15728: Commit a

[GitHub] [solr] janhoy merged pull request #375: SOLR-15728: Remove dead, unused log rotation code from SolrCLI

2021-11-02 Thread GitBox
janhoy merged pull request #375: URL: https://github.com/apache/solr/pull/375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] janhoy merged pull request #381: Bump owasp-dependencycheck to 6.4.1.1

2021-11-02 Thread GitBox
janhoy merged pull request #381: URL: https://github.com/apache/solr/pull/381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] noblepaul opened a new pull request #386: SOLR-15337: Avoid XPath in solrconfig.xml parsing (take 2)

2021-11-02 Thread GitBox
noblepaul opened a new pull request #386: URL: https://github.com/apache/solr/pull/386 @madrob I opened a new PR here to address your review comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [solr] noblepaul commented on pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-11-02 Thread GitBox
noblepaul commented on pull request #160: URL: https://github.com/apache/solr/pull/160#issuecomment-958288006 what is wrong with `import static org.apache.solr.common.ConfigNode.Helpers.*;` -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [solr] noblepaul commented on a change in pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-11-02 Thread GitBox
noblepaul commented on a change in pull request #160: URL: https://github.com/apache/solr/pull/160#discussion_r741505697 ## File path: solr/core/src/test/org/apache/solr/core/TestConfLoadPerf.java ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [solr-operator] HoustonPutman merged pull request #362: Clear up difference between SolrCloud CRD and Solr Helm chart options

2021-11-02 Thread GitBox
HoustonPutman merged pull request #362: URL: https://github.com/apache/solr-operator/pull/362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr-operator] HoustonPutman merged pull request #360: Enable Solr Operator metrics when using the helm chart.

2021-11-02 Thread GitBox
HoustonPutman merged pull request #360: URL: https://github.com/apache/solr-operator/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr-operator] gerlowskija commented on pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
gerlowskija commented on pull request #359: URL: https://github.com/apache/solr-operator/pull/359#issuecomment-957795580 > now I realize you mean a `purgeEvery` option in the CRD. I think we can assume that would be equivalent to saveEvery. Yep, that's what I was suggesting - an opti

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
HoustonPutman commented on a change in pull request #359: URL: https://github.com/apache/solr-operator/pull/359#discussion_r741153892 ## File path: api/v1beta1/solrbackup_types.go ## @@ -64,6 +71,29 @@ func (spec *SolrBackupSpec) withDefaults(backupName string) (changed bool)

[GitHub] [solr] madrob commented on a change in pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-11-02 Thread GitBox
madrob commented on a change in pull request #160: URL: https://github.com/apache/solr/pull/160#discussion_r741248212 ## File path: solr/core/src/java/org/apache/solr/util/DataConfigNode.java ## @@ -19,64 +19,72 @@ import java.util.ArrayList; import java.util.Collections; -

[GitHub] [solr-operator] HoustonPutman merged pull request #363: Ability to set ingressClassName for v1 Ingress.

2021-11-02 Thread GitBox
HoustonPutman merged pull request #363: URL: https://github.com/apache/solr-operator/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr-operator] gerlowskija edited a comment on pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
gerlowskija edited a comment on pull request #359: URL: https://github.com/apache/solr-operator/pull/359#issuecomment-957795580 > now I realize you mean a `purgeEvery` option in the CRD. I think we can assume that would be equivalent to saveEvery. Yep, that's what I was suggesting -

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #358: Specify individual backupRepo availability in SolrCloud Status

2021-11-02 Thread GitBox
HoustonPutman commented on a change in pull request #358: URL: https://github.com/apache/solr-operator/pull/358#discussion_r741135806 ## File path: config/crd/bases/solr.apache.org_solrbackups.yaml ## @@ -1053,9 +1053,12 @@ spec: type: object rep

[GitHub] [solr-operator] HoustonPutman commented on pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
HoustonPutman commented on pull request #359: URL: https://github.com/apache/solr-operator/pull/359#issuecomment-957772393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [solr-operator] HoustonPutman commented on pull request #360: Enable Solr Operator metrics when using the helm chart.

2021-11-02 Thread GitBox
HoustonPutman commented on pull request #360: URL: https://github.com/apache/solr-operator/pull/360#issuecomment-957785332 Tested manually and was able to query the operator metrics through `kubectl port-forward`. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [solr-operator] HoustonPutman closed issue #336: Add possiblity to annotate addressability.external Ingress

2021-11-02 Thread GitBox
HoustonPutman closed issue #336: URL: https://github.com/apache/solr-operator/issues/336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #357: Remove Persistence option for SolrBackup.

2021-11-02 Thread GitBox
HoustonPutman commented on a change in pull request #357: URL: https://github.com/apache/solr-operator/pull/357#discussion_r741128852 ## File path: config/crd/bases/solr.apache.org_solrbackups.yaml ## @@ -71,7 +71,7 @@ spec: description: The location to store t

[GitHub] [solr] radu-gheorghe commented on pull request #383: Update transaction log options descriptions

2021-11-02 Thread GitBox
radu-gheorghe commented on pull request #383: URL: https://github.com/apache/solr/pull/383#issuecomment-957397496 I'm not sure if a Jira is needed for this small change, but I can surely create one if needed. Thanks! -- This is an automated message from the Apache Git Service. To respond

[GitHub] [solr] dsmiley commented on pull request #349: Dependency tune-up of solr-core

2021-11-02 Thread GitBox
dsmiley commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-958100164 I'll commit this tonight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] thelabdude merged pull request #355: SOLR-12666: Add authn & authz plugins that supports multiple authentication schemes, such as Bearer and Basic

2021-11-02 Thread GitBox
thelabdude merged pull request #355: URL: https://github.com/apache/solr/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr-operator] gerlowskija commented on a change in pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
gerlowskija commented on a change in pull request #359: URL: https://github.com/apache/solr-operator/pull/359#discussion_r740493719 ## File path: api/v1beta1/solrbackup_types.go ## @@ -64,6 +71,29 @@ func (spec *SolrBackupSpec) withDefaults(backupName string) (changed bool) {

[GitHub] [solr-operator] thelabdude commented on pull request #346: Ability to get a JWT token from an OIDC provider to make calls to Solr secured by the JWTAuthPlugin

2021-11-02 Thread GitBox
thelabdude commented on pull request #346: URL: https://github.com/apache/solr-operator/pull/346#issuecomment-956590931 Now this PR only has OIDC related changes in it. However, it's unlikely I'll merge this into main anytime soon given the limitations with JWT / OIDC on the Solr side (see

[jira] [Assigned] (SOLR-15706) After an incremental back up, the pugeUnused operation incorrectly deletes all backed up data

2021-11-02 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski reassigned SOLR-15706: -- Assignee: Jason Gerlowski > After an incremental back up, the pugeUnused operation inc

[GitHub] [solr] dsmiley commented on pull request #349: Dependency tune-up of solr-core

2021-11-02 Thread GitBox
dsmiley commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-958100164 I'll commit this tonight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (SOLR-15707) Ability to set the AWS Profile for each S3Repository

2021-11-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437543#comment-17437543 ] ASF subversion and git services commented on SOLR-15707: Commit 7

[GitHub] [solr-operator] HoustonPutman merged pull request #362: Clear up difference between SolrCloud CRD and Solr Helm chart options

2021-11-02 Thread GitBox
HoustonPutman merged pull request #362: URL: https://github.com/apache/solr-operator/pull/362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr-operator] HoustonPutman merged pull request #360: Enable Solr Operator metrics when using the helm chart.

2021-11-02 Thread GitBox
HoustonPutman merged pull request #360: URL: https://github.com/apache/solr-operator/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr-operator] thelabdude commented on pull request #346: Ability to get a JWT token from an OIDC provider to make calls to Solr secured by the JWTAuthPlugin

2021-11-02 Thread GitBox
thelabdude commented on pull request #346: URL: https://github.com/apache/solr-operator/pull/346#issuecomment-956590931 Now this PR only has OIDC related changes in it. However, it's unlikely I'll merge this into main anytime soon given the limitations with JWT / OIDC on the Solr side (see

[jira] [Commented] (SOLR-15707) Ability to set the AWS Profile for each S3Repository

2021-11-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437522#comment-17437522 ] ASF subversion and git services commented on SOLR-15707: Commit 7

[GitHub] [solr-operator] gerlowskija commented on pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
gerlowskija commented on pull request #359: URL: https://github.com/apache/solr-operator/pull/359#issuecomment-957795580 > now I realize you mean a `purgeEvery` option in the CRD. I think we can assume that would be equivalent to saveEvery. Yep, that's what I was suggesting - an opti

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
HoustonPutman commented on a change in pull request #359: URL: https://github.com/apache/solr-operator/pull/359#discussion_r741153892 ## File path: api/v1beta1/solrbackup_types.go ## @@ -64,6 +71,29 @@ func (spec *SolrBackupSpec) withDefaults(backupName string) (changed bool)

[GitHub] [solr-operator] gerlowskija commented on a change in pull request #357: Remove Persistence option for SolrBackup.

2021-11-02 Thread GitBox
gerlowskija commented on a change in pull request #357: URL: https://github.com/apache/solr-operator/pull/357#discussion_r740304414 ## File path: config/crd/bases/solr.apache.org_solrbackups.yaml ## @@ -1106,7 +1106,7 @@ spec: description: Whether the backup ha

[GitHub] [solr-operator] gerlowskija edited a comment on pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
gerlowskija edited a comment on pull request #359: URL: https://github.com/apache/solr-operator/pull/359#issuecomment-957795580 > now I realize you mean a `purgeEvery` option in the CRD. I think we can assume that would be equivalent to saveEvery. Yep, that's what I was suggesting -

[GitHub] [solr-operator] gerlowskija commented on a change in pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
gerlowskija commented on a change in pull request #359: URL: https://github.com/apache/solr-operator/pull/359#discussion_r740493719 ## File path: api/v1beta1/solrbackup_types.go ## @@ -64,6 +71,29 @@ func (spec *SolrBackupSpec) withDefaults(backupName string) (changed bool) {

[GitHub] [solr] madrob commented on pull request #376: SOLR-15635: don't repeat close hooks if SRI cleared twice

2021-11-02 Thread GitBox
madrob commented on pull request #376: URL: https://github.com/apache/solr/pull/376#issuecomment-956423330 When I was working on SOLR-1, the current behavior of closing the SRI helped me find a bug, so I'm reasonably confident that we don't want to change things to strict. If we do, th

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #358: Specify individual backupRepo availability in SolrCloud Status

2021-11-02 Thread GitBox
HoustonPutman commented on a change in pull request #358: URL: https://github.com/apache/solr-operator/pull/358#discussion_r741135806 ## File path: config/crd/bases/solr.apache.org_solrbackups.yaml ## @@ -1053,9 +1053,12 @@ spec: type: object rep

[GitHub] [solr] madrob commented on a change in pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-11-02 Thread GitBox
madrob commented on a change in pull request #160: URL: https://github.com/apache/solr/pull/160#discussion_r741248212 ## File path: solr/core/src/java/org/apache/solr/util/DataConfigNode.java ## @@ -19,64 +19,72 @@ import java.util.ArrayList; import java.util.Collections; -

[GitHub] [solr-operator] HoustonPutman merged pull request #363: Ability to set ingressClassName for v1 Ingress.

2021-11-02 Thread GitBox
HoustonPutman merged pull request #363: URL: https://github.com/apache/solr-operator/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr-operator] HoustonPutman commented on pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
HoustonPutman commented on pull request #359: URL: https://github.com/apache/solr-operator/pull/359#issuecomment-957772393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [solr-operator] HoustonPutman commented on pull request #360: Enable Solr Operator metrics when using the helm chart.

2021-11-02 Thread GitBox
HoustonPutman commented on pull request #360: URL: https://github.com/apache/solr-operator/pull/360#issuecomment-957785332 Tested manually and was able to query the operator metrics through `kubectl port-forward`. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [solr] thelabdude merged pull request #355: SOLR-12666: Add authn & authz plugins that supports multiple authentication schemes, such as Bearer and Basic

2021-11-02 Thread GitBox
thelabdude merged pull request #355: URL: https://github.com/apache/solr/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [solr-operator] HoustonPutman closed issue #336: Add possiblity to annotate addressability.external Ingress

2021-11-02 Thread GitBox
HoustonPutman closed issue #336: URL: https://github.com/apache/solr-operator/issues/336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #357: Remove Persistence option for SolrBackup.

2021-11-02 Thread GitBox
HoustonPutman commented on a change in pull request #357: URL: https://github.com/apache/solr-operator/pull/357#discussion_r741128852 ## File path: config/crd/bases/solr.apache.org_solrbackups.yaml ## @@ -71,7 +71,7 @@ spec: description: The location to store t

[GitHub] [solr] radu-gheorghe commented on pull request #383: Update transaction log options descriptions

2021-11-02 Thread GitBox
radu-gheorghe commented on pull request #383: URL: https://github.com/apache/solr/pull/383#issuecomment-957397496 I'm not sure if a Jira is needed for this small change, but I can surely create one if needed. Thanks! -- This is an automated message from the Apache Git Service. To respond

[GitHub] [solr-operator] HoustonPutman merged pull request #363: Ability to set ingressClassName for v1 Ingress.

2021-11-02 Thread GitBox
HoustonPutman merged pull request #363: URL: https://github.com/apache/solr-operator/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[jira] [Assigned] (SOLR-15760) Improve default distributed facet overrequest function/heuristic

2021-11-02 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney reassigned SOLR-15760: - Assignee: Michael Gibney > Improve default distributed facet overrequest function/heuris

[GitHub] [solr] magibney opened a new pull request #385: SOLR-15760: Improve the default distributed facet overrequest function/heuristic

2021-11-02 Thread GitBox
magibney opened a new pull request #385: URL: https://github.com/apache/solr/pull/385 See: [SOLR-15760](https://issues.apache.org/jira/browse/SOLR-15760) For logical consistency, distributed facet overrequest should make no distinction between offset and limit; instead, distributed o

[jira] [Updated] (SOLR-15761) Remove JdbcStream from Lang

2021-11-02 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15761: -- Description: This ticket will remove the JdbcStream from the Streaming Expression library by re

[jira] [Created] (SOLR-15761) Remove JdbcStream from lang

2021-11-02 Thread Joel Bernstein (Jira)
Joel Bernstein created SOLR-15761: - Summary: Remove JdbcStream from lang Key: SOLR-15761 URL: https://issues.apache.org/jira/browse/SOLR-15761 Project: Solr Issue Type: Improvement Secu

[jira] [Updated] (SOLR-15761) Remove JdbcStream from Lang

2021-11-02 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15761: -- Summary: Remove JdbcStream from Lang (was: Remove JdbcStream from lang) > Remove JdbcStream fr

[jira] [Commented] (SOLR-15337) Avoid XPath in solrconfig.xml parsing

2021-11-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437463#comment-17437463 ] Mike Drob commented on SOLR-15337: -- [~noble.paul] - I have some more comments that I wis

[GitHub] [solr] madrob commented on a change in pull request #160: SOLR-15337: Avoid XPath in solrconfig.xml parsing

2021-11-02 Thread GitBox
madrob commented on a change in pull request #160: URL: https://github.com/apache/solr/pull/160#discussion_r741248212 ## File path: solr/core/src/java/org/apache/solr/util/DataConfigNode.java ## @@ -19,64 +19,72 @@ import java.util.ArrayList; import java.util.Collections; -

[jira] [Commented] (SOLR-15760) Improve default distributed facet overrequest function/heuristic

2021-11-02 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437462#comment-17437462 ] Michael Gibney commented on SOLR-15760: --- This change is admittedly minor and arcane

[jira] [Updated] (SOLR-15760) Improve default distributed facet overrequest function/heuristic

2021-11-02 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney updated SOLR-15760: -- Description: In {{FacetFieldProcessor}} for distributed requests, additive {{facet.overrequest

[jira] [Created] (SOLR-15760) Improve default distributed facet overrequest function/heuristic

2021-11-02 Thread Michael Gibney (Jira)
Michael Gibney created SOLR-15760: - Summary: Improve default distributed facet overrequest function/heuristic Key: SOLR-15760 URL: https://issues.apache.org/jira/browse/SOLR-15760 Project: Solr

[jira] [Created] (SOLR-15759) clean cloud collection terms

2021-11-02 Thread Constantin Mitocaru (Jira)
Constantin Mitocaru created SOLR-15759: -- Summary: clean cloud collection terms Key: SOLR-15759 URL: https://issues.apache.org/jira/browse/SOLR-15759 Project: Solr Issue Type: Bug S

[GitHub] [solr-operator] HoustonPutman commented on pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
HoustonPutman commented on pull request #359: URL: https://github.com/apache/solr-operator/pull/359#issuecomment-957835892 > When you mention "saveEvery" I assume you mean maxSaved? Or is there some other "saveEvery" param I missed? I mis-typed. I meant `maxSaved` 🙂 -- This is an

[GitHub] [solr-operator] gerlowskija edited a comment on pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
gerlowskija edited a comment on pull request #359: URL: https://github.com/apache/solr-operator/pull/359#issuecomment-957795580 > now I realize you mean a `purgeEvery` option in the CRD. I think we can assume that would be equivalent to saveEvery. Yep, that's what I was suggesting -

[GitHub] [solr-operator] gerlowskija commented on pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
gerlowskija commented on pull request #359: URL: https://github.com/apache/solr-operator/pull/359#issuecomment-957795580 > now I realize you mean a `purgeEvery` option in the CRD. I think we can assume that would be equivalent to saveEvery. Yep, that's what I was suggesting - an opti

[jira] [Assigned] (SOLR-14679) TLOGs grow forever, never get out of BUFFERING state

2021-11-02 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter reassigned SOLR-14679: - Assignee: (was: Timothy Potter) > TLOGs grow forever, never get out of BUFFERING sta

[GitHub] [solr-operator] HoustonPutman merged pull request #360: Enable Solr Operator metrics when using the helm chart.

2021-11-02 Thread GitBox
HoustonPutman merged pull request #360: URL: https://github.com/apache/solr-operator/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr-operator] HoustonPutman commented on pull request #360: Enable Solr Operator metrics when using the helm chart.

2021-11-02 Thread GitBox
HoustonPutman commented on pull request #360: URL: https://github.com/apache/solr-operator/pull/360#issuecomment-957785332 Tested manually and was able to query the operator metrics through `kubectl port-forward`. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [solr-operator] HoustonPutman merged pull request #362: Clear up difference between SolrCloud CRD and Solr Helm chart options

2021-11-02 Thread GitBox
HoustonPutman merged pull request #362: URL: https://github.com/apache/solr-operator/pull/362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [solr-operator] HoustonPutman closed issue #336: Add possiblity to annotate addressability.external Ingress

2021-11-02 Thread GitBox
HoustonPutman closed issue #336: URL: https://github.com/apache/solr-operator/issues/336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [solr-operator] HoustonPutman commented on pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
HoustonPutman commented on pull request #359: URL: https://github.com/apache/solr-operator/pull/359#issuecomment-957772393 1. I'm content with a `purgeEvery` option in Solr. I'm not sure I understand why you would want un-garbage collected index files laying about, but that's definitely a

[jira] [Commented] (SOLR-13070) Add JWT Auth support in SolrJ

2021-11-02 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437415#comment-17437415 ] Timothy Potter commented on SOLR-13070: --- Un-assigned myself as I'm probably not goi

[jira] [Assigned] (SOLR-13070) Add JWT Auth support in SolrJ

2021-11-02 Thread Timothy Potter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter reassigned SOLR-13070: - Assignee: (was: Timothy Potter) > Add JWT Auth support in SolrJ > --

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #359: Add ability to schedule recurring incremental backups

2021-11-02 Thread GitBox
HoustonPutman commented on a change in pull request #359: URL: https://github.com/apache/solr-operator/pull/359#discussion_r741153892 ## File path: api/v1beta1/solrbackup_types.go ## @@ -64,6 +71,29 @@ func (spec *SolrBackupSpec) withDefaults(backupName string) (changed bool)

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #358: Specify individual backupRepo availability in SolrCloud Status

2021-11-02 Thread GitBox
HoustonPutman commented on a change in pull request #358: URL: https://github.com/apache/solr-operator/pull/358#discussion_r741150582 ## File path: helm/solr-operator/crds/crds.yaml ## @@ -1053,9 +1053,12 @@ spec: type: object repositoryName:

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #358: Specify individual backupRepo availability in SolrCloud Status

2021-11-02 Thread GitBox
HoustonPutman commented on a change in pull request #358: URL: https://github.com/apache/solr-operator/pull/358#discussion_r741140522 ## File path: api/v1beta1/solrcloud_types.go ## @@ -385,6 +385,8 @@ type SolrBackupRestoreOptions struct { type SolrBackupRepository struct {

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #358: Specify individual backupRepo availability in SolrCloud Status

2021-11-02 Thread GitBox
HoustonPutman commented on a change in pull request #358: URL: https://github.com/apache/solr-operator/pull/358#discussion_r741135806 ## File path: config/crd/bases/solr.apache.org_solrbackups.yaml ## @@ -1053,9 +1053,12 @@ spec: type: object rep

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #357: Remove Persistence option for SolrBackup.

2021-11-02 Thread GitBox
HoustonPutman commented on a change in pull request #357: URL: https://github.com/apache/solr-operator/pull/357#discussion_r741128852 ## File path: config/crd/bases/solr.apache.org_solrbackups.yaml ## @@ -71,7 +71,7 @@ spec: description: The location to store t

[jira] [Updated] (SOLR-14926) Modernize and clean up document clustering contrib

2021-11-02 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cassandra Targett updated SOLR-14926: - Component/s: contrib - Clustering > Modernize and clean up document clustering contrib >

[GitHub] [solr] cpoerschke opened a new pull request #384: SOLR-15758: in UpdateLog allow numDeletes[ByQuery]ToKeep customisation

2021-11-02 Thread GitBox
cpoerschke opened a new pull request #384: URL: https://github.com/apache/solr/pull/384 https://issues.apache.org/jira/browse/SOLR-15758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (SOLR-15758) in UpdateLog allow numDeletes[ByQuery]ToKeep customisation

2021-11-02 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437371#comment-17437371 ] Christine Poerschke commented on SOLR-15758: If one increases {{numRecordsToK

[jira] [Created] (SOLR-15758) in UpdateLog allow numDeletes[ByQuery]ToKeep customisation

2021-11-02 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-15758: -- Summary: in UpdateLog allow numDeletes[ByQuery]ToKeep customisation Key: SOLR-15758 URL: https://issues.apache.org/jira/browse/SOLR-15758 Project: Solr

[GitHub] [solr] radu-gheorghe commented on pull request #383: Update transaction log options descriptions

2021-11-02 Thread GitBox
radu-gheorghe commented on pull request #383: URL: https://github.com/apache/solr/pull/383#issuecomment-957397496 I'm not sure if a Jira is needed for this small change, but I can surely create one if needed. Thanks! -- This is an automated message from the Apache Git Service. To respond

[GitHub] [solr] radu-gheorghe opened a new pull request #383: Update transaction log options descriptions

2021-11-02 Thread GitBox
radu-gheorghe opened a new pull request #383: URL: https://github.com/apache/solr/pull/383 If my understanding of the UpdateLog code is right (I'm looking at this bit in particular: https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/update/UpdateLog.java#L506-L519)

[jira] [Commented] (SOLR-15720) Need a DelegationTokenHttp2SolrClient for the new Jetty client

2021-11-02 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437230#comment-17437230 ] Noble Paul commented on SOLR-15720: --- I did not write that. I probably would've committe