[ 
https://issues.apache.org/jira/browse/SOLR-15758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437371#comment-17437371
 ] 

Christine Poerschke commented on SOLR-15758:
--------------------------------------------

If one increases {{numRecordsToKeep}} above the {{100}} default then 
intuitively it would seem logical that {{numDeletesToKeep}} and 
{{numDeletesByQueryToKeep}} might need to increase too, though I don't (yet) 
have a fully conclusive narrative as to why (other than that the default 
{{numRecordsToKeep}} matches hard-coded {{numDeletesByQueryToKeep}} value) and 
when/how exactly non-increasing could manifest in issues.


> in UpdateLog allow numDeletes[ByQuery]ToKeep customisation
> ----------------------------------------------------------
>
>                 Key: SOLR-15758
>                 URL: https://issues.apache.org/jira/browse/SOLR-15758
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>
> {{numRecordsToKeep}} and {{maxNumLogsToKeep}} are customisable since 
> SOLR-6359 and default to {{100}} and {{10}} respectively: 
> [https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.10.1/solr/core/src/java/org/apache/solr/update/UpdateLog.java#L343-L344]
> {{numDeletesToKeep}} and {{numDeletesByQueryToKeep}} are currently hard-coded 
> to {{1000}} and {{100}} respectively: 
> [https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.10.1/solr/core/src/java/org/apache/solr/update/UpdateLog.java#L204-L205]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to