HoustonPutman commented on a change in pull request #358:
URL: https://github.com/apache/solr-operator/pull/358#discussion_r741135806
##########
File path: config/crd/bases/solr.apache.org_solrbackups.yaml
##########
@@ -1053,9 +1053,12 @@ spec:
type: object
repositoryName:
description: The name of the repository to use for the backup.
Defaults to "legacy_local_repository" if not specified (the auto-configured
repository for legacy singleton volumes).
+ pattern: '[a-zA-Z0-9]([-_a-zA-Z0-9]*[a-zA-Z0-9])?'
type: string
solrCloud:
description: A reference to the SolrCloud to create a backup
for
+ minLength: 63
Review comment:
nah, I actually meant maxLength here (because kubernetes resource names
cannot go beyond 63 characters:
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names)
Good find!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
