[GitHub] [solr] dweiss commented on a change in pull request #304: SOLR-15455: joint solr/lucene development experiments

2021-10-01 Thread GitBox
dweiss commented on a change in pull request #304: URL: https://github.com/apache/solr/pull/304#discussion_r720639346 ## File path: gradle/lucene-dev/lucene-dev-repo-composite.gradle ## @@ -0,0 +1,159 @@ +import java.util.function.BiFunction + +/* + * Licensed to the Apache Sof

[GitHub] [solr] markrmiller commented on pull request #53: SOLR-15301 Eliminate repetitive index size calculation for Solr metrics

2021-10-01 Thread GitBox
markrmiller commented on pull request #53: URL: https://github.com/apache/solr/pull/53#issuecomment-932677247 Nice, this can be a very expensive call and there is no real limit on how often metrics may be generated - in a jmx case it was the case and may still be that for every metric in a

[GitHub] [solr] markrmiller edited a comment on pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

2021-10-01 Thread GitBox
markrmiller edited a comment on pull request #311: URL: https://github.com/apache/solr/pull/311#issuecomment-932675308 A quick look at why, unrelated to your efforts here, I'm a bit pre-frustrated with debating this issue and being told it's already been solved for me. I run a sampl

[jira] [Commented] (SOLR-15646) Add a non secure RSAKeyPair keygen mode for tests.

2021-10-01 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423459#comment-17423459 ] Mark Robert Miller commented on SOLR-15646: --- I setup a quick visual tour in the

[GitHub] [solr] markrmiller commented on pull request #311: SOLR-15646: Add a non secure RSAKeyPair keygen mode for tests.

2021-10-01 Thread GitBox
markrmiller commented on pull request #311: URL: https://github.com/apache/solr/pull/311#issuecomment-932675308 A quick look at why, unrelated to your efforts here, I'm a bit pre-frustrated with debating this issue and being told it's already been solved for me. I run a sample of te

[GitHub] [solr-operator] dsmiley commented on issue #329: Support Contrib Modules and additional libraries

2021-10-01 Thread GitBox
dsmiley commented on issue #329: URL: https://github.com/apache/solr-operator/issues/329#issuecomment-932614884 I'm skeptical we should use the word "contrib". Yes, Solr has such a directory, but I think this was a mistake. Contributed by who and who cares any way how it got there? If i

[GitHub] [solr-operator] thelabdude opened a new pull request #334: Refactor security related code into a separate solr_security_util.go vs. sprinkled throughout the codebase.

2021-10-01 Thread GitBox
thelabdude opened a new pull request #334: URL: https://github.com/apache/solr-operator/pull/334 There's probably more we can do with the security code, but I'll tackle additional changes when I work on #331 as most of the remaining changes to the security code would be related to supporti

[GitHub] [solr] madrob commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2021-10-01 Thread GitBox
madrob commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r720538357 ## File path: solr/contrib/README.md ## @@ -0,0 +1,31 @@ +Apache Solr HDFS Contrib module Review comment: Should this be under the hfs contrib directory

[jira] [Commented] (SOLR-15653) Fix collection creation race that assumes a local clusterstate when the collection has only just been created.

2021-10-01 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423422#comment-17423422 ] Mark Robert Miller commented on SOLR-15653: --- Cause of PerReplicaStatesIntegrati

[GitHub] [solr] markrmiller opened a new pull request #325: SOLR-15653: Fix collection creation race that assumes a local cluster…

2021-10-01 Thread GitBox
markrmiller opened a new pull request #325: URL: https://github.com/apache/solr/pull/325 …state when the collection has only just been created. https://issues.apache.org/jira/browse/SOLR-15653 -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #324: SOLR-14660 - move HDFS to a contrib module

2021-10-01 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r720506575 ## File path: solr/contrib/hdfs/build.gradle ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[jira] [Commented] (SOLR-14660) Migrating HDFS into a package

2021-10-01 Thread Istvan Farkas (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423405#comment-17423405 ] Istvan Farkas commented on SOLR-14660: -- [~ichattopadhyaya], [~dsmiley]: I created th

[GitHub] [solr] warperwolf opened a new pull request #324: SOLR-14660 - move HDFS to a contrib module

2021-10-01 Thread GitBox
warperwolf opened a new pull request #324: URL: https://github.com/apache/solr/pull/324 https://issues.apache.org/jira/browse/SOLR-14660 # Description This PR moves HDFS from Core to a Contrib module. Note: I kept separate commits to make it easier to review and to chang

[GitHub] [solr] magibney commented on a change in pull request #304: SOLR-15455: joint solr/lucene development experiments

2021-10-01 Thread GitBox
magibney commented on a change in pull request #304: URL: https://github.com/apache/solr/pull/304#discussion_r720485564 ## File path: gradle/lucene-dev/lucene-dev-repo-composite.gradle ## @@ -0,0 +1,159 @@ +import java.util.function.BiFunction + +/* + * Licensed to the Apache S

[jira] [Commented] (SOLR-15301) Eliminate repetitive index size calculation for Solr metrics

2021-10-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423400#comment-17423400 ] David Smiley commented on SOLR-15301: - The deadline could be defined as twice the tim

[GitHub] [solr-operator] thelabdude commented on issue #331: Support JWT authentication

2021-10-01 Thread GitBox
thelabdude commented on issue #331: URL: https://github.com/apache/solr-operator/issues/331#issuecomment-932395342 Will take this one up after I clean up the security code for #333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [solr-operator] thelabdude opened a new issue #333: Refactor security bootstrapping / basic auth code to be more modular vs. infused throughout the controller and util

2021-10-01 Thread GitBox
thelabdude opened a new issue #333: URL: https://github.com/apache/solr-operator/issues/333 Similar to what was done for the TLS code here: https://github.com/apache/solr-operator/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [solr] dweiss commented on a change in pull request #304: SOLR-15455: joint solr/lucene development experiments

2021-10-01 Thread GitBox
dweiss commented on a change in pull request #304: URL: https://github.com/apache/solr/pull/304#discussion_r720399760 ## File path: gradle/lucene-dev/lucene-dev-repo-composite.gradle ## @@ -0,0 +1,159 @@ +import java.util.function.BiFunction + +/* + * Licensed to the Apache Sof

[jira] [Comment Edited] (SOLR-15666) Heavily reduce faceting ram usage for many cases.

2021-10-01 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423362#comment-17423362 ] Mark Robert Miller edited comment on SOLR-15666 at 10/1/21, 4:24 PM: --

[jira] [Commented] (SOLR-15666) Heavily reduce faceting ram usage for many cases.

2021-10-01 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423362#comment-17423362 ] Mark Robert Miller commented on SOLR-15666: --- This issue collaborates with SOLR-

[jira] [Commented] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423359#comment-17423359 ] Dawid Weiss commented on SOLR-15670: I tried to document it, briefly: https://github.

[jira] [Commented] (SOLR-15671) Add SparseBitSet option for faster faceting, lower memory usage, and reduced gc at scael.

2021-10-01 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423345#comment-17423345 ] Mark Robert Miller commented on SOLR-15671: --- This kind of pairs with SOLR-15510

[GitHub] [solr] magibney commented on a change in pull request #304: SOLR-15455: joint solr/lucene development experiments

2021-10-01 Thread GitBox
magibney commented on a change in pull request #304: URL: https://github.com/apache/solr/pull/304#discussion_r720360992 ## File path: gradle/lucene-dev/lucene-dev-repo-composite.gradle ## @@ -0,0 +1,159 @@ +import java.util.function.BiFunction + +/* + * Licensed to the Apache S

[jira] [Created] (SOLR-15671) Add SparseBitSet option for faster faceting, lower memory usage, and reduced gc at scael.

2021-10-01 Thread Mark Robert Miller (Jira)
Mark Robert Miller created SOLR-15671: - Summary: Add SparseBitSet option for faster faceting, lower memory usage, and reduced gc at scael. Key: SOLR-15671 URL: https://issues.apache.org/jira/browse/SOLR-15671

[jira] [Updated] (SOLR-15510) Add off heap BitSet data structure option and ByteBuffer caching for reduced GC at scale.

2021-10-01 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Robert Miller updated SOLR-15510: -- Summary: Add off heap BitSet data structure option and ByteBuffer caching for reduced G

[GitHub] [solr] magibney commented on a change in pull request #304: SOLR-15455: joint solr/lucene development experiments

2021-10-01 Thread GitBox
magibney commented on a change in pull request #304: URL: https://github.com/apache/solr/pull/304#discussion_r720344289 ## File path: gradle/lucene-dev/lucene-dev-repo-composite.gradle ## @@ -0,0 +1,159 @@ +import java.util.function.BiFunction + +/* + * Licensed to the Apache S

[GitHub] [solr] magibney closed pull request #303: SOLR-15455: Support building against local Lucene SNAPSHOT version

2021-10-01 Thread GitBox
magibney closed pull request #303: URL: https://github.com/apache/solr/pull/303 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[GitHub] [solr] magibney commented on pull request #303: SOLR-15455: Support building against local Lucene SNAPSHOT version

2021-10-01 Thread GitBox
magibney commented on pull request #303: URL: https://github.com/apache/solr/pull/303#issuecomment-932269351 Superseded by #304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [solr] epugh commented on pull request #296: SOLR-15626: Fix `config-read` permission.

2021-10-01 Thread GitBox
epugh commented on pull request #296: URL: https://github.com/apache/solr/pull/296#issuecomment-932263972 I am manually testing this now... ;-) Just want to confirm it all works as advertised since I haven't worked in this area a lot -- This is an automated message from the Apache

[GitHub] [solr] magibney commented on a change in pull request #304: SOLR-15455: joint solr/lucene development experiments

2021-10-01 Thread GitBox
magibney commented on a change in pull request #304: URL: https://github.com/apache/solr/pull/304#discussion_r720276293 ## File path: gradle/lucene-dev/lucene-dev-repo-composite.gradle ## @@ -0,0 +1,159 @@ +import java.util.function.BiFunction + +/* + * Licensed to the Apache S

[jira] [Commented] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-01 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423258#comment-17423258 ] David Eric Pugh commented on SOLR-15670: Could we solve this by maybe just docume

[GitHub] [solr] dweiss commented on pull request #304: SOLR-15455: joint solr/lucene development experiments

2021-10-01 Thread GitBox
dweiss commented on pull request #304: URL: https://github.com/apache/solr/pull/304#issuecomment-932034781 Updated the patch, @magibney would you care to test it out? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Commented] (SOLR-15301) Eliminate repetitive index size calculation for Solr metrics

2021-10-01 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423179#comment-17423179 ] Andras Salamon commented on SOLR-15301: --- Asking only for specific metrics instead o

[jira] [Commented] (SOLR-15670) Introduce Gradle parameter to skip ref-guide tasks

2021-10-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423149#comment-17423149 ] Dawid Weiss commented on SOLR-15670: bq. Adding an opt-in option to skip all ref-guid

[GitHub] [solr] dweiss commented on a change in pull request #323: SOLR-15670: Introduce Gradle parameter to skip ref-guide tasks

2021-10-01 Thread GitBox
dweiss commented on a change in pull request #323: URL: https://github.com/apache/solr/pull/323#discussion_r719995908 ## File path: solr/solr-ref-guide/build.gradle ## @@ -38,6 +38,17 @@ versionsLock { description = 'Solr reference guide' +def shouldSkipTasks = propertyOrE

[GitHub] [solr] dweiss commented on a change in pull request #323: SOLR-15670: Introduce Gradle parameter to skip ref-guide tasks

2021-10-01 Thread GitBox
dweiss commented on a change in pull request #323: URL: https://github.com/apache/solr/pull/323#discussion_r719991011 ## File path: solr/solr-ref-guide/build.gradle ## @@ -38,6 +38,17 @@ versionsLock { description = 'Solr reference guide' +def shouldSkipTasks = propertyOrE