markrmiller commented on pull request #225:
URL: https://github.com/apache/solr/pull/225#issuecomment-922177487
I have a merge up to 7 locally I believe. I've kicked off a 9 build to pull
in the latest and that is likely a good point to merge in.
--
This is an automated message from the
markrmiller commented on a change in pull request #225:
URL: https://github.com/apache/solr/pull/225#discussion_r711466089
##
File path: solr/core/src/test/org/apache/solr/search/FuzzySearchTest.java
##
@@ -51,6 +52,7 @@ public void setupCollection() throws Exception {
}
markrmiller commented on a change in pull request #225:
URL: https://github.com/apache/solr/pull/225#discussion_r711464755
##
File path: solr/core/src/java/org/apache/solr/analysis/TokenizerChain.java
##
@@ -49,7 +49,6 @@ public TokenizerChain(CustomAnalyzer customAnalyzer) {
[
https://issues.apache.org/jira/browse/SOLR-15333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416905#comment-17416905
]
Mike Drob commented on SOLR-15333:
--
Thanks for the patch. I took a look at it, it feels
[
https://issues.apache.org/jira/browse/SOLR-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416900#comment-17416900
]
Mike Drob commented on SOLR-1:
--
Thanks for the keen eye, Hoss. I've committed the ch
[
https://issues.apache.org/jira/browse/SOLR-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-15415:
-
Parent: SOLR-15636
Issue Type: Sub-task (was: Improvement)
> Use ZooKeeperServerEmbedded for tes
[
https://issues.apache.org/jira/browse/SOLR-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-15636:
-
Security: (was: Public)
> Robust support for running Solr with an embedded zookeeper
> --
Mike Drob created SOLR-15636:
Summary: Robust support for running Solr with an embedded zookeeper
Key: SOLR-15636
URL: https://issues.apache.org/jira/browse/SOLR-15636
Project: Solr
Issue Type: N
TheSench edited a comment on pull request #296:
URL: https://github.com/apache/solr/pull/296#issuecomment-922010030
> Also, as far as "integration" tests, in the Solr world, we just put them
all together! If it's a long running test, we label them with that attribute,
but in terms of the c
TheSench commented on pull request #296:
URL: https://github.com/apache/solr/pull/296#issuecomment-922010030
> Also, as far as "integration" tests, in the Solr world, we just put them
all together! If it's a long running test, we label them with that attribute,
but in terms of the code lay
sonatype-lift[bot] commented on a change in pull request #238:
URL: https://github.com/apache/solr/pull/238#discussion_r711275631
##
File path:
solr/core/src/java/org/apache/solr/handler/admin/HealthCheckHandler.java
##
@@ -135,6 +157,77 @@ public void handleRequestBody(SolrQu
anshumg commented on a change in pull request #238:
URL: https://github.com/apache/solr/pull/238#discussion_r711275583
##
File path:
solr/core/src/java/org/apache/solr/handler/admin/HealthCheckHandler.java
##
@@ -135,6 +157,77 @@ public void handleRequestBody(SolrQueryRequest
epugh commented on pull request #296:
URL: https://github.com/apache/solr/pull/296#issuecomment-921968952
Also, as far as "integration" tests, in the Solr world, we just put them all
together! If it's a long running test, we label them with that attribute, but
in terms of the code layout,
epugh commented on pull request #298:
URL: https://github.com/apache/solr/pull/298#issuecomment-921966326
This will make life easier when I run mutliple versions of Solr on a single
ZK cluster!Out of curiosity, would you ever NOT want it to be autocreated?
Is adding a switch that op
HoustonPutman commented on pull request #298:
URL: https://github.com/apache/solr/pull/298#issuecomment-921954381
Can we add this add an optional Env Var as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
anshumg commented on pull request #238:
URL: https://github.com/apache/solr/pull/238#issuecomment-921954081
I spoke/worked with Pushkar about not using
`systemSetPropertySolrDisableUrlAllowList` and instead explicitly setting
allowedURLs but that ended up being not a valid way forward. The
[
https://issues.apache.org/jira/browse/SOLR-15209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416811#comment-17416811
]
Ilan Ginzburg commented on SOLR-15209:
--
How about your proposal [I rephrased in the
[
https://issues.apache.org/jira/browse/SOLR-7642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416809#comment-17416809
]
Christine Poerschke commented on SOLR-7642:
---
Hello. Just joining the ticket here
cpoerschke opened a new pull request #298:
URL: https://github.com/apache/solr/pull/298
https://issues.apache.org/jira/browse/SOLR-7642
Converting the patches from Steve Molloy and Isabelle Giguere into a pull
request.
--
This is an automated message from the Apache Git Servic
TheSench commented on pull request #296:
URL: https://github.com/apache/solr/pull/296#issuecomment-921930622
> Congrats on your first contribution! To make sure this does not stall, we
could consider opening a new JIRA issue for adding an integration test, and be
able to merge this one-lin
cpoerschke opened a new pull request #297:
URL: https://github.com/apache/solr/pull/297
https://issues.apache.org/jira/browse/SOLR-15173
https://github.com/apache/lucene/pull/305 is for `lucene/main` branch
equivalent, i tried having one `lucene-solr/branch_8x` commit and
cherry-pic
[
https://issues.apache.org/jira/browse/SOLR-15209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416763#comment-17416763
]
Ilan Ginzburg commented on SOLR-15209:
--
I'm not so keen on mixing environment variab
[
https://issues.apache.org/jira/browse/SOLR-9060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416758#comment-17416758
]
Cassandra Targett commented on SOLR-9060:
-
While it's interesting that the behavio
praste commented on a change in pull request #238:
URL: https://github.com/apache/solr/pull/238#discussion_r709527443
##
File path:
solr/core/src/java/org/apache/solr/handler/admin/HealthCheckHandler.java
##
@@ -135,6 +153,80 @@ public void handleRequestBody(SolrQueryRequest r
janhoy commented on pull request #296:
URL: https://github.com/apache/solr/pull/296#issuecomment-921736920
Congrats on your first contribution! To make sure this does not stall, we
could consider opening a new JIRA issue for adding an integration test, and be
able to merge this one-liner w
TheSench commented on pull request #296:
URL: https://github.com/apache/solr/pull/296#issuecomment-921732111
> So... Thoughts on putting in a Unit Test? I think there is going to be a
LOT of these types of issues, and that having tests would be great. I think you
might be creating a new st
epugh edited a comment on pull request #296:
URL: https://github.com/apache/solr/pull/296#issuecomment-921728331
So... Thoughts on putting in a Unit Test? I think there is going to be a
LOT of these types of issues, and that having tests would be great. I think
you might be creating
epugh commented on pull request #296:
URL: https://github.com/apache/solr/pull/296#issuecomment-921728331
So... Thoughts on putting in a Unit Test? I think there is going to be a
LOT of these types of issues, and that having tests would be great. I think
you might be creating a new s
[
https://issues.apache.org/jira/browse/SOLR-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416628#comment-17416628
]
Jonathan J Senchyna commented on SOLR-15626:
It appears the {{config-edit}} p
[
https://issues.apache.org/jira/browse/SOLR-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan J Senchyna updated SOLR-15626:
---
Affects Version/s: (was: 8.9)
(was: 8.7)
[
https://issues.apache.org/jira/browse/SOLR-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan J Senchyna updated SOLR-15626:
---
Affects Version/s: 8.0
8.1
8.2
[
https://issues.apache.org/jira/browse/SOLR-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan J Senchyna updated SOLR-15626:
---
Affects Version/s: 6.6
7.0
7.1
[
https://issues.apache.org/jira/browse/SOLR-15626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan J Senchyna updated SOLR-15626:
---
Affects Version/s: (was: 8.8.2)
8.8
> config-read permissi
TheSench opened a new pull request #296:
URL: https://github.com/apache/solr/pull/296
https://issues.apache.org/jira/browse/SOLR-15626
# Description
The `config-read` permission was not including the `null` collection,
preventing it from being matched on endpoints like `/amin/
[
https://issues.apache.org/jira/browse/SOLR-15209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416615#comment-17416615
]
Jan Høydahl commented on SOLR-15209:
I like the simplicity of AB's proposal. Perhaps
35 matches
Mail list logo
