[ https://issues.apache.org/jira/browse/SOLR-15209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416811#comment-17416811 ]
Ilan Ginzburg commented on SOLR-15209: -------------------------------------- How about your proposal [I rephrased in the dev list|https://www.mail-archive.com/dev@solr.apache.org/msg00223.html] (based on your [slack post|https://the-asf.slack.com/archives/CEKUCUNE9/p1619692977151000]). Copying it here: * Add support for a new {{solr.xml}} config called something like {{forceDefaultLegacyPlacementStrategy}} * Do not add anything in {{solr.xml}} At runtime: * If a placement plugin is explicitly configured (existing plugin config in ZK), use it, * If {{forceDefaultLegacyPlacementStrategy}} is defined in solr.xml, use {{LEGACY}} * (else) If {{forceDefaultLegacyPlacementStrategy}} is not defined in {{solr.xml}}, use {{AffinityPlacementFactory}} Both [~ab] and I said we like this proposal back then, but we didn't conclude anything. That's the approach I like the most. > Make the AffinityPlacementFactory the default placement plugin > -------------------------------------------------------------- > > Key: SOLR-15209 > URL: https://issues.apache.org/jira/browse/SOLR-15209 > Project: Solr > Issue Type: Improvement > Reporter: Andrzej Bialecki > Assignee: Ilan Ginzburg > Priority: Major > > Currently there's a lot of code in {{Assign}} dealing with the fact that we > still support the old "legacy" replica assignment as well as the new > plugin-based placement strategies. > Furthermore, the "legacy" assignment is now the default even though it's > neither robust nor optimal, except in the very simple and small clusters. > Also, providing another plugin-based placement as the default impl. runs into > a small complication - in the absence of any plugin config the code reverts > to the "legacy". > In order to promote the adoption of the new plugin-based placements we should > make the {{AffinityPlacementFactory}} the new default placement strategy, > selected when the explicit configuration is missing (and then create it as a > default configuration in {{PlacementPluginFactoryLoader}}). > I propose to re-package the "legacy" strategy as a {{PlacementPluginFactory}} > so that it can be configured in the same way as other placement plugins. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org