[
https://issues.apache.org/jira/browse/SOLR-15209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17416763#comment-17416763
]
Ilan Ginzburg commented on SOLR-15209:
--------------------------------------
I'm not so keen on mixing environment variables here (in a relatively complex
way TBH) and silently writing back configurations.
To build on AB's suggestion, what about make Affinity placement the default
config in the absence of any configuration in ZK (will be used out of the box).
Use a special "well known" class name to tell the system that the legacy
placement strategy is to be used, without actually packaging the legacy
placement into a placement plugin (i.e. only change the code dealing with
reading the configuration, without changing any of the existing code deciding
the placement).
> Make the AffinityPlacementFactory the default placement plugin
> --------------------------------------------------------------
>
> Key: SOLR-15209
> URL: https://issues.apache.org/jira/browse/SOLR-15209
> Project: Solr
> Issue Type: Improvement
> Reporter: Andrzej Bialecki
> Assignee: Ilan Ginzburg
> Priority: Major
>
> Currently there's a lot of code in {{Assign}} dealing with the fact that we
> still support the old "legacy" replica assignment as well as the new
> plugin-based placement strategies.
> Furthermore, the "legacy" assignment is now the default even though it's
> neither robust nor optimal, except in the very simple and small clusters.
> Also, providing another plugin-based placement as the default impl. runs into
> a small complication - in the absence of any plugin config the code reverts
> to the "legacy".
> In order to promote the adoption of the new plugin-based placements we should
> make the {{AffinityPlacementFactory}} the new default placement strategy,
> selected when the explicit configuration is missing (and then create it as a
> default configuration in {{PlacementPluginFactoryLoader}}).
> I propose to re-package the "legacy" strategy as a {{PlacementPluginFactory}}
> so that it can be configured in the same way as other placement plugins.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
