[jira] [Commented] (SOLR-15560) Optimize JavaBinCodec encode/decode performance.

2021-09-01 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408581#comment-17408581 ] Mark Robert Miller commented on SOLR-15560: --- I’m about done here. One small thi

[jira] [Commented] (SOLR-15614) versions.lock is not including all jars in all configurations - ex: server.libExt

2021-09-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408569#comment-17408569 ] Dawid Weiss commented on SOLR-15614: I don't think we need to have everything, everyw

[jira] [Updated] (SOLR-15615) SolrCloud MLT does not work with Time Routed Alias (TRA)

2021-09-01 Thread Nahian-Al Hasan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nahian-Al Hasan updated SOLR-15615: --- Description: Only the MLT Query Parser works in SolrCloud, otherwise the results returned ar

[jira] [Created] (SOLR-15615) SolrCloud MLT does not work with Time Routed Alias (TRA)

2021-09-01 Thread Nahian-Al Hasan (Jira)
Nahian-Al Hasan created SOLR-15615: -- Summary: SolrCloud MLT does not work with Time Routed Alias (TRA) Key: SOLR-15615 URL: https://issues.apache.org/jira/browse/SOLR-15615 Project: Solr Iss

[GitHub] [solr] bitnahian commented on pull request #202: SOLR-15376 Adding setMaxFutureMs with Long type Overload method

2021-09-01 Thread GitBox
bitnahian commented on pull request #202: URL: https://github.com/apache/solr/pull/202#issuecomment-911154201 Hi @cpoerschke, I've completed the TO-DOs suggested in your commit. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [solr] dsmiley commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

2021-09-01 Thread GitBox
dsmiley commented on pull request #281: URL: https://github.com/apache/solr/pull/281#issuecomment-910937837 ah; of course. I didn't notice it in the IntelliJ PR view but I see it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (SOLR-15614) versions.lock is not including all jars in all configurations - ex: server.libExt

2021-09-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408423#comment-17408423 ] Chris M. Hostetter commented on SOLR-15614: --- I should point out: we know that t

[jira] [Updated] (SOLR-15610) Support json formatted logging via conf: add log4j-layout-template-json to 'server'

2021-09-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15610: -- Attachment: SOLR-15610.patch Status: Open (was: Open) Thanks for the eyeballs

[jira] [Created] (SOLR-15614) versions.lock is not including all jars in all configurations - ex: server.libExt

2021-09-01 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-15614: - Summary: versions.lock is not including all jars in all configurations - ex: server.libExt Key: SOLR-15614 URL: https://issues.apache.org/jira/browse/SOLR-15614

[jira] [Commented] (SOLR-14457) SolrClient leaks connections on compressed responses if the response is malformed

2021-09-01 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408395#comment-17408395 ] Houston Putman commented on SOLR-14457: --- [~samuelgmartinez] & [~roger.lehmann] I ha

[GitHub] [solr] HoustonPutman opened a new pull request #283: SOLR-14457: Fix closing of malformed GZIPInputStream

2021-09-01 Thread GitBox
HoustonPutman opened a new pull request #283: URL: https://github.com/apache/solr/pull/283 https://issues.apache.org/jira/browse/SOLR-14457 Cleaned up the way that `GZIPInputStream` objects are created, since I think the current manner doesn't work when `GzipDecompressingEntity.getCo

[jira] [Commented] (SOLR-15603) Activate Gradle build cache

2021-09-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408391#comment-17408391 ] Dawid Weiss commented on SOLR-15603: I've commented out the cache option by default b

[GitHub] [solr-operator] thelabdude merged pull request #312: Configuration options to support an additional client TLS cert in addition to the server certificate

2021-09-01 Thread GitBox
thelabdude merged pull request #312: URL: https://github.com/apache/solr-operator/pull/312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [solr-operator] thelabdude closed issue #300: Config should allow using a separate client cert for mTLS

2021-09-01 Thread GitBox
thelabdude closed issue #300: URL: https://github.com/apache/solr-operator/issues/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[jira] [Updated] (SOLR-10999) Support "Accept-Encoding" header to enable response gzip compression

2021-09-01 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-10999: -- Fix Version/s: (was: 7.3) (was: 8.0) > Support "Accept-Encoding" hea

[GitHub] [solr] HoustonPutman commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

2021-09-01 Thread GitBox
HoustonPutman commented on pull request #281: URL: https://github.com/apache/solr/pull/281#issuecomment-910714340 > Question: where is the Jetty gzip module defined? I expected to see a file or dir named similarly. Well it's defined, I believe, in the `solr/server/modules/gzip.mod` f

[GitHub] [solr] msporleder commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

2021-09-01 Thread GitBox
msporleder commented on pull request #281: URL: https://github.com/apache/solr/pull/281#issuecomment-910688594 thank you for reviving this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [solr] alextu commented on pull request #277: SOLR-15603: Activate Gradle build cache

2021-09-01 Thread GitBox
alextu commented on pull request #277: URL: https://github.com/apache/solr/pull/277#issuecomment-910680589 @dweiss ok it's pushed, it should be fine now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (SOLR-15613) Address error-prone URLEqualsHashCode warning

2021-09-01 Thread Mike Drob (Jira)
Mike Drob created SOLR-15613: Summary: Address error-prone URLEqualsHashCode warning Key: SOLR-15613 URL: https://issues.apache.org/jira/browse/SOLR-15613 Project: Solr Issue Type: Task Sec

[jira] [Commented] (SOLR-15610) Support json formatted logging via conf: add log4j-layout-template-json to 'server'

2021-09-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408353#comment-17408353 ] Dawid Weiss commented on SOLR-15610: I did take a quick look. Part of the problem is

[jira] [Commented] (SOLR-15610) Support json formatted logging via conf: add log4j-layout-template-json to 'server'

2021-09-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408351#comment-17408351 ] Dawid Weiss commented on SOLR-15610: I'm not sure. Looks like this configuration is n

[GitHub] [solr] dsmiley commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

2021-09-01 Thread GitBox
dsmiley commented on pull request #281: URL: https://github.com/apache/solr/pull/281#issuecomment-910657354 +1 LGTM though I rely on your testing as I did none. Question: where is the Jetty gzip module defined? I expected to see a file or dir named similarly. -- This is an automated

[jira] [Updated] (SOLR-15610) Support json formatted logging via conf: add log4j-layout-template-json to 'server'

2021-09-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15610: -- Attachment: SOLR-15610.patch Status: Open (was: Open) Here's a patch with the

[jira] [Assigned] (SOLR-12848) SolrJ does not use HTTP proxy anymore

2021-09-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-12848: --- Assignee: David Smiley > SolrJ does not use HTTP proxy anymore > ---

[jira] [Commented] (SOLR-11752) add gzip to jetty

2021-09-01 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408328#comment-17408328 ] Houston Putman commented on SOLR-11752: --- Hello everyone, bringing this old ticket u

[jira] [Assigned] (SOLR-11752) add gzip to jetty

2021-09-01 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman reassigned SOLR-11752: - Assignee: Houston Putman > add gzip to jetty > - > > Key

[GitHub] [solr] HoustonPutman commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

2021-09-01 Thread GitBox
HoustonPutman commented on pull request #281: URL: https://github.com/apache/solr/pull/281#issuecomment-910537372 > Would this let me post a gzipped CSV file directly to Solr? unzipping a giant CSV, then sending it over, was always painful. I don't believe this affects data being sen

[GitHub] [solr] epugh commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

2021-09-01 Thread GitBox
epugh commented on pull request #281: URL: https://github.com/apache/solr/pull/281#issuecomment-910502435 Would this let me post a gzipped CSV file directly to Solr? unzipping a giant CSV, then sending it over, was always painful. -- This is an automated message from the Apa

[jira] [Resolved] (SOLR-15609) Upgrade log4j -> 2.14.1

2021-09-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-15609. --- Fix Version/s: 8.10 main (9.0) Resolution: Fixed > Upgrade

[jira] [Commented] (SOLR-15609) Upgrade log4j -> 2.14.1

2021-09-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408287#comment-17408287 ] ASF subversion and git services commented on SOLR-15609: Commit 8

[jira] [Commented] (SOLR-15609) Upgrade log4j -> 2.14.1

2021-09-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408285#comment-17408285 ] ASF subversion and git services commented on SOLR-15609: Commit a

[jira] [Updated] (SOLR-15609) Upgrade log4j -> 2.14.1

2021-09-01 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15609: -- Attachment: SOLR-15609.8x.patch Status: Open (was: Open) reviewing it again, s

[GitHub] [solr] HoustonPutman opened a new pull request #282: SOLR-15612: Remove unecessary https8 jetty module

2021-09-01 Thread GitBox
HoustonPutman opened a new pull request #282: URL: https://github.com/apache/solr/pull/282 https://issues.apache.org/jira/browse/SOLR-15612 https8 is not needed in 9.0, since Java 11 is the minimum required Java version. -- This is an automated message from the Apache Git Service.

[GitHub] [solr] HoustonPutman commented on pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

2021-09-01 Thread GitBox
HoustonPutman commented on pull request #281: URL: https://github.com/apache/solr/pull/281#issuecomment-910473594 Oh the only jetty-gzip setting I changed was defaulting the allowed methods to `GET,POST`, since POST is a popular way of querying with large URL params. -- This is an automa

[GitHub] [solr] HoustonPutman opened a new pull request #281: SOLR-11752: Support Accept-Encoding header to enable response gzip co…

2021-09-01 Thread GitBox
HoustonPutman opened a new pull request #281: URL: https://github.com/apache/solr/pull/281 https://issues.apache.org/jira/browse/SOLR-11752 Built off the patch found in the above JIRA. This is enabled by default but can be removed by setting `SOLR_GZIP_ENABLED=false` -- Thi

[jira] [Created] (SOLR-15612) Remove https8 jetty module

2021-09-01 Thread Houston Putman (Jira)
Houston Putman created SOLR-15612: - Summary: Remove https8 jetty module Key: SOLR-15612 URL: https://issues.apache.org/jira/browse/SOLR-15612 Project: Solr Issue Type: Task Security Lev

[GitHub] [solr-operator] thelabdude commented on a change in pull request #312: Configuration options to support an additional client TLS cert in addition to the server certificate

2021-09-01 Thread GitBox
thelabdude commented on a change in pull request #312: URL: https://github.com/apache/solr-operator/pull/312#discussion_r700369485 ## File path: controllers/solrprometheusexporter_controller.go ## @@ -434,53 +458,133 @@ func (r *SolrPrometheusExporterReconciler) buildSecretWat

[GitHub] [solr-operator] thelabdude closed issue #317: Solr operator pod should hot reload the TLS client cert used to send requests to HTTPs enabled Solr pods

2021-09-01 Thread GitBox
thelabdude closed issue #317: URL: https://github.com/apache/solr-operator/issues/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsub

[GitHub] [solr-operator] thelabdude merged pull request #318: Option to watch for updates to the mTLS cert used by the operator to call Solr pods

2021-09-01 Thread GitBox
thelabdude merged pull request #318: URL: https://github.com/apache/solr-operator/pull/318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [solr] khitrin opened a new pull request #280: SOLR-15611: Fix ignored phrase slop after nested query parsing

2021-09-01 Thread GitBox
khitrin opened a new pull request #280: URL: https://github.com/apache/solr/pull/280 https://issues.apache.org/jira/browse/SOLR-15611 # Description Solr query parser is dropping phrase slops after any nested queries parsed in same query because `subQParser` not cleared after magic

[jira] [Created] (SOLR-15611) Phrase slop ignored after any nested parser in same query

2021-09-01 Thread Nikolay Khitrin (Jira)
Nikolay Khitrin created SOLR-15611: -- Summary: Phrase slop ignored after any nested parser in same query Key: SOLR-15611 URL: https://issues.apache.org/jira/browse/SOLR-15611 Project: Solr Is

[GitHub] [solr] dweiss commented on pull request #277: SOLR-15603: Activate Gradle build cache

2021-09-01 Thread GitBox
dweiss commented on pull request #277: URL: https://github.com/apache/solr/pull/277#issuecomment-910288119 Sure, go ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [solr] alextu commented on pull request #277: SOLR-15603: Activate Gradle build cache

2021-09-01 Thread GitBox
alextu commented on pull request #277: URL: https://github.com/apache/solr/pull/277#issuecomment-910246204 Ho right, I missed it, after rebasing I've managed to fix those issues locally, is it ok for you if I force push my changes with a clean commit ? -- This is an automated message fro

[GitHub] [solr] dweiss commented on pull request #277: SOLR-15603: Activate Gradle build cache

2021-09-01 Thread GitBox
dweiss commented on pull request #277: URL: https://github.com/apache/solr/pull/277#issuecomment-910244185 Hey, no rush. I don't think you need to rebase - just pull the changes? I pushed the cleanups directly to your branch (PRs allow for this). -- This is an automated message from the

[GitHub] [solr] epugh commented on pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-09-01 Thread GitBox
epugh commented on pull request #264: URL: https://github.com/apache/solr/pull/264#issuecomment-910236316 Thank you everyone who reviewed code. I have spent the past few days trying to figure out why tests are failing (that shouldn't have!!), and started a NEW branch, where all of the

[GitHub] [solr] epugh opened a new pull request #279: SOLR-10887: Append .xml to managed-schema file VERSION 2

2021-09-01 Thread GitBox
epugh opened a new pull request #279: URL: https://github.com/apache/solr/pull/279 ### THIS IS A DUPLICATE OF https://github.com/apache/solr/pull/264 BECAUSE I AM GETTING TEST FAILURES AND CAN'T FIGURE IT OUT SO I STARTED OVER. SIGH. https://issues.apache.org/jira/browse/SOLR-10887

[jira] [Commented] (SOLR-15607) Invert indent switch behaviour for clarity

2021-09-01 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408124#comment-17408124 ] David Eric Pugh commented on SOLR-15607: That is the goal, indent is on. > Inver

[GitHub] [solr] alextu commented on pull request #277: SOLR-15603: Activate Gradle build cache

2021-09-01 Thread GitBox
alextu commented on pull request #277: URL: https://github.com/apache/solr/pull/277#issuecomment-910115829 Hi Dawid, I will rebase locally and investigate (today hopefuly) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [solr] dweiss commented on pull request #277: SOLR-15603: Activate Gradle build cache

2021-09-01 Thread GitBox
dweiss commented on pull request #277: URL: https://github.com/apache/solr/pull/277#issuecomment-910086421 Hi Alexis. I've rebased your patch on top of main (gradle 7.2) and cleaned up some minor noise here and there. The build currently fails though - not sure which normalization strategy

[GitHub] [solr] janhoy merged pull request #24: SOLR-15111 Use JDK8 Base64 instead of own implementation

2021-09-01 Thread GitBox
janhoy merged pull request #24: URL: https://github.com/apache/solr/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@sol

[GitHub] [solr-operator] thelabdude commented on a change in pull request #312: Configuration options to support an additional client TLS cert in addition to the server certificate

2021-09-01 Thread GitBox
thelabdude commented on a change in pull request #312: URL: https://github.com/apache/solr-operator/pull/312#discussion_r699689067 ## File path: controllers/solrcloud_controller.go ## @@ -960,80 +950,160 @@ func (r *SolrCloudReconciler) indexAndWatchForTLSSecret(mgr ctrl.Manag

[GitHub] [solr-site] janhoy merged pull request #38: SOLR-15600 Move powered by to sub page, skip logos (merge to prod)

2021-09-01 Thread GitBox
janhoy merged pull request #38: URL: https://github.com/apache/solr-site/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [solr-site] janhoy merged pull request #36: SOLR-15600 Move powered by to sub page, skip logos

2021-09-01 Thread GitBox
janhoy merged pull request #36: URL: https://github.com/apache/solr-site/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #318: Option to watch for updates to the mTLS cert used by the operator to call Solr pods

2021-09-01 Thread GitBox
HoustonPutman commented on a change in pull request #318: URL: https://github.com/apache/solr-operator/pull/318#discussion_r699685355 ## File path: helm/solr-operator/templates/deployment.yaml ## @@ -64,6 +64,10 @@ spec: {{- if .Values.mTLS.insecureSkipVerify }}

[GitHub] [solr-operator] thelabdude commented on pull request #318: Option to watch for updates to the mTLS cert used by the operator to call Solr pods

2021-09-01 Thread GitBox
thelabdude commented on pull request #318: URL: https://github.com/apache/solr-operator/pull/318#issuecomment-909688647 > Would be good to add a changelog entry as well. > > Awesome work with the fsnotify stuff. It looks like that is a BSD3 licensed library, so I think you need to in

[GitHub] [solr] markrmiller commented on pull request #254: Solr 15581

2021-09-01 Thread GitBox
markrmiller commented on pull request #254: URL: https://github.com/apache/solr/pull/254#issuecomment-909438956 @madrob updated pr, not merged up to master this time yet as the last time that bit me. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #312: Configuration options to support an additional client TLS cert in addition to the server certificate

2021-09-01 Thread GitBox
HoustonPutman commented on a change in pull request #312: URL: https://github.com/apache/solr-operator/pull/312#discussion_r699669943 ## File path: controllers/solrcloud_controller.go ## @@ -960,80 +950,160 @@ func (r *SolrCloudReconciler) indexAndWatchForTLSSecret(mgr ctrl.Ma

[GitHub] [solr] anshumg commented on pull request #225: SOLR-15538 Update Lucene Preview Release dependency

2021-09-01 Thread GitBox
anshumg commented on pull request #225: URL: https://github.com/apache/solr/pull/225#issuecomment-909863732 @markrmiller - Do you plan to update this to prerelease8 (considering that's available)? Assuming that doesn't break anything else, and this patch works, might be worth to me

[GitHub] [solr] madrob commented on a change in pull request #275: SOLR-15602: upgrade to gradle 7.2, clean up gradle code a bit.

2021-09-01 Thread GitBox
madrob commented on a change in pull request #275: URL: https://github.com/apache/solr/pull/275#discussion_r699392924 ## File path: build.gradle ## @@ -20,15 +20,15 @@ import java.time.format.DateTimeFormatter plugins { id "base" - id "com.palantir.consistent-versions" v

[GitHub] [solr] dweiss merged pull request #275: SOLR-15602: upgrade to gradle 7.2, clean up gradle code a bit.

2021-09-01 Thread GitBox
dweiss merged pull request #275: URL: https://github.com/apache/solr/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] dweiss commented on a change in pull request #277: SOLR-15603: Activate Gradle build cache

2021-09-01 Thread GitBox
dweiss commented on a change in pull request #277: URL: https://github.com/apache/solr/pull/277#discussion_r699189769 ## File path: gradle/generate-defaults.gradle ## @@ -42,6 +42,7 @@ configure(rootProject) { "systemProp.file.encoding=UTF-8",

[GitHub] [solr] dweiss commented on a change in pull request #275: SOLR-15602: upgrade to gradle 7.2, clean up gradle code a bit.

2021-09-01 Thread GitBox
dweiss commented on a change in pull request #275: URL: https://github.com/apache/solr/pull/275#discussion_r699602425 ## File path: build.gradle ## @@ -183,6 +184,7 @@ apply from: file('gradle/hacks/solr.findbugs.gradle') apply from: file('gradle/hacks/wipe-temp.gradle') appl

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #254: Solr 15581

2021-09-01 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #254: URL: https://github.com/apache/solr/pull/254#discussion_r699665335 ## File path: solr/benchmark/src/java/org/apache/solr/bench/BaseBenchState.java ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [solr] madrob closed pull request #273: SOLR-13209: Fix NullPointerException error resulting from parsing null query

2021-09-01 Thread GitBox
madrob closed pull request #273: URL: https://github.com/apache/solr/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr] cpoerschke commented on pull request #276: SOLR-15606: rename (deprecated) Insanity.java to NumericHidingLeafReader.java

2021-09-01 Thread GitBox
cpoerschke commented on pull request #276: URL: https://github.com/apache/solr/pull/276#issuecomment-909377241 > Does this need a CHANGES entry? Good question. Yeah, might as well have one, no harm in having one. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [solr-operator] thelabdude commented on a change in pull request #318: Option to watch for updates to the mTLS cert used by the operator to call Solr pods

2021-09-01 Thread GitBox
thelabdude commented on a change in pull request #318: URL: https://github.com/apache/solr-operator/pull/318#discussion_r699702285 ## File path: helm/solr-operator/templates/deployment.yaml ## @@ -64,6 +64,10 @@ spec: {{- if .Values.mTLS.insecureSkipVerify }}

[GitHub] [solr] alextu commented on a change in pull request #277: SOLR-15603: Activate Gradle build cache

2021-09-01 Thread GitBox
alextu commented on a change in pull request #277: URL: https://github.com/apache/solr/pull/277#discussion_r699108383 ## File path: gradle/generate-defaults.gradle ## @@ -42,6 +42,7 @@ configure(rootProject) { "systemProp.file.encoding=UTF-8",

[GitHub] [solr] dweiss commented on pull request #277: SOLR-15603: Activate Gradle build cache

2021-09-01 Thread GitBox
dweiss commented on pull request #277: URL: https://github.com/apache/solr/pull/277#issuecomment-910086421 Hi Alexis. I've rebased your patch on top of main (gradle 7.2) and cleaned up some minor noise here and there. The build currently fails though - not sure which normalization strategy

[jira] [Updated] (SOLR-15605) Duplicate jars copied in prometheus-exporter

2021-09-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-15605: --- Parent: (was: SOLR-15602) Issue Type: Task (was: Sub-task) > Duplicate jars copied in pr

[jira] [Updated] (SOLR-15605) Duplicate jars copied in prometheus-exporter

2021-09-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-15605: --- Summary: Duplicate jars copied in prometheus-exporter (was: duplicate jar copied in prometheus-expor

[jira] [Updated] (SOLR-15605) Duplicate jars copied in prometheus-exporter

2021-09-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated SOLR-15605: --- Description: This fails by default with gradle 7.2. I added a workaround so that it emits 'warn' but

[jira] [Resolved] (SOLR-15602) Upgrade gradle to 7.2

2021-09-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved SOLR-15602. Fix Version/s: main (9.0) Resolution: Fixed > Upgrade gradle to 7.2 > -

[jira] [Commented] (SOLR-15602) Upgrade gradle to 7.2

2021-09-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407970#comment-17407970 ] ASF subversion and git services commented on SOLR-15602: Commit 6

[GitHub] [solr] dweiss merged pull request #275: SOLR-15602: upgrade to gradle 7.2, clean up gradle code a bit.

2021-09-01 Thread GitBox
dweiss merged pull request #275: URL: https://github.com/apache/solr/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[jira] [Commented] (SOLR-15602) Upgrade gradle to 7.2

2021-09-01 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407940#comment-17407940 ] Dawid Weiss commented on SOLR-15602: Thanks Chris. This is exactly what I asked for -