[
https://issues.apache.org/jira/browse/SOLR-15454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17359049#comment-17359049
]
Dawid Weiss commented on SOLR-15454:
I did express my opinion that it's no harm to le
[
https://issues.apache.org/jira/browse/SOLR-7849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358999#comment-17358999
]
David Smiley commented on SOLR-7849:
Thanks; that's very helpful!
I guess "isSolrServe
[
https://issues.apache.org/jira/browse/SOLR-7849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358958#comment-17358958
]
Noble Paul commented on SOLR-7849:
--
{quote}Okay. Is this ultimately to distinguish Client
[
https://issues.apache.org/jira/browse/SOLR-15454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358893#comment-17358893
]
David Smiley commented on SOLR-15454:
-
[~dweiss] Didn't you object to wiping this? I
Timothy Potter created SOLR-15456:
-
Summary: Solr SQL metrics for field with custom field type
defaults to String instead of using the correct numeric type
Key: SOLR-15456
URL: https://issues.apache.org/jira/brows
dsmiley commented on a change in pull request #165:
URL: https://github.com/apache/solr/pull/165#discussion_r646971932
##
File path:
solr/core/src/java/org/apache/solr/util/plugin/NamedListInitializedPlugin.java
##
@@ -25,5 +25,10 @@
* @since solr 1.3
*/
public interface
dsmiley commented on a change in pull request #165:
URL: https://github.com/apache/solr/pull/165#discussion_r646970650
##
File path: solr/core/src/java/org/apache/solr/api/ApiBag.java
##
@@ -301,19 +301,18 @@ public static SpecProvider constructSpec(PluginInfo info)
{
Obj
[
https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358883#comment-17358883
]
David Smiley commented on SOLR-15146:
-
Thanks ![~jbernste]. Lets take this further t
[
https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358882#comment-17358882
]
Joel Bernstein edited comment on SOLR-15146 at 6/7/21, 9:47 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358882#comment-17358882
]
Joel Bernstein commented on SOLR-15146:
---
It does resolve the failing test. The old
[
https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358877#comment-17358877
]
Joel Bernstein edited comment on SOLR-15146 at 6/7/21, 9:40 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358872#comment-17358872
]
Joel Bernstein edited comment on SOLR-15146 at 6/7/21, 9:37 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358877#comment-17358877
]
Joel Bernstein commented on SOLR-15146:
---
[~dsmiley], I believe the issue is that th
[
https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358872#comment-17358872
]
Joel Bernstein edited comment on SOLR-15146 at 6/7/21, 9:01 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358872#comment-17358872
]
Joel Bernstein commented on SOLR-15146:
---
After a deeper dive I don't think it's the
madrob commented on a change in pull request #165:
URL: https://github.com/apache/solr/pull/165#discussion_r646926881
##
File path:
solr/core/src/java/org/apache/solr/util/plugin/NamedListInitializedPlugin.java
##
@@ -25,5 +25,10 @@
* @since solr 1.3
*/
public interface N
madrob commented on a change in pull request #165:
URL: https://github.com/apache/solr/pull/165#discussion_r64692
##
File path: solr/core/src/java/org/apache/solr/api/ApiBag.java
##
@@ -301,19 +301,18 @@ public static SpecProvider constructSpec(PluginInfo info)
{
Obje
cpoerschke commented on a change in pull request #163:
URL: https://github.com/apache/solr/pull/163#discussion_r646921829
##
File path: .git-blame-ignore-revs
##
@@ -1,6 +1,2 @@
-# LUCENE-9570 [google java formatter applied]
-6faa4f98e04817bf27d02d96332904a29fb7db69
-2d6ad2fee6
cpoerschke commented on a change in pull request #163:
URL: https://github.com/apache/solr/pull/163#discussion_r646921829
##
File path: .git-blame-ignore-revs
##
@@ -1,6 +1,2 @@
-# LUCENE-9570 [google java formatter applied]
-6faa4f98e04817bf27d02d96332904a29fb7db69
-2d6ad2fee6
[
https://issues.apache.org/jira/browse/SOLR-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358852#comment-17358852
]
Christine Poerschke commented on SOLR-14920:
Hi [~dweiss]. [~dsmiley] had sug
cpoerschke commented on a change in pull request #162:
URL: https://github.com/apache/solr/pull/162#discussion_r646906653
##
File path:
solr/contrib/jaegertracer-configurator/src/test/org/apache/solr/jaeger/TestJaegerConfigurator.java
##
@@ -53,26 +51,23 @@ public void doBefor
cpoerschke commented on a change in pull request #162:
URL: https://github.com/apache/solr/pull/162#discussion_r646906653
##
File path:
solr/contrib/jaegertracer-configurator/src/test/org/apache/solr/jaeger/TestJaegerConfigurator.java
##
@@ -53,26 +51,23 @@ public void doBefor
[
https://issues.apache.org/jira/browse/SOLR-15277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter resolved SOLR-15277.
---
Fix Version/s: main (9.0)
Resolution: Fixed
> Schema Designer in Admin UI
> --
[
https://issues.apache.org/jira/browse/SOLR-15277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358798#comment-17358798
]
ASF subversion and git services commented on SOLR-15277:
Commit a
thelabdude merged pull request #42:
URL: https://github.com/apache/solr/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please con
HoustonPutman edited a comment on pull request #42:
URL: https://github.com/apache/solr/pull/42#issuecomment-845376159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For q
[
https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358792#comment-17358792
]
Joel Bernstein commented on SOLR-15146:
---
I looked at the test. Here is what I found
[
https://issues.apache.org/jira/browse/SOLR-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358783#comment-17358783
]
Michael Gibney commented on SOLR-15455:
---
The attached patch, [^solr-lucene-snapshot
[
https://issues.apache.org/jira/browse/SOLR-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney updated SOLR-15455:
--
Attachment: solr-lucene-snapshot-build.patch
> Facilitate joint Lucene/Solr local development w
madrob commented on a change in pull request #162:
URL: https://github.com/apache/solr/pull/162#discussion_r646774159
##
File path:
solr/contrib/jaegertracer-configurator/src/test/org/apache/solr/jaeger/TestJaegerConfigurator.java
##
@@ -37,8 +36,7 @@
public class TestJaege
Michael Gibney created SOLR-15455:
-
Summary: Facilitate joint Lucene/Solr local development workflow
Key: SOLR-15455
URL: https://issues.apache.org/jira/browse/SOLR-15455
Project: Solr
Issue
alessandrobenedetti commented on pull request #158:
URL: https://github.com/apache/solr/pull/158#issuecomment-856047544
@dsmiley I see that changes are still requested, can you check that?
I would like to progress with the merge, I doubt we get any other feedback
here.
--
This is an a
[
https://issues.apache.org/jira/browse/SOLR-15089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358652#comment-17358652
]
Jason Gerlowski commented on SOLR-15089:
Hey [~athrog] - did you get a chance to
madrob commented on a change in pull request #165:
URL: https://github.com/apache/solr/pull/165#discussion_r646651200
##
File path:
solr/core/src/test/org/apache/solr/spelling/FileBasedSpellCheckerTest.java
##
@@ -143,19 +137,16 @@ public void testFieldType() throws Exception
madrob commented on a change in pull request #165:
URL: https://github.com/apache/solr/pull/165#discussion_r646650657
##
File path:
solr/core/src/java/org/apache/solr/util/plugin/NamedListInitializedPlugin.java
##
@@ -25,5 +25,10 @@
* @since solr 1.3
*/
public interface N
madrob commented on a change in pull request #165:
URL: https://github.com/apache/solr/pull/165#discussion_r646649789
##
File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java
##
@@ -204,9 +204,9 @@ public final ConfigSet loadConfigSet(CoreDescriptor dcore) {
madrob commented on a change in pull request #165:
URL: https://github.com/apache/solr/pull/165#discussion_r646648410
##
File path: solr/core/src/java/org/apache/solr/api/ApiBag.java
##
@@ -301,19 +301,18 @@ public static SpecProvider constructSpec(PluginInfo info)
{
Obje
[
https://issues.apache.org/jira/browse/SOLR-15146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358560#comment-17358560
]
Joel Bernstein commented on SOLR-15146:
---
I'll take a look at StreamDecoratorTest.te
[
https://issues.apache.org/jira/browse/SOLR-15432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17358556#comment-17358556
]
Jan Høydahl commented on SOLR-15432:
I've taken care of 1) today:
{code:java}
13:09:4
janhoy commented on a change in pull request #139:
URL: https://github.com/apache/solr/pull/139#discussion_r646401624
##
File path:
solr/core/src/test/org/apache/solr/security/JWTAuthPluginIntegrationTest.java
##
@@ -127,13 +135,40 @@ public void tearDown() throws Exception {
colvinco commented on pull request #131:
URL: https://github.com/apache/solr/pull/131#issuecomment-855767702
Hi yes, sorry I hadn't checked on main. I see the same thing on main on
Windows
```
o.a.s.c.SolrCore null:java.security.AccessControlException: Access denied
("java.lang.Runti
janhoy commented on a change in pull request #139:
URL: https://github.com/apache/solr/pull/139#discussion_r646402044
##
File path: solr/core/build.gradle
##
@@ -149,5 +149,12 @@ dependencies {
testImplementation('org.mockito:mockito-core', {
exclude group: "net.bytebud
janhoy commented on a change in pull request #139:
URL: https://github.com/apache/solr/pull/139#discussion_r646401624
##
File path:
solr/core/src/test/org/apache/solr/security/JWTAuthPluginIntegrationTest.java
##
@@ -127,13 +135,40 @@ public void tearDown() throws Exception {
janhoy commented on a change in pull request #139:
URL: https://github.com/apache/solr/pull/139#discussion_r646390578
##
File path: solr/core/src/java/org/apache/solr/security/JWTAuthPlugin.java
##
@@ -155,8 +175,38 @@ public void init(Map pluginConfig) {
requiredScopes
janhoy commented on a change in pull request #139:
URL: https://github.com/apache/solr/pull/139#discussion_r646390022
##
File path: solr/solr-ref-guide/src/jwt-authentication-plugin.adoc
##
@@ -158,12 +161,18 @@ Let's comment on this config:
<11> Configure the issuer id. Will
janhoy commented on a change in pull request #139:
URL: https://github.com/apache/solr/pull/139#discussion_r646390022
##
File path: solr/solr-ref-guide/src/jwt-authentication-plugin.adoc
##
@@ -158,12 +161,18 @@ Let's comment on this config:
<11> Configure the issuer id. Will
janhoy commented on a change in pull request #139:
URL: https://github.com/apache/solr/pull/139#discussion_r646389781
##
File path:
solr/core/src/java/org/apache/solr/security/JWTVerificationkeyResolver.java
##
@@ -110,7 +112,13 @@ public Key resolveKey(JsonWebSignature jws,
tomglk commented on a change in pull request #151:
URL: https://github.com/apache/solr/pull/151#discussion_r646319677
##
File path:
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java
##
@@ -999,20 +1013,34 @@ protected void mergeIds(ResponseBuilder rb, Sh
48 matches
Mail list logo
