gerlowskija commented on pull request #81:
URL: https://github.com/apache/solr/pull/81#issuecomment-854319415
I've tentatively pushed a fix for the api-overwriting problem I described in
my last comment. The fix I ended up using is as follows:
1. Add a method to PathTrie, `attachVal
[
https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356775#comment-17356775
]
Mark Robert Miller commented on SOLR-7344:
--
-> … low resource detection sledgeham
[
https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356766#comment-17356766
]
Mark Robert Miller commented on SOLR-7344:
--
[~atris] i missed that comment. Takin
[
https://issues.apache.org/jira/browse/SOLR-15311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-15311.
-
Fix Version/s: 8.10
Resolution: Fixed
Thanks everyone, and to Nazerke for working on the P
[
https://issues.apache.org/jira/browse/SOLR-15311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356745#comment-17356745
]
ASF subversion and git services commented on SOLR-15311:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter resolved SOLR-15429.
---
Fix Version/s: main (9.0)
Resolution: Fixed
> Solr implications of LUCENE-8811
[
https://issues.apache.org/jira/browse/SOLR-15429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356736#comment-17356736
]
ASF subversion and git services commented on SOLR-15429:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-15311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356709#comment-17356709
]
ASF subversion and git services commented on SOLR-15311:
Commit 3
dsmiley merged pull request #152:
URL: https://github.com/apache/solr/pull/152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
epugh commented on a change in pull request #91:
URL: https://github.com/apache/solr/pull/91#discussion_r645110145
##
File path: solr/solr-ref-guide/src/schema-api.adoc
##
@@ -844,12 +827,27 @@ If `multiValued` is defined as either true or false (most
likely true), that wil
epugh commented on a change in pull request #91:
URL: https://github.com/apache/solr/pull/91#discussion_r645101097
##
File path: solr/solr-ref-guide/src/schema-api.adoc
##
@@ -112,7 +93,7 @@ curl -X POST -H 'Content-type:application/json'
--data-binary '{
"name":"sell_by
epugh commented on a change in pull request #91:
URL: https://github.com/apache/solr/pull/91#discussion_r645100024
##
File path: solr/solr-ref-guide/src/coreadmin-api.adoc
##
@@ -50,6 +94,45 @@ The `CREATE` action creates a new core and registers it.
If a Solr core with the gi
MarcusSorealheis commented on pull request #42:
URL: https://github.com/apache/solr/pull/42#issuecomment-854136815
Ignore this.. Looking into the client side errors now. First two nits and
SOLR-wide issue persists. New JIRA incoming.
--
This is an automated message from the Apache Git Se
thelabdude commented on pull request #42:
URL: https://github.com/apache/solr/pull/42#issuecomment-854135714
Schema Designer only runs in cloud-mode, from your screenshot, you're
running in standalone. See screenshots of the Schema Designer UI in the JIRA
--
This is an automated message
[
https://issues.apache.org/jira/browse/SOLR-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356689#comment-17356689
]
David Eric Pugh commented on SOLR-15372:
Sigh. I went back and tested this, and
MarcusSorealheis commented on pull request #42:
URL: https://github.com/apache/solr/pull/42#issuecomment-854126530
I just rebuilt from nothing and got the same error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
MarcusSorealheis commented on pull request #42:
URL: https://github.com/apache/solr/pull/42#issuecomment-854122801
> > Schema Designer should not simply throw generic errors that do no help
the user. For instance, when a user tries to create a field that already
exists, there is just an er
MarcusSorealheis commented on pull request #42:
URL: https://github.com/apache/solr/pull/42#issuecomment-854119635
> > there's also a few security exceptions that if thrown in the wrong
corporate org could start problematic conversations running SOLR. Everything is
under scrutiny right now
dsmiley commented on a change in pull request #152:
URL: https://github.com/apache/solr/pull/152#discussion_r645068458
##
File path: solr/CHANGES.txt
##
@@ -312,6 +312,13 @@ Bug Fixes
* SOLR-15334: Return error response when failing auth in PKIAuthPlugin (Mike
Drob)
+
[
https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-7344.
Resolution: Won't Fix
I'm going to resolve as Won't Fix, especially after reading Mark's recent
com
[
https://issues.apache.org/jira/browse/SOLR-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-7683.
Fix Version/s: main (9.0)
Resolution: Fixed
Closing as fixed. I see no trace of the discussi
epugh commented on a change in pull request #91:
URL: https://github.com/apache/solr/pull/91#discussion_r645063187
##
File path: solr/solr-ref-guide/src/coreadmin-api.adoc
##
@@ -50,6 +94,45 @@ The `CREATE` action creates a new core and registers it.
If a Solr core with the gi
thelabdude commented on a change in pull request #42:
URL: https://github.com/apache/solr/pull/42#discussion_r644903516
##
File path: solr/webapp/web/index.html
##
@@ -26,6 +26,7 @@
+
Review comment:
hmmm ... This too seems unrelated to the Sch
thelabdude commented on pull request #42:
URL: https://github.com/apache/solr/pull/42#issuecomment-853964812
> there's also a few security exceptions that if thrown in the wrong
corporate org could start problematic conversations running SOLR. Everything is
under scrutiny right now given t
thelabdude edited a comment on pull request #42:
URL: https://github.com/apache/solr/pull/42#issuecomment-853963136
> Schema Designer should not simply throw generic errors that do no help the
user. For instance, when a user tries to create a field that already exists,
there is just an err
thelabdude commented on pull request #42:
URL: https://github.com/apache/solr/pull/42#issuecomment-853963136
> Schema Designer should not simply throw generic errors that do no help the
user. For instance, when a user tries to create a field that already exists,
there is just an error proc
[
https://issues.apache.org/jira/browse/SOLR-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356513#comment-17356513
]
ASF subversion and git services commented on SOLR-15392:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-15392.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> Improve Tracing operation names and tags
> -
dsmiley merged pull request #115:
URL: https://github.com/apache/solr/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please cont
madrob commented on a change in pull request #160:
URL: https://github.com/apache/solr/pull/160#discussion_r644843888
##
File path: solr/core/src/java/org/apache/solr/core/ConfigOverlay.java
##
@@ -182,16 +181,24 @@ public static boolean isEditableProp(String path, boolean
isX
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356483#comment-17356483
]
Joel Bernstein commented on SOLR-14608:
---
This work is committed, but left open beca
magibney commented on a change in pull request #158:
URL: https://github.com/apache/solr/pull/158#discussion_r644821783
##
File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java
##
@@ -1159,8 +1160,11 @@ protected Query getFieldQuery(String field, List
q
alessandrobenedetti commented on a change in pull request #158:
URL: https://github.com/apache/solr/pull/158#discussion_r644819680
##
File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java
##
@@ -1149,7 +1150,7 @@ protected Query getFieldQuery(String fiel
[
https://issues.apache.org/jira/browse/SOLR-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356454#comment-17356454
]
ASF subversion and git services commented on SOLR-15197:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Eric Pugh resolved SOLR-15372.
Resolution: Workaround
The use of the configSetBaseDir parameter is a workaround.
> When y
magibney commented on a change in pull request #158:
URL: https://github.com/apache/solr/pull/158#discussion_r644814658
##
File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java
##
@@ -1149,7 +1150,7 @@ protected Query getFieldQuery(String field, List
qu
magibney commented on a change in pull request #158:
URL: https://github.com/apache/solr/pull/158#discussion_r644814658
##
File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java
##
@@ -1149,7 +1150,7 @@ protected Query getFieldQuery(String field, List
qu
[
https://issues.apache.org/jira/browse/SOLR-15197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-15197:
--
Attachment: SOLR-15197.patch
> Support temporal graph queries with daily windows
>
dsmiley commented on a change in pull request #115:
URL: https://github.com/apache/solr/pull/115#discussion_r644799910
##
File path: solr/core/src/java/org/apache/solr/api/V2HttpCall.java
##
@@ -360,6 +366,85 @@ protected void execute(SolrQueryResponse rsp) {
SolrCore.post
[
https://issues.apache.org/jira/browse/SOLR-15253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356409#comment-17356409
]
Jan Høydahl commented on SOLR-15253:
I deleted some stale branches today.
Please go t
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356406#comment-17356406
]
Jan Høydahl commented on SOLR-14608:
Hi, what is the status of this JIRA? I see commi
dsmiley commented on pull request #129:
URL: https://github.com/apache/solr/pull/129#issuecomment-853836054
The core of my point is that that Solr *already* has an API to interrogate
the field type to see if it produces one token or more --
{{FieldType.isTokenized}}. SolrQueryParserBase u
noblepaul commented on pull request #115:
URL: https://github.com/apache/solr/pull/115#issuecomment-853833526
LGTM @dsmiley
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
janhoy commented on pull request #158:
URL: https://github.com/apache/solr/pull/158#issuecomment-853833525
The new apache/solr repo only contains main branch, and will eventually
contain branch_9x etc.
To backport to 8.x you will need to port the change over to the
https://github.com/ap
noblepaul commented on a change in pull request #115:
URL: https://github.com/apache/solr/pull/115#discussion_r644752414
##
File path: solr/core/src/java/org/apache/solr/api/V2HttpCall.java
##
@@ -360,6 +366,85 @@ protected void execute(SolrQueryResponse rsp) {
SolrCore.po
ctargett commented on a change in pull request #91:
URL: https://github.com/apache/solr/pull/91#discussion_r644750680
##
File path: solr/solr-ref-guide/src/schema-api.adoc
##
@@ -112,7 +93,7 @@ curl -X POST -H 'Content-type:application/json'
--data-binary '{
"name":"sell
ctargett commented on a change in pull request #91:
URL: https://github.com/apache/solr/pull/91#discussion_r644746888
##
File path: solr/solr-ref-guide/src/coreadmin-api.adoc
##
@@ -50,6 +94,45 @@ The `CREATE` action creates a new core and registers it.
If a Solr core with the
[
https://issues.apache.org/jira/browse/SOLR-15337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-15337.
---
Fix Version/s: 8.9
Resolution: Fixed
> Avoid XPath in solrconfig.xml parsing
> ---
[
https://issues.apache.org/jira/browse/SOLR-15337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356384#comment-17356384
]
Cassandra Targett commented on SOLR-15337:
--
So at a minimum it should have a fix
[
https://issues.apache.org/jira/browse/SOLR-15090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-15090.
Resolution: Fixed
> Allow backups to GCS (Google Cloud Storage)
> -
gerlowskija commented on a change in pull request #91:
URL: https://github.com/apache/solr/pull/91#discussion_r644701396
##
File path: solr/solr-ref-guide/src/coreadmin-api.adoc
##
@@ -50,6 +94,45 @@ The `CREATE` action creates a new core and registers it.
If a Solr core with
alessandrobenedetti commented on pull request #129:
URL: https://github.com/apache/solr/pull/129#issuecomment-853779305
I agree it's not the most elegant solution to check on the type instance
(but there's plenty in Solr that does that), but I still think that it is an
inconsistency.
As
alessandrobenedetti commented on a change in pull request #129:
URL: https://github.com/apache/solr/pull/129#discussion_r644688429
##
File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java
##
@@ -1149,18 +1151,21 @@ protected Query getFieldQuery(String fi
alessandrobenedetti commented on a change in pull request #129:
URL: https://github.com/apache/solr/pull/129#discussion_r644688429
##
File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java
##
@@ -1149,18 +1151,21 @@ protected Query getFieldQuery(String fi
alessandrobenedetti commented on a change in pull request #129:
URL: https://github.com/apache/solr/pull/129#discussion_r644684545
##
File path:
solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java
##
@@ -1771,6 +1775,35 @@ public void testSplitOnWhitespace_
alessandrobenedetti commented on a change in pull request #129:
URL: https://github.com/apache/solr/pull/129#discussion_r644685992
##
File path:
solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java
##
@@ -1771,6 +1775,35 @@ public void testSplitOnWhitespace_
alessandrobenedetti commented on pull request #158:
URL: https://github.com/apache/solr/pull/158#issuecomment-853759656
As soon as I see an approval and we get potentially a final feedback by
@sarowe , I am happy to merge.
For cherry picking, I was just taking a look to the minor ver
atris commented on a change in pull request #96:
URL: https://github.com/apache/solr/pull/96#discussion_r64498
##
File path: solr/core/src/test/org/apache/solr/util/TestCircuitBreaker.java
##
@@ -199,7 +201,63 @@ public void testFakeCPUCircuitBreaker() {
PluginInfo p
[
https://issues.apache.org/jira/browse/SOLR-15449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356311#comment-17356311
]
Alessandro Benedetti commented on SOLR-15449:
-
I am in no rush for the fix [~
atris commented on a change in pull request #96:
URL: https://github.com/apache/solr/pull/96#discussion_r644474656
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
##
@@ -40,12 +41,15 @@
* solution. There will be a follow up wit
alessandrobenedetti commented on a change in pull request #158:
URL: https://github.com/apache/solr/pull/158#discussion_r644662387
##
File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java
##
@@ -1159,8 +1160,11 @@ protected Query getFieldQuery(String fie
alessandrobenedetti commented on a change in pull request #158:
URL: https://github.com/apache/solr/pull/158#discussion_r644662049
##
File path: solr/core/src/java/org/apache/solr/parser/SolrQueryParserBase.java
##
@@ -1149,7 +1150,7 @@ protected Query getFieldQuery(String fiel
NazerkeBS commented on pull request #152:
URL: https://github.com/apache/solr/pull/152#issuecomment-853743587
Updated the docs as you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
janhoy commented on a change in pull request #96:
URL: https://github.com/apache/solr/pull/96#discussion_r644574952
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CircuitBreakerManager.java
##
@@ -40,12 +41,15 @@
* solution. There will be a follow up wi
bruno-roustant commented on a change in pull request #147:
URL: https://github.com/apache/solr/pull/147#discussion_r644553881
##
File path:
solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java
##
@@ -124,38 +142,29 @@ public SolrCore addCore(String name,
65 matches
Mail list logo
