gerlowskija commented on a change in pull request #91: URL: https://github.com/apache/solr/pull/91#discussion_r644701396
########## File path: solr/solr-ref-guide/src/coreadmin-api.adoc ########## @@ -50,6 +94,45 @@ The `CREATE` action creates a new core and registers it. If a Solr core with the given name already exists, it will continue to handle requests while the new core is initializing. When the new core is ready, it will take new requests and the old core will be unloaded. `admin/cores?action=CREATE&name=_core-name_&instanceDir=_path/to/dir_&config=solrconfig.xml&dataDir=data` +[.dynamic-tabs] +-- +[example.tab-pane#v1coreadmin-create] +==== +[.tab-label]*V1 API* + +Assuming you are using an existing configSet to create your new core: +[source,bash] +---- +http://localhost:8983/solr/admin/cores?action=CREATE&&name=techproducts_v2&configSet=sample_techproducts_configs + +---- + +If you have already existing core files deployed on disk, and need to just create the Solr core from them then the url will look something like +[source,bash] +---- +admin/cores?action=CREATE&name=_core-name_&instanceDir=_path/to/dir_&config=solrconfig.xml&dataDir=data +---- +==== + +[example.tab-pane#v2coreadmin-create] +==== +[.tab-label]*V2 API* + +Assumes SOLR-15372 is committed. + +[source,bash] +---- +curl -X POST http://localhost:8983/api/cores -H 'Content-Type: application/json' -d' Review comment: [0] I think you're missing a space between `-d` and the single-quote that starts the request-body, which I think would fail the command? ########## File path: solr/solr-ref-guide/src/schema-api.adoc ########## @@ -112,7 +93,7 @@ curl -X POST -H 'Content-type:application/json' --data-binary '{ "name":"sell_by", "type":"pdate", "stored":true } -}' http://localhost:8983/solr/gettingstarted/schema +}' http://localhost:8983/solr/techproducts/schema Review comment: [+1] Good thought to standardize on techproducts here! ########## File path: solr/solr-ref-guide/src/schema-api.adoc ########## @@ -844,12 +827,27 @@ If `multiValued` is defined as either true or false (most likely true), that wil ==== List Fields Examples -Get a list of all fields. +[.dynamic-tabs] +-- +[example.tab-pane#v1list-fields] +==== +[tab-label]*V1 API* +[source,bash] +---- +http://localhost:8983/techproducts/schema/fields +---- +==== +[example.tab-pane#v2list-fields] +==== +[tab-label]*V2 API* [source,bash] ---- -curl http://localhost:8983/solr/gettingstarted/schema/fields + +curl -X GET "http://localhost:8983/api/collections/techproducts/schema/fields?wt=json"; Review comment: [Q] Is the `wt=json` here redundant, or does the schema API really return something other than JSON by default? ########## File path: solr/solr-ref-guide/src/coreadmin-api.adoc ########## @@ -118,7 +201,33 @@ http://localhost:8983/solr/admin/cores?action=CREATE&name=my_core&collection=my_ The RELOAD action loads a new core from the configuration of an existing, registered Solr core. While the new core is initializing, the existing one will continue to handle requests. When the new Solr core is ready, it takes over and the old core is unloaded. -`admin/cores?action=RELOAD&core=_core-name_` +[.dynamic-tabs] +-- +[example.tab-pane#v1coreadmin-reload] +==== +[.tab-label]*V1 API* + +[source,bash] +---- +http://localhost:8983/solr/admin/cores?action=RELOAD&core=techproducts + +---- +==== + +[example.tab-pane#v2coreadmin-reload] +==== +[.tab-label]*V2 API* + +[source,bash] +---- +curl -X POST http://localhost:8983/api/cores/techproducts -H 'Content-Type: application/json' -d' Review comment: [0] I think you're missing a space between `-d` and the single-quote that starts the request-body, which I think would fail the command? ########## File path: solr/solr-ref-guide/src/coreadmin-api.adoc ########## @@ -50,6 +94,45 @@ The `CREATE` action creates a new core and registers it. If a Solr core with the given name already exists, it will continue to handle requests while the new core is initializing. When the new core is ready, it will take new requests and the old core will be unloaded. `admin/cores?action=CREATE&name=_core-name_&instanceDir=_path/to/dir_&config=solrconfig.xml&dataDir=data` +[.dynamic-tabs] +-- +[example.tab-pane#v1coreadmin-create] +==== +[.tab-label]*V1 API* + +Assuming you are using an existing configSet to create your new core: +[source,bash] +---- +http://localhost:8983/solr/admin/cores?action=CREATE&&name=techproducts_v2&configSet=sample_techproducts_configs + +---- + +If you have already existing core files deployed on disk, and need to just create the Solr core from them then the url will look something like +[source,bash] +---- +admin/cores?action=CREATE&name=_core-name_&instanceDir=_path/to/dir_&config=solrconfig.xml&dataDir=data +---- +==== + +[example.tab-pane#v2coreadmin-create] +==== +[.tab-label]*V2 API* + +Assumes SOLR-15372 is committed. Review comment: [0] The way I read SOLR-15372, it's specific to configuration used by our techproducts example. Is that right? I know we mention that these commands assume the "techproducts" example, but it still seems weird to mention this bug here. Only 1% of readers are going to be "following along " with a techproducts example locally, and I'd hate for users to think that there's some bug with core-creation generally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
