Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147580191
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/StreamTableSourceScan.scala
---
@@ -56,33 +63,123 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147582469
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSource.scala
---
@@ -38,23 +38,26 @@ import
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147574828
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceUtil.scala
---
@@ -0,0 +1,518 @@
+/*
+ * Licensed to
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4894#discussion_r147583120
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FieldComputer.scala
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4934
[FLINK-7800] [table] Enable window joins without equi-join predicates
## What is the purpose of the change
This PR enables the stream window joins without equi-join predicates
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4790
Hi @aljoscha, I wonder if you could take a look at this PR (as well as
#4819) when you are convenient. Thanks!
---
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/4819
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4819
Thanks @aljoscha. Will close this PR.
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/4790
Thanks!
---
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/4790
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r148948471
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/DataStreamInnerJoin.scala
---
@@ -0,0 +1,287
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4471#discussion_r148948528
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamJoinRule.scala
---
@@ -0,0 +1,112
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4977
[FLINK-7996] [table] Add support for (left.time = right.time) predicates to
window join
## What is the purpose of the change
This PR adds `left.time = right.time` predicates support for time
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5016
[FLINK-8069] [table] Support empty watermark strategy for TableSources
## What is the purpose of the change
This PR enables an empty watermark strategy for
`RowtimeAttributeDescriptor
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5016
Thanks for the review @fhueske. I think you are right. A dedicated
`WatermarkStrategy` with watermark-preserve semantics should be better. I'll
update the PR according to your comments. Thanks.
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5016
Hi @fhueske, the PR has been updated. During the refactoring, I got two
questions.
1. Do you think it's still necessary to allow the watermark strategy to be
`null`?
2. Currentl
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5025#discussion_r151604198
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -234,11 +234,12 @@ abstract class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5025#discussion_r151604024
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/TimeAttributesITCase.scala
---
@@ -179,6 +179,32 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5025#discussion_r151613194
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -234,11 +234,12 @@ abstract class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5025#discussion_r151637017
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
---
@@ -234,11 +234,12 @@ abstract class
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5032
[FLINK-8090] [DataStream] Improve the error message for duplicate state name
## What is the purpose of the change
This PR improves the error message when users trying to access two states
of
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/4297
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5032
Hi @bowenli86, thanks for the review. This PR only changes the message of
`RuntimeException`, thus may not be easily verified. To improve that, we'd add
some dedicated exceptions for that. What d
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5032#discussion_r152454242
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContextTest.java
---
@@ -270,6 +271,20 @@ public void
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5056
[FLINK-8118] [table] Allow specifying reading offsets of KafkaTableSources
## What is the purpose of the change
This PR enables the kafka table source builder to specify start reading
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5056
Hi @fhueske, thanks for the review! The PR has been updated according to
your comments.
Thanks, Xingcan
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5056#discussion_r152797724
--- Diff: docs/dev/table/sourceSinks.md ---
@@ -264,6 +288,30 @@ val source: TableSource[_] =
Kafka010AvroTableSource.builder
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5032
Hi @aljoscha, I wonder if you could help review this PR when you are
convenient.
Thanks, Xingcan
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5068
[FLINK-8122] [table] Name all built-in table sinks and sources
## What is the purpose of the change
This PR adds names for all built-in table sources and sinks.
## Brief change log
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r153179456
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
---
@@ -60,4 +60,14 @@ trait TableSource[T
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r153182297
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
---
@@ -60,4 +60,14 @@ trait TableSource[T
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5032
Thanks for the suggestion @aljoscha.
The problem is the state type is provided via a generic type parameter `S
extends State`, which will be erased in runtime. Thus it's hard to do
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5068#discussion_r153432702
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
---
@@ -60,4 +60,14 @@ trait TableSource[T
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5094
Hi @hequn8128, thanks for looking into this.
I've checked the current implementation and found that it really may emit
late data. However, that was caused by the checkings below:
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5094
Hi @hequn8128, let me try to explain this.
1. In current implementation, the join process just relies on the cached
rows instead of the watermarks. Specifically, when receiving a record, the
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5094
Hi @hequn8128, as @fhueske explained, watermarks should not define the
semantics of the join. We just emit join results, in spite of whether they are
late and the join function should not care about
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5094
Never mind~ Thanks for reminding me of the ideas :-)
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/6356
[FLINK-9790] [doc] Add documentation for UDF in SQL Client
## What is the purpose of the change
This PR aims to add document for UDF in SQL Client.
## Brief change log
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/4297
[FLINK-6936] [streaming] Add multiple targets support for custom partitioner
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/6106
[hotfix][table] Remove a println statement
## What is the purpose of the change
Remove a `println` statement in `TimeBoundedStreamJoin`.
## Brief change log
Remove a
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6106
It's my fault. Sorry about that:see_no_evil:
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6106
Merging this.
---
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/6106
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5660#discussion_r194250975
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableResultView.java
---
@@ -159,6 +160,9 @@ protected void
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5660
Hi @twalthr, the PR has been reworked. Take a look when you are convenient.
Thanks!
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5660
Thanks for the improvements, @twalthr.
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196994767
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/UDFDescriptor.java
---
@@ -0,0 +1,153
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196995241
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
---
@@ -101,6 +110,16 @@ public
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196995191
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/UDFDescriptor.java
---
@@ -0,0 +1,153
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196995942
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
---
@@ -187,6 +206,7 @@ private
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196996002
--- Diff:
flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
---
@@ -145,6 +146,68 @@ public
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196996876
--- Diff:
flink-libraries/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/utils/UserDefinedFunctions.java
---
@@ -0,0 +1,105
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r196998269
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/PrimitiveTypeValidator.scala
---
@@ -0,0 +1,72
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r197005582
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/PrimitiveTypeDescriptor.scala
---
@@ -0,0 +1,56
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r198482931
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/UDFDescriptor.java
---
@@ -0,0 +1,153
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r198484614
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
---
@@ -187,6 +206,7 @@ private
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6090#discussion_r198485307
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/PrimitiveTypeDescriptor.scala
---
@@ -0,0 +1,56
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6090
Hi @twalthr, sorry for the delay. I've been quite busy with my graduation
these weeks. Everything's finished now and I'll put these tasks back on track.
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6090
Hi @twalthr, please give me one more day. I will commit the changes
tomorrow. ð
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6253
Hi @HeartSaVioR, really sorry for the late reply. The problem that has
always been confusing me is how to configure the date format. Anyway,
supporting the standard ISO one is a great first step
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/6090
Hi @twalthr, I've made some changes to the PR.
1. Add a normalize method in `ClassTypeValidator` which converts the config
like `constructor.0 = abc` to `constructor.0.type = STRING construc
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5610
Thanks for the review @twalthr. ð
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/6003
[FLINK-9289] Parallelism of generated operators should have max parallelism
of input
## What is the purpose of the change
This PR aims to fix the default parallelism problem for the
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5210
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188895939
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarOperatorsTest.scala
---
@@ -406,5 +406,26 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188894442
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/logic.scala
---
@@ -105,3 +105,75 @@ case class If
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188895005
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarOperatorsTest.scala
---
@@ -406,5 +406,26 @@ class
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188891077
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -809,6 +809,23 @@ trait
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r188891227
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -809,6 +809,23 @@ trait
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5660
Sure @twalthr, I'll rebase the PR soon.
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/6090
[FLINK-8863] [SQL] Add user-defined function support in SQL Client
## What is the purpose of the change
This PR aims to add user-defined function (ScalarFunction, TableFunction
and
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r171280725
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -67,14 +85,129 @@ class SchemaValidator
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5564#discussion_r171354820
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -67,14 +85,129 @@ class SchemaValidator
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5610
[FLINK-8537][table]Add a Kafka table source factory with Avro format support
## What is the purpose of the change
This PR adds the Kafka table source factory with Avro format
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5610
Hi @twalthr @fhueske, I wonder if you could help review this PR when you
are convenient.
Thanks, Xingcan
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5659
[FLINK-8661] [table] Add support for batch queries in SQL Client
## What is the purpose of the change
This PR added support for batch queries in SQL Client.
## Brief change log
Github user xccui closed the pull request at:
https://github.com/apache/flink/pull/5659
---
GitHub user xccui opened a pull request:
https://github.com/apache/flink/pull/5660
[FLINK-8861] [table] Add support for batch queries in SQL Client
## What is the purpose of the change
This PR added support for batch queries in SQL Client.
## Brief change log
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173455747
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -198,14 +205,20 @@ object
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5662
Thanks for the explanation, @twalthr! I'll update the PR and resolve the
conflicts caused.
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173784883
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -148,6 +148,13 @@ object SchemaValidator
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173791129
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -148,6 +148,13 @@ object SchemaValidator
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173857218
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/SchemaValidator.scala
---
@@ -148,6 +148,13 @@ object SchemaValidator
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173860901
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173879267
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5610
Hi @twalthr, I've rebased this PR and fixed some problems.
---
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5662#discussion_r173888555
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaJsonTableSourceFactoryTestBase.java
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174338955
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174338947
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174339810
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/QueryableTableSinkTest.scala
---
@@ -0,0 +1,102
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174339658
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/QueryableTableSinkTest.scala
---
@@ -0,0 +1,102
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174338981
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174338993
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174339296
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174338968
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,175 @@
+/*
+ * Licensed to
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/5688#discussion_r174511059
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sinks/QueryableTableSink.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Licensed to
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5660
Hi @twalthr and @fhueske, the PR has been rebased. I wonder if you could
help review it when you are convenient. Thanks~
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5660
I see, @twalthr. Sorry for my impatience.
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5068
Hi @fhueske, do you think the PR needs some other updates?
---
Github user xccui commented on the issue:
https://github.com/apache/flink/pull/5068
Thanks for the review @fhueske.
* I added the `explainSink()` method to make the `TableSink` consistent
with the `TableSource`. Discarding this method and using the
101 - 200 of 250 matches
Mail list logo
