Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/6090#discussion_r198485307 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/PrimitiveTypeDescriptor.scala --- @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.descriptors + +import org.apache.flink.api.common.typeinfo.BasicTypeInfo +import org.apache.flink.table.typeutils.TypeStringUtils + +/** + * Descriptor for a primitive type. + */ +class PrimitiveTypeDescriptor[T] extends HierarchyDescriptor { + + // TODO not sure if we should the BasicTypeInfo here + var typeInformation: BasicTypeInfo[T] = _ + var value: T = _ + + def setType(basicType: BasicTypeInfo[T]): PrimitiveTypeDescriptor[T] = { --- End diff -- Sounds reasonable. Thanks.
---