[GitHub] flink pull request #5068: [FLINK-8122] [table] Name all built-in table sinks...

[xccui]

Github user xccui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5068#discussion_r153182297
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala
 ---
    @@ -60,4 +60,14 @@ trait TableSource[T] {
         */
       def explainSource(): String = ""
     
    +  /**
    +    * Gets the name which is used by the visualization and logging during 
runtime.
    +    *
    +    * @return Name of the [[TableSource]].
    +    */
    +  def getRuntimeName(): String = {
    --- End diff --
    
    Shall I reserve the existing `explainSource()`  implementations or use a 
unified one?


---