Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
> I am a bit out of the loop here. Why do we need a field accessor in the
TypeInformation?
We need this for situations when the user specifies a nested field
expression, which goes thro
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
@twalthr, thank you for the comments, I'll try to address them soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75907421
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r75908195
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76024415
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040491
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/BasicArrayTypeInfo.java
---
@@ -121,6 +122,18 @@ public boolean isKeyType
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040498
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/BasicTypeInfo.java
---
@@ -171,6 +172,23 @@ public boolean isKeyType
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040502
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040516
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040532
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040520
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/TypeInformation.java
---
@@ -160,6 +161,53 @@ public boolean isSortKeyType
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040551
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040566
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -317,7 +308,39 @@ public int getFieldIndex(String fieldName
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040578
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040541
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040571
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TupleTypeInfoBase.java
---
@@ -203,7 +205,26 @@ public void getFlatFields(String
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040561
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -317,7 +308,39 @@ public int getFieldIndex(String fieldName
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040529
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040630
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/FieldAccessor.java
---
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040621
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040657
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/typeutils/CaseClassTypeInfo.scala
---
@@ -236,6 +237,31 @@ abstract class CaseClassTypeInfo[T
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040641
--- Diff:
flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/ProductFieldAccessor.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040669
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/DataStreamPojoITCase.java
---
@@ -139,17 +139,6 @@ public void flatMap(Data value
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76040664
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -301,12 +301,12 @@ public KeyedStream
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
@twalthr I think I have addressed all your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76576754
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2094#discussion_r76576801
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/FieldAccessorTest.java
---
@@ -0,0 +1,336 @@
+/*
+ * Licensed to the Apache
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
@rmetzger Thanks for looking at it.
> Is there a reason why the DataSet methods for "sum()" for example do not
allow to aggregate on POJOs with this change?
The reason i
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
https://issues.apache.org/jira/browse/FLINK-4575
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77983346
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -455,6 +459,33 @@ public boolean isForceAvroEnabled
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77984130
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -455,6 +459,33 @@ public boolean isForceAvroEnabled
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77986502
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77986671
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77987079
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77987122
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77987318
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77987928
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77988402
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -393,6 +443,18 @@ public void addComparatorField(int fieldId
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77989471
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoComparatorGenerator.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77990034
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/GenTypeComparatorProxy.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77990200
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/GenTypeSerializerProxy.java
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77990262
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoComparatorGenerator.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77990329
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77990530
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -377,9 +425,11 @@ public void initializeTypeComparatorBuilder
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77991234
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77992445
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77992481
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77992416
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77993022
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77993053
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77993831
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r7799
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77995157
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/GenTypeComparatorProxy.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77995491
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/GenTypeComparatorProxy.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77995790
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/GenTypeSerializerProxy.java
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77996133
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77999725
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoComparatorGenerator.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78000250
--- Diff: flink-core/src/main/resources/PojoComparatorTemplate.ftl ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78001809
--- Diff: flink-core/src/main/resources/PojoSerializerTemplate.ftl ---
@@ -0,0 +1,372 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78002589
--- Diff: flink-core/src/main/resources/PojoSerializerTemplate.ftl ---
@@ -0,0 +1,372 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78003691
--- Diff: flink-core/src/main/resources/PojoSerializerTemplate.ftl ---
@@ -0,0 +1,372 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78003840
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78136985
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78138160
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78138683
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,242 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78149815
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerTest.java
---
@@ -50,7 +50,6 @@
@Override
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78149877
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/PojoSubclassSerializerTest.java
---
@@ -41,7 +41,6
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78151473
--- Diff: flink-examples/flink-examples-streaming/pom.xml ---
@@ -84,6 +84,11 @@ under the License.
test
test
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78153106
--- Diff: flink-core/src/main/resources/PojoComparatorTemplate.ftl ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78153259
--- Diff:
flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java ---
@@ -71,13 +139,18 @@ public ClassLoaderObjectInputStream(InputStream in
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78154021
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoComparatorGenerator.java
---
@@ -0,0 +1,191 @@
+/*
+ * Licensed to
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78708846
--- Diff: flink-core/pom.xml ---
@@ -76,6 +76,18 @@ under the License.
commons-collections
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78750651
--- Diff: flink-examples/flink-examples-streaming/pom.xml ---
@@ -84,6 +84,11 @@ under the License.
test
test
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78775276
--- Diff: flink-core/src/main/resources/PojoSerializerTemplate.ftl ---
@@ -0,0 +1,445 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
> As for this pull request I suggest to update the false Javadoc from the
streaming API and document in the concepts that the aggregation field accessors
and the keyselectors are slightly differ
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79003843
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationIntermediateTask.java
---
@@ -82,43 +82,46 @@ protected void
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79005879
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
@@ -87,4 +87,6 @@
* @throws Exception Exceptions may be
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79010283
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
@@ -87,4 +87,6 @@
* @throws Exception Exceptions may be
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79038567
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
@@ -87,4 +87,6 @@
* @throws Exception Exceptions may be
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79040795
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
@@ -87,4 +87,6 @@
* @throws Exception Exceptions may be
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2495
The tests that are failing are in `flink-gelly-examples`, for example
`SingleSourceShortestPathsITCase`. They have error msgs that indicate memory
management errors, e.g.
`Caused by
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2495
Btw. before submitting a pull request, it is good practice to run `mvn
clean verify` locally (or do a Travis build), and make sure that there are no
test failures (or, at least no test failures
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79347709
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
@@ -87,4 +87,6 @@
* @throws Exception Exceptions may be
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2510#discussion_r79370262
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/JoinTaskIterator.java
---
@@ -68,4 +72,9 @@
* method signals an
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2510#discussion_r79373063
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/resettable/AbstractBlockResettableIterator.java
---
@@ -183,4 +183,24 @@ protected T
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2510#discussion_r79375332
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/AbstractIterativeTask.java
---
@@ -125,6 +125,16 @@ protected void initialize
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2510#discussion_r79376690
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/JoinDriver.java
---
@@ -128,17 +130,22 @@ public void prepare() throws Exception
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r70182744
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/GroupedDataSet.scala ---
@@ -282,27 +283,57 @@ class GroupedDataSet[T: ClassTag
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r70182801
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java
---
@@ -1480,28 +1480,17 @@ public static int
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r70182792
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/ReduceNode.java ---
@@ -45,10 +46,28 @@ public ReduceNode(ReduceOperatorBase operator
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r70182809
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/manual/ReducePerformance.java
---
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache Software
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/1517#discussion_r70182796
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/SameTypePairComparator.java
---
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/1517
> Reading back through the discussion I see that there are many ideas for
future performance enhancements. If not already suggested I'd like to consider
skipping staging for fixed length
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
I have rebased now to the current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2642
Could you please explain why are the first and last commit
(65b3ff78f100ed1b13ec2fcc727f4869823b5918 and
ba4f429043f3985db5ab37a3902a6fee15a7440e) necessary? Are they related to
FLINK-3999?
---
If
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2510
Sorry, I'm extremely busy these days. I'm not sure when will I have time,
unfortunately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2642
OK, I see your point now @StephanEwen.
@nssalian, I'm sorry for opening the jira; I didn't think it through from
this perspective at the time.
---
If your project is set up for it, you
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2628#discussion_r84248344
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/QuickSort.java
---
@@ -49,20 +49,40 @@ protected static int getMaxDepth(int x
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2628
> I transcribed Quicksort so as to remove considerations of Java
performance and inlining. It was not clear to me that if we encapsulated the
index, page number, and page offset into an object t
1 - 100 of 300 matches
Mail list logo
