Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77987079
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern PATTERN_NESTED_FIELDS =
Pattern.compile(REGEX_NESTED_FIELDS);
private static final Pattern PATTERN_NESTED_FIELDS_WILDCARD =
Pattern.compile(REGEX_NESTED_FIELDS_WILDCARD);
+ private static final Map<Class<?>, Class<? extends TypeSerializer>>
customSerializers = new HashMap<>();
+ private static final Map<Tuple2<ArrayList<Integer>, Class>, Class<?
extends TypeComparator>> customComparators =
+ new HashMap<>();
+
private final PojoField[] fields;
private final int totalFields;
+ /**
+ * Register a custom serializer for a type. The precedence of the
serializers
+ * is the following (highest to lowest): Kryo, Avro, Custom, Generated,
Flink.
+ * The chosen serializer will be the first one from the list that is
turned on.
+ *
+ */
+ public static <C, S extends TypeSerializer<C>> void
registerCustomSerializer(Class<C> clazz, Class<S> ser) {
+ Constructor<?>[] ctors = ser.getConstructors();
+ assert ctors.length == 1;
+ assert ctors[0].getParameterTypes().length == 0;
--- End diff --
Is it documented somewhere that custom serializers have to have these
properties?
Also, these shouldn't be asserts, but throw exceptions instead. (I think
asserts are generally for internal consistency stuff, i.e., they should fire
only when you have a bug, and not when some stuff that a user gave us is not in
the right form.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
