Github user clarkyzl commented on the issue:
https://github.com/apache/flink/pull/3389
Hi @twalthr . I've updated the patch as your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user clarkyzl opened a pull request:
https://github.com/apache/flink/pull/3529
[FLINK-6039] [core] Row of TableFunction should support flexible number of
fields
Type: Improvement
Priority: Major
Components: core, table, udtf
Problem Definition: Row of
Github user clarkyzl commented on the issue:
https://github.com/apache/flink/pull/3529
I didn't change the behavior of `org.apache.flink.types.Record`. I think we
can open another issue if necessary.
---
If your project is set up for it, you can reply to this email and have
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3529#discussion_r105861507
--- Diff: flink-core/src/main/java/org/apache/flink/types/Row.java ---
@@ -66,10 +66,11 @@ public int getArity() {
* Gets the field at the
GitHub user clarkyzl opened a pull request:
https://github.com/apache/flink/pull/3530
[FLINK-6040] [table] DataStreamUserDefinedFunctionITCase occasionally fails
Type: Bug
Priority: Major
Components: table, test
Problem Definition: DataStreamUserDefinedFunctionITCase
GitHub user clarkyzl opened a pull request:
https://github.com/apache/flink/pull/3553
[FLINK-6068] [table] Support If() in built in function of TableAPI
Type: Improvement
Priority: Major
Components: table, udf
Problem Definition: We didn't register the if() i
GitHub user clarkyzl opened a pull request:
https://github.com/apache/flink/pull/3623
[FLINK-6196] [table] Support dynamic schema in Table Function
Type: Improvement
Priority: Major
Components: table, udtf
Problem Definition: Support dynamic schema in Table Function
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r110086591
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/TableSqlFunction.scala
---
@@ -53,22 +54,9 @@ class
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r110141028
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -358,4 +366,120
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r110317256
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -131,8 +129,14 @@ abstract class
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r110577213
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -135,8 +135,11 @@ abstract class
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r112126252
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -135,8 +135,11 @@ abstract class
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r112141809
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -382,7 +381,10 @@ object
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r112156728
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/DeferredTypeFlinkTableFunction.scala
---
@@ -40,6 +43,10 @@ class
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r112392884
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -382,7 +381,10 @@ object
Github user clarkyzl commented on the issue:
https://github.com/apache/flink/pull/3623
Hi @fhueske . I've updated the pull request. Could you please also leave
some comments on the latest commit?
---
If your project is set up for it, you can reply to this email and have your
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r113861371
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/dataset/DataSetUserDefinedFunctionITCase.scala
---
@@ -117,6 +117,187
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r114236223
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/DeferredTypeFlinkTableFunction.scala
---
@@ -0,0 +1,68
GitHub user clarkyzl opened a pull request:
https://github.com/apache/flink/pull/3292
[FLINK-5739] [client] fix NullPointerException in CliFrontend
Type: Bug
Priority: Major
Problem Definition: CliFrontEnd throws a NullPointerException
Design:
see https
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3292#discussion_r100945289
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -842,6 +842,12 @@ protected int executeProgram(PackagedProgram
Github user clarkyzl commented on the issue:
https://github.com/apache/flink/pull/3292
Thanks a lot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user clarkyzl opened a pull request:
https://github.com/apache/flink/pull/3389
[FLINK-5881] [table] ScalarFunction(UDF) should support variable types and
variable arguments
Type: New Feature
Priority: Major
Components: table, udf, ScalarFunction
Problem
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102483144
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/ScalarSqlFunction.scala
---
@@ -136,8 +136,18 @@ object
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102628665
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -140,6 +147,25 @@ object
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102627293
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -87,10 +87,16 @@ object
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102627751
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -87,10 +87,16 @@ object
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102628732
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/UserDefinedScalarFunctionTest.scala
---
@@ -181,6 +181,22 @@ class
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102628111
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -140,6 +147,25 @@ object
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102626945
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarFunctionCallGen.scala
---
@@ -48,10 +48,16 @@ class
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102632219
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarFunctionCallGen.scala
---
@@ -48,10 +48,16 @@ class
Github user clarkyzl commented on the issue:
https://github.com/apache/flink/pull/3389
If the following scenario happens,
```java
public int eval(String a, int... b) {
return b.length;
}
public String eval(String c) {
return c;
}
```
It
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102865002
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -78,20 +78,7 @@ object
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102864763
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -140,6 +138,24 @@ object
GitHub user clarkyzl opened a pull request:
https://github.com/apache/flink/pull/3407
[FLINK-5882] [table] TableFunction (UDTF) should support variable types and
variable arguments
Type: New Feature
Priority: Major
Components: table, udtf, TableFunction
Problem
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r103369181
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -140,6 +138,24 @@ object
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r103632469
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/ScalarSqlFunction.scala
---
@@ -112,9 +112,16 @@ object
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r103632353
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -140,6 +138,26 @@ object
GitHub user clarkyzl opened a pull request:
https://github.com/apache/flink/pull/3456
[FLINK-5832] [table] Support for simple hive UDF
Type: New Feature
Priority: Major
Components: table, udf, hive
Problem definition: Make Flink call Hive User-Defined Functions, support
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3456#discussion_r104106388
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -92,6 +92,11 @@ under the License
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3456#discussion_r104109600
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -92,6 +92,11 @@ under the License
GitHub user clarkyzl opened a pull request:
https://github.com/apache/flink/pull/3473
[FLINK-5833] [table] Support for Hive GenericUDF
Type: New Feature
Priority: Major
Components: table, udf
Problem definition: Make Flink call Hive User-Defined Functions, support
for
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r104605350
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -140,6 +138,26 @@ object
Github user clarkyzl commented on the issue:
https://github.com/apache/flink/pull/3389
Thanks @wuchong, @twalthr and @KurtYoung . I've pushed a reviewed patch as
@KurtYoung 's recent reviews.
---
If your project is set up for it, you can reply to this email and have
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r104609713
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarFunctionCallGen.scala
---
@@ -44,14 +44,24 @@ class
Github user clarkyzl commented on the issue:
https://github.com/apache/flink/pull/3456
Hi @twalthr , @KurtYoung . This feature is based on
https://github.com/apache/flink/pull/3389 . If we can get
https://github.com/apache/flink/pull/3389 merged first. This patch will look
simpler
Github user clarkyzl commented on the issue:
https://github.com/apache/flink/pull/3407
Hi @KurtYoung . Thanks for your reviewing. I've pushed another commit. This
patch is based on https://github.com/apache/flink/pull/3389. If we can get
https://github.com/apache/flink/pull
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3455#discussion_r104829653
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
---
@@ -208,4 +209,36 @@ public
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3490#discussion_r104848459
--- Diff: flink-contrib/docker-flink/Dockerfile ---
@@ -22,7 +22,7 @@ FROM java:8-jre-alpine
RUN apk add --no-cache bash snappy
# Configure
Github user clarkyzl commented on the issue:
https://github.com/apache/flink/pull/3497
+1 LGTM. Thanks @phoenixjiangnan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3495#discussion_r105077753
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java ---
@@ -137,6 +153,26 @@ public boolean hasDeprecatedKeys
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3456#discussion_r105095839
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -92,6 +92,11 @@ under the License
51 matches
Mail list logo
