Github user clarkyzl commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3623#discussion_r112156728
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/DeferredTypeFlinkTableFunction.scala
 ---
    @@ -40,6 +43,10 @@ class DeferredTypeFlinkTableFunction(
         val implicitResultType: TypeInformation[_])
       extends FlinkTableFunction(tableFunction, evalMethod) {
     
    +  val paramTypeInfos = evalMethod.getParameterTypes.map { paramType =>
    +    TypeExtractor.getForClass(paramType)
    --- End diff --
    
    I think signature types of the `eval()` method will be better. First, It 
will make them no differences in both situations.  I think I'd like to try to 
do convert the first case to the signatures of the `eval()` method. It will 
make it easier to identify which method is called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to