Re: [PR] [FLINK-37379][state/forst] Double list LRU in ForSt state and cache reload [flink]

2025-03-04 Thread via GitHub
Zakelly merged PR #26237: URL: https://github.com/apache/flink/pull/26237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Commented] (FLINK-37379) Lack of state cache load for ForSt after recovery

2025-03-04 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932290#comment-17932290 ] Zakelly Lan commented on FLINK-37379: - Merged into master : 9f5f13ba9d4f1175d06ccc9

Re: [PR] [FLINK-33734] Merge unaligned checkpoint state handle [flink]

2025-03-04 Thread via GitHub
Zakelly merged PR #24247: URL: https://github.com/apache/flink/pull/24247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Resolved] (FLINK-33734) Merge unaligned checkpoint state handle

2025-03-04 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-33734. - Fix Version/s: 2.1.0 Resolution: Fixed > Merge unaligned checkpoint state handle > --

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2025-03-04 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932293#comment-17932293 ] Zakelly Lan commented on FLINK-33734: - Merged into master via be91c9f2...0d1b5aa1 >

Re: [PR] [FLINK-37367][state/forst] Make ForSt inherit uploaded SST files after restorations. [flink]

2025-03-04 Thread via GitHub
Zakelly commented on code in PR #26202: URL: https://github.com/apache/flink/pull/26202#discussion_r1979288504 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackendBuilder.java: ## @@ -259,10 +259,14 @@ public ForStKey

[jira] [Closed] (FLINK-3154) Update Kryo version from 2.24.0 to latest Kryo LTS version

2025-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-3154. - Fix Version/s: 2.1.0 Resolution: Fixed merged: master - ef09e1716924d1e6ed64bfc273859f2de979b027 r

Re: [PR] [backport][FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter chill companion library which is abandoned. [flink]

2025-03-04 Thread via GitHub
gyfora merged PR #26243: URL: https://github.com/apache/flink/pull/26243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-04 Thread via GitHub
flinkbot commented on PR #26246: URL: https://github.com/apache/flink/pull/26246#issuecomment-2697640544 ## CI report: * 9d20743a1e0f52e33b75eb0ffac46fdd0cd0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] Bump org.apache.zookeeper:zookeeper from 3.5.10 to 3.7.2 in /flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35 [flink-shaded]

2025-03-04 Thread via GitHub
afedulov closed pull request #135: Bump org.apache.zookeeper:zookeeper from 3.5.10 to 3.7.2 in /flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35 URL: https://github.com/apache/flink-shaded/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Bump org.apache.zookeeper:zookeeper from 3.6.4 to 3.7.2 in /flink-shaded-zookeeper-parent/flink-shaded-zookeeper-36 [flink-shaded]

2025-03-04 Thread via GitHub
dependabot[bot] commented on PR #134: URL: https://github.com/apache/flink-shaded/pull/134#issuecomment-2697460996 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

Re: [PR] Bump org.apache.zookeeper:zookeeper from 3.5.10 to 3.7.2 in /flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35 [flink-shaded]

2025-03-04 Thread via GitHub
dependabot[bot] commented on PR #135: URL: https://github.com/apache/flink-shaded/pull/135#issuecomment-2697458845 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

Re: [PR] Bump org.apache.zookeeper:zookeeper from 3.6.4 to 3.7.2 in /flink-shaded-zookeeper-parent/flink-shaded-zookeeper-36 [flink-shaded]

2025-03-04 Thread via GitHub
afedulov commented on PR #134: URL: https://github.com/apache/flink-shaded/pull/134#issuecomment-2697460863 Already on 3.8.4 https://github.com/apache/flink-shaded/commit/ed2ec9a73cd416014214801e81ba7f626946a65d -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Bump org.apache.zookeeper:zookeeper from 3.6.4 to 3.7.2 in /flink-shaded-zookeeper-parent/flink-shaded-zookeeper-36 [flink-shaded]

2025-03-04 Thread via GitHub
afedulov closed pull request #134: Bump org.apache.zookeeper:zookeeper from 3.6.4 to 3.7.2 in /flink-shaded-zookeeper-parent/flink-shaded-zookeeper-36 URL: https://github.com/apache/flink-shaded/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [FLINK-36630][Connectors/Kafka] Wrap consumer.position in retryOnWakeup [flink-connector-kafka]

2025-03-04 Thread via GitHub
trompa commented on PR #133: URL: https://github.com/apache/flink-connector-kafka/pull/133#issuecomment-2698004133 TBH, I think the code is just about adding a missing wrapper on the position call to make it consistent with the rest of the usages on the file, but didnt liked to create a PR

Re: [PR] [FLINK-36630][Connectors/Kafka] Wrap consumer.position in retryOnWakeup [flink-connector-kafka]

2025-03-04 Thread via GitHub
fapaul commented on PR #133: URL: https://github.com/apache/flink-connector-kafka/pull/133#issuecomment-2698041282 > I never liked it much, But I was not able to deterministically make it throw within a thread. Any help is welcome. I agree with that the current code structure make

Re: [PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-04 Thread via GitHub
nilmadhab commented on PR #26246: URL: https://github.com/apache/flink/pull/26246#issuecomment-2697956609 can this bug be reproduced and a test case be added? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Comment Edited] (FLINK-35145) Add timeout for cluster termination

2025-03-04 Thread Nishita Pattanayak (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932348#comment-17932348 ] Nishita Pattanayak edited comment on FLINK-35145 at 3/4/25 3:17 PM: --

[jira] [Commented] (FLINK-35145) Add timeout for cluster termination

2025-03-04 Thread Nishita Pattanayak (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932348#comment-17932348 ] Nishita Pattanayak commented on FLINK-35145: Is this being worked upon? I wo

[jira] [Comment Edited] (FLINK-35145) Add timeout for cluster termination

2025-03-04 Thread Nishita Pattanayak (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932348#comment-17932348 ] Nishita Pattanayak edited comment on FLINK-35145 at 3/4/25 3:18 PM: --

[jira] [Commented] (FLINK-27641) Create view lost Time attribute in Hive Catalog

2025-03-04 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932349#comment-17932349 ] Grzegorz Kołakowski commented on FLINK-27641: - For missing *PROCTIME* attrib

[jira] [Updated] (FLINK-37418) caugth array out of index exception while using RowData.getArray method

2025-03-04 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Spongebob updated FLINK-37418: -- Description: Test RowData's arity is 10. the 5th column is an array structure. then I called rowData.

Re: [PR] Bump org.apache.zookeeper:zookeeper from 3.5.10 to 3.7.2 in /flink-shaded-zookeeper-parent/flink-shaded-zookeeper-35 [flink-shaded]

2025-03-04 Thread via GitHub
afedulov commented on PR #135: URL: https://github.com/apache/flink-shaded/pull/135#issuecomment-2697458788 Already on 3.8.4 https://github.com/apache/flink-shaded/commit/ed2ec9a73cd416014214801e81ba7f626946a65d -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FLINK-37419] fix the problem that ForStMapState serializeValue may g… [flink]

2025-03-04 Thread via GitHub
flinkbot commented on PR #26245: URL: https://github.com/apache/flink/pull/26245#issuecomment-2697544462 ## CI report: * cf25f30b4e18a217c953b1814d30399e1e2a9573 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-37419) ForStMapState serializeValue may get wrong result

2025-03-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37419: --- Labels: pull-request-available (was: ) > ForStMapState serializeValue may get wrong result

[PR] [FLINK-37419] fix the problem that ForStMapState serializeValue may g… [flink]

2025-03-04 Thread via GitHub
mayuehappy opened a new pull request, #26245: URL: https://github.com/apache/flink/pull/26245 …et wrong result ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we av

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
hlteoh37 commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979552202 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReaderTest.java: ###

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979565026 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReader.java: #

Re: [PR] Draft PR for plugin based approach for evaluation hook for scaling metric evaluation [flink-kubernetes-operator]

2025-03-04 Thread via GitHub
pchoudhury22 commented on PR #952: URL: https://github.com/apache/flink-kubernetes-operator/pull/952#issuecomment-2697507125 There is another evaluated metric, EXPECTED_PROCESSING_RATE, which gets computed at JobVertexScaler.computeScaleTargetParallelism . Since we calculate this first a

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979566056 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReader.java: #

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979569780 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReaderTest.java: #

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979571088 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReaderTest.java: #

Re: [PR] [FLINK-34558][state] Support tracking state size [flink]

2025-03-04 Thread via GitHub
Zakelly commented on PR #25837: URL: https://github.com/apache/flink/pull/25837#issuecomment-2697453076 @hejufang Sure. Sorry for the late response. I'm busy preparing the Flink 2.0.0 release. It's on a pretty tight schedule and may take few more days. I'll check this after the release.

[PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-04 Thread via GitHub
mayuehappy opened a new pull request, #26246: URL: https://github.com/apache/flink/pull/26246 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

Re: [PR] [FLINK-36172][metrics][rest] Optimize transient metric cleanup [flink]

2025-03-04 Thread via GitHub
fdc-ntflx commented on PR #26204: URL: https://github.com/apache/flink/pull/26204#issuecomment-2697766555 Thanks for the review, everyone! I got caught up with work and wasn't able to address the comments before the PR was merged. I agree that more unit tests could have been added, but I fe

[jira] [Commented] (FLINK-8929) "UnknownTaskExecutorException: No TaskExecutor registered" when having tab open for taskmanager that does not exist (anymore)

2025-03-04 Thread Seung Eun Choi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932333#comment-17932333 ] Seung Eun Choi commented on FLINK-8929: --- In my case, it was OOM Killed in K8S. > "

Re: [PR] [FLINK-37367][state/forst] Make ForSt inherit uploaded SST files after restorations. [flink]

2025-03-04 Thread via GitHub
Zakelly commented on code in PR #26202: URL: https://github.com/apache/flink/pull/26202#discussion_r1979295031 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackendBuilder.java: ## @@ -259,10 +259,14 @@ public ForStKey

[jira] [Created] (FLINK-37418) caugth array out of index exception while using RowData.getArray method

2025-03-04 Thread Spongebob (Jira)
Spongebob created FLINK-37418: - Summary: caugth array out of index exception while using RowData.getArray method Key: FLINK-37418 URL: https://issues.apache.org/jira/browse/FLINK-37418 Project: Flink

Re: [PR] [FLINK-34554] Introduce transaction strategies [flink-connector-kafka]

2025-03-04 Thread via GitHub
pnowojski commented on code in PR #154: URL: https://github.com/apache/flink-connector-kafka/pull/154#discussion_r1979381461 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/internal/TransactionAbortStrategyImpl.java: ## @@ -107,6 +119,64 @@ private

[jira] [Created] (FLINK-37419) ForStMapState serializeValue may get wrong result

2025-03-04 Thread Yue Ma (Jira)
Yue Ma created FLINK-37419: -- Summary: ForStMapState serializeValue may get wrong result Key: FLINK-37419 URL: https://issues.apache.org/jira/browse/FLINK-37419 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-37420) AbstractAggregatingState add may return wrong result

2025-03-04 Thread Yue Ma (Jira)
Yue Ma created FLINK-37420: -- Summary: AbstractAggregatingState add may return wrong result Key: FLINK-37420 URL: https://issues.apache.org/jira/browse/FLINK-37420 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-37420) AbstractAggregatingState add may return wrong result

2025-03-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37420: --- Labels: pull-request-available (was: ) > AbstractAggregatingState add may return wrong resu

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979887307 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979991125 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979991560 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/utils/KuduSplitGenerator.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Ap

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979989809 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-30371] Fix the problem of JdbcOutputFormat database connection leak [flink-connector-jdbc]

2025-03-04 Thread via GitHub
KevDi commented on PR #75: URL: https://github.com/apache/flink-connector-jdbc/pull/75#issuecomment-2698552638 Ok but how should the connection leak beeing fixed then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979568486 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/config/DynamodbStreamsSourceConfigConstants.java: ##

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
hlteoh37 commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979590842 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/source/reader/PollingDynamoDbStreamsShardSplitReaderTest.java: ###

[PR] [FLINK-37365][pyflink] Add API stability decorators for PyFlink APIs [flink]

2025-03-04 Thread via GitHub
autophagy opened a new pull request, #26247: URL: https://github.com/apache/flink/pull/26247 ## What is the purpose of the change Currently, the Java APIs use annotations like `@PublicEvolving` and `@Experimental` to clearly indicate the stability status of API components. This is su

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979988711 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on code in PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#discussion_r1980023788 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/config/DynamodbStreamsSourceConfigConstants.java: ##

Re: [PR] [FLINK-36203][Connectors/DynamoDB] Added polling delay between getrecords calls [flink-connector-aws]

2025-03-04 Thread via GitHub
gguptp commented on PR #190: URL: https://github.com/apache/flink-connector-aws/pull/190#issuecomment-2698575556 > Added some questions. Thanks @gguptp Thanks @hlteoh37 . I have updated the PR with the requested changes -- This is an automated message from the Apache Git Service. T

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979790813 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-37421) [flink-operator][FlinkDeployment] Doesn't provide a mechanism to label the deployment

2025-03-04 Thread Yaroslav Tkachenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932440#comment-17932440 ] Yaroslav Tkachenko commented on FLINK-37421: [~jklaw90] you can add labels a

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-04 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1979799806 ## flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumerator.java: ## @@ -0,0 +1,264 @@ +/* + * Licensed to

Re: [PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-04 Thread via GitHub
Zakelly commented on PR #26246: URL: https://github.com/apache/flink/pull/26246#issuecomment-2698399338 I know it's easy to add UT covering this alone, but it would be great if implementing a mocked `StateRequestHandler` and verifying those methods of 'abstract' classes via that. -- This

[jira] [Assigned] (FLINK-3154) Update Kryo version from 2.24.0 to latest Kryo LTS version

2025-03-04 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-3154: --- Assignee: Kurt Ostfeld > Update Kryo version from 2.24.0 to latest Kryo LTS version > --

Re: [PR] [FLINK-33045][format avro-confluent] disable auto-registering schema in registry [flink]

2025-03-04 Thread via GitHub
albert597 commented on PR #25410: URL: https://github.com/apache/flink/pull/25410#issuecomment-2699957640 Hey thanks for working on this - just checking in if we can merge this soon? This bug is causing very annoying bugs on our side and I think others are facing the same issue. -- This

[jira] [Closed] (FLINK-37418) caugth array out of index exception while using RowData.getArray method

2025-03-04 Thread Spongebob (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Spongebob closed FLINK-37418. - Resolution: Not A Problem > caugth array out of index exception while using RowData.getArray method > --

Re: [PR] [FLINK-36611][pipeline-connector][kafka] Add schema info to output of Kafka sink [flink-cdc]

2025-03-04 Thread via GitHub
MOBIN-F commented on code in PR #3791: URL: https://github.com/apache/flink-cdc/pull/3791#discussion_r1980832960 ## docs/content/docs/connectors/pipeline-connectors/kafka.md: ## @@ -202,79 +266,100 @@ An output example is: Data Type Mapping +[Literal type](

Re: [PR] [FLINK-36611][pipeline-connector][kafka] Add schema info to output of Kafka sink [flink-cdc]

2025-03-04 Thread via GitHub
MOBIN-F commented on PR #3791: URL: https://github.com/apache/flink-cdc/pull/3791#issuecomment-2700090679 > Thanks @MOBIN-F for this update. Overall, This modification is good for me, left some comments about the code structure. > > Additionally, you can manually test the data types i

[jira] [Updated] (FLINK-37302) Support timers in PTFs

2025-03-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37302: --- Labels: pull-request-available (was: ) > Support timers in PTFs > -- >

Re: [PR] [FLINK-36611][pipeline-connector][kafka] Add schema info to output of Kafka sink [flink-cdc]

2025-03-04 Thread via GitHub
MOBIN-F commented on code in PR #3791: URL: https://github.com/apache/flink-cdc/pull/3791#discussion_r1980840821 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/main/java/org/apache/flink/cdc/connectors/kafka/json/debezium/DebeziumJsonSerializat

Re: [PR] [BP-2.0][FLINK-37379][state/forst] Double list LRU in ForSt state and cache reload [flink]

2025-03-04 Thread via GitHub
Zakelly commented on PR #26248: URL: https://github.com/apache/flink/pull/26248#issuecomment-2700099437 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-37302][table] Support PTFs with time and timer services [flink]

2025-03-04 Thread via GitHub
snuyanzin commented on code in PR #26250: URL: https://github.com/apache/flink/pull/26250#discussion_r1980859071 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/FailingSqlTestStep.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Soft

[jira] [Closed] (FLINK-37421) [flink-operator][FlinkDeployment] Doesn't provide a mechanism to label the deployment

2025-03-04 Thread Julian (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian closed FLINK-37421. -- Resolution: Works for Me > [flink-operator][FlinkDeployment] Doesn't provide a mechanism to label the > deplo

[jira] [Commented] (FLINK-37411) Introduce the rollback mechanism for Autoscaler

2025-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932524#comment-17932524 ] Gyula Fora commented on FLINK-37411: I am still not convinced that this is the right

[jira] [Commented] (FLINK-37411) Introduce the rollback mechanism for Autoscaler

2025-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932525#comment-17932525 ] Gyula Fora commented on FLINK-37411: It could be:  1. Operator detects broken parall

[jira] [Commented] (FLINK-37411) Introduce the rollback mechanism for Autoscaler

2025-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932528#comment-17932528 ] Gyula Fora commented on FLINK-37411: In any case this is a quite tricky design overa

[jira] [Updated] (FLINK-37136) FLIP-501: Support Window Extension in DataStream V2 API

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-37136: --- Parent: FLINK-34547 Issue Type: Sub-task (was: New Feature) > FLIP-501: Support Window Exte

[jira] [Closed] (FLINK-34899) Include all classes in flink-core-api that skip the japicmp check back

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-34899. -- Resolution: Later > Include all classes in flink-core-api that skip the japicmp check back > -

[jira] [Updated] (FLINK-34547) [Umbrella] FLIP-408: Introduce DataStream API V2

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-34547: --- Fix Version/s: 2.0.0 2.0-preview 1.20.0 > [Umbrella] FLIP-408:

[jira] [Resolved] (FLINK-34547) [Umbrella] FLIP-408: Introduce DataStream API V2

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-34547. Resolution: Done > [Umbrella] FLIP-408: Introduce DataStream API V2 >

[jira] [Updated] (FLINK-37135) FLIP-500: Support Join Extension in DataStream V2 API

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-37135: --- Parent: FLINK-34547 Issue Type: Sub-task (was: New Feature) > FLIP-500: Support Join Extens

[jira] [Closed] (FLINK-34900) Check compatibility for classes in flink-core-api that skip japicmp

2025-03-04 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-34900. -- Fix Version/s: 2.0.0 Resolution: Done > Check compatibility for classes in flink-core-api that

[jira] [Commented] (FLINK-37411) Introduce the rollback mechanism for Autoscaler

2025-03-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932527#comment-17932527 ] Gyula Fora commented on FLINK-37411: Or simply with the existing operator rollback m

Re: [PR] [FLINK-37302][table] Support PTFs with time and timer services [flink]

2025-03-04 Thread via GitHub
snuyanzin commented on code in PR #26250: URL: https://github.com/apache/flink/pull/26250#discussion_r1980864849 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TestStep.java: ## @@ -50,6 +50,7 @@ enum TestKind { SINK_WITHOUT_DATA,

Re: [PR] [FLINK-37302][table] Support PTFs with time and timer services [flink]

2025-03-04 Thread via GitHub
flinkbot commented on PR #26250: URL: https://github.com/apache/flink/pull/26250#issuecomment-2700117306 ## CI report: * 6c348b520bf423faf396b024914295bf71ddd911 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37302][table] Support PTFs with time and timer services [flink]

2025-03-04 Thread via GitHub
snuyanzin commented on code in PR #26250: URL: https://github.com/apache/flink/pull/26250#discussion_r1980862517 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/FailingSqlTestStep.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Soft

Re: [PR] [FLINK-37367][state/forst] Make ForSt inherit uploaded SST files after restorations. [flink]

2025-03-04 Thread via GitHub
AlexYinHan commented on code in PR #26202: URL: https://github.com/apache/flink/pull/26202#discussion_r1979170789 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackendBuilder.java: ## @@ -259,10 +259,14 @@ public ForSt

Re: [PR] [FLINK-37162][hotfix][docs] Update some inaccurate descriptions. [flink]

2025-03-04 Thread via GitHub
davidradl commented on code in PR #26223: URL: https://github.com/apache/flink/pull/26223#discussion_r1978999152 ## docs/content/docs/dev/datastream/sinks.md: ## @@ -93,36 +93,36 @@ The `Sink` needs to be serializable. All configuration should be validated eager ### Custom s

[jira] [Commented] (FLINK-36826) Default configurations fail to start Flink java 17 images

2025-03-04 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932200#comment-17932200 ] Fabian Paul commented on FLINK-36826: - Closing due to duplicate of https://issues.ap

Re: [PR] [BP-2.0][FLINK-37387][build] Enable license check for jdk17 and jdk21 [flink]

2025-03-04 Thread via GitHub
flinkbot commented on PR #26244: URL: https://github.com/apache/flink/pull/26244#issuecomment-2696787893 ## CI report: * b58d8421bb1e1fd4efa7c01ea210f520a688dbbf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-36826) Default configurations fail to start Flink java 17 images

2025-03-04 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul closed FLINK-36826. --- Resolution: Duplicate > Default configurations fail to start Flink java 17 images >

Re: [PR] [FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter … [flink]

2025-03-04 Thread via GitHub
gyfora merged PR #25896: URL: https://github.com/apache/flink/pull/25896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[PR] [backport][FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter chill companion library which is abandoned. [flink]

2025-03-04 Thread via GitHub
gyfora opened a new pull request, #26243: URL: https://github.com/apache/flink/pull/26243 Backport of https://github.com/apache/flink/pull/25896 to 2.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [FLINK-30371] Fix the problem of JdbcOutputFormat database connection leak [flink-connector-jdbc]

2025-03-04 Thread via GitHub
fapaul commented on PR #75: URL: https://github.com/apache/flink-connector-jdbc/pull/75#issuecomment-2696678727 > SO the one wrapping around the `flush ` I don't think that is necessary. The flush is either retried if configured or the exception fails the job, and eventually, `closeStat

Re: [PR] Bump io.netty:netty-common from 4.1.46.Final to 4.1.118.Final in /flink-end-to-end-tests/flink-end-to-end-tests-hive [flink]

2025-03-04 Thread via GitHub
dependabot[bot] commented on PR #26158: URL: https://github.com/apache/flink/pull/26158#issuecomment-2696693923 Dependabot couldn't find a pom.xml. Because of this, Dependabot cannot update this pull request. -- This is an automated message from the Apache Git Service. To respond to the m

[PR] [hotfix] fix NOTICE file in order to fix java 11 license check [flink]

2025-03-04 Thread via GitHub
JunRuiLee opened a new pull request, #26244: URL: https://github.com/apache/flink/pull/26244 [BP-2.0][hotfix] fix NOTICE file in order to fix java 11 license check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Created] (FLINK-37417) Implement better exception message to explain why KinesisSource doesn't support partial recovery

2025-03-04 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-37417: --- Summary: Implement better exception message to explain why KinesisSource doesn't support partial recovery Key: FLINK-37417 URL: https://issues.apache.org/jira/browse/FLINK-3

Re: [PR] [FLINK-37367][state/forst] Make ForSt inherit uploaded SST files after restorations. [flink]

2025-03-04 Thread via GitHub
AlexYinHan commented on code in PR #26202: URL: https://github.com/apache/flink/pull/26202#discussion_r1979208956 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackendBuilder.java: ## @@ -259,10 +259,14 @@ public ForSt

Re: [PR] [FLINK-37367][state/forst] Make ForSt inherit uploaded SST files after restorations. [flink]

2025-03-04 Thread via GitHub
AlexYinHan commented on code in PR #26202: URL: https://github.com/apache/flink/pull/26202#discussion_r1979207668 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackendBuilder.java: ## @@ -259,10 +259,14 @@ public ForSt

[jira] [Created] (FLINK-37416) DDB Streams connector flink state inconsistency issue

2025-03-04 Thread Abhi Gupta (Jira)
Abhi Gupta created FLINK-37416: -- Summary: DDB Streams connector flink state inconsistency issue Key: FLINK-37416 URL: https://issues.apache.org/jira/browse/FLINK-37416 Project: Flink Issue Type:

Re: [PR] [backport][FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter chill companion library which is abandoned. [flink]

2025-03-04 Thread via GitHub
flinkbot commented on PR #26243: URL: https://github.com/apache/flink/pull/26243#issuecomment-2696745865 ## CI report: * b73a4475fc1f2254847152342bb2122e6bf664f2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-37416) DDB Streams connector flink state inconsistency issue

2025-03-04 Thread Abhi Gupta (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhi Gupta updated FLINK-37416: --- Description: We found that for a customer when there are multiple restarts, there are state inconsi

[jira] [Commented] (FLINK-25986) Add FLIP-190 new API methods to python

2025-03-04 Thread Mika Naylor (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932246#comment-17932246 ] Mika Naylor commented on FLINK-25986: - Hi all, I'd like to take this ticket over. I

Re: [PR] [FLINK-34554] Introduce transaction strategies [flink-connector-kafka]

2025-03-04 Thread via GitHub
fapaul commented on code in PR #154: URL: https://github.com/apache/flink-connector-kafka/pull/154#discussion_r1979035891 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriterStateSerializer.java: ## @@ -47,8 +54,15 @@ public byte[] serialize(

Re: [PR] [FLINK-21912][pyflink] Introduce ResolvedSchema in Python Table API [flink]

2025-03-04 Thread via GitHub
twalthr merged PR #26121: URL: https://github.com/apache/flink/pull/26121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Closed] (FLINK-21912) Introduce Schema and ResolvedSchema in Python API

2025-03-04 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-21912. Fix Version/s: 2.1.0 Assignee: Mika Naylor Resolution: Fixed Fixed in master: ea9c

  1   2   >