pnowojski commented on code in PR #154:
URL:
https://github.com/apache/flink-connector-kafka/pull/154#discussion_r1979381461
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/internal/TransactionAbortStrategyImpl.java:
##########
@@ -107,6 +119,64 @@ private int abortTransactionOfSubtask(String prefix, int
subtaskId, Context cont
}
return numTransactionAborted;
}
+ },
+ LISTING {
+ private final EnumSet<TransactionState> abortableStates =
+ EnumSet.complementOf(
+ EnumSet.of(
+ TransactionState.COMPLETE_ABORT,
+ TransactionState.COMPLETE_COMMIT,
+ TransactionState.PREPARE_COMMIT));
+
+ @Override
+ public void abortTransactions(Context context) {
+
+ Collection<TransactionListing> openTransactionsForTopics =
+ AdminUtils.getOpenTransactionsForTopics(
+ context.getAdminClient(), context.getTopicNames());
+
+ // This list could be huge if
TransactionNamingStrategy#INCREMENTING is used, so cap it
+ LOG.trace(
Review Comment:
+1 this should be `WARN`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
