gguptp commented on code in PR #190:
URL:
https://github.com/apache/flink-connector-aws/pull/190#discussion_r1979568486
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/config/DynamodbStreamsSourceConfigConstants.java:
##########
@@ -76,6 +76,21 @@ public enum InitialPosition {
public static final String BASE_DDB_STREAMS_USER_AGENT_PREFIX_FORMAT =
"Apache Flink %s (%s) DynamoDb Streams Connector";
+ public static final ConfigOption<Duration>
+ DYNAMODB_STREAMS_GET_RECORDS_IDLE_TIME_BETWEEN_EMPTY_POLLS =
+
ConfigOptions.key("flink.dynamodbstreams.getrecords.empty.mindelay")
+ .durationType()
+ .defaultValue(Duration.ofMillis(1000))
+ .withDescription(
+ "The idle time between empty polls for
DynamoDB Streams GetRecords API");
+ public static final ConfigOption<Duration>
+ DYNAMODB_STREAMS_GET_RECORDS_IDLE_TIME_BETWEEN_NON_EMPTY_POLLS =
+
ConfigOptions.key("flink.dynamodbstreams.getrecords.nonempty.mindelay")
+ .durationType()
+ .defaultValue(Duration.ofMillis(250))
Review Comment:
I thought 0 would lead to an undeterministic number of calls, 250 would
ensure that the calls are capped at 4 rps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
