yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886088951
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala:
##
@@ -1158,7 +1157,7 @@ class TemporalTypesTest
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886085683
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##
@@ -783,8 +790,15 @@ private Stream toTimestamp
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886084382
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##
@@ -2332,7 +2332,8 @@ ANY, and(logical(LogicalTyp
[
https://issues.apache.org/jira/browse/FLINK-36876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905885#comment-17905885
]
chenyuzhi commented on FLINK-36876:
---
Well, how about rewrite a new RestClient/RestClus
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886085970
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala:
##
@@ -1140,41 +1140,41 @@ class TemporalTypesTe
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886090826
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -92,74 +121,72 @@ public Timestamp
RocMarshal opened a new pull request, #25800:
URL: https://github.com/apache/flink/pull/25800
## What is the purpose of the change
[hotfix][configuration] Remove the deprecated test class
TaskManagerLoadBalanceModeTest.
## Brief change log
[hotfix][config
flinkbot commented on PR #25800:
URL: https://github.com/apache/flink/pull/25800#issuecomment-2544698974
## CI report:
* 433c2ec4dddc3a77448feed1bddc1585c13fef35 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
Zakelly commented on PR #25792:
URL: https://github.com/apache/flink/pull/25792#issuecomment-2544427450
Thanks for the review! Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
hackergin commented on code in PR #25730:
URL: https://github.com/apache/flink/pull/25730#discussion_r1886088606
##
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java:
##
@@ -330,6 +336,41 @@ public OperationHandle refre
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886088390
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ToTimestampLtzTypeStrategy.java:
##
@@ -23,19 +23,54 @@
import org.
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886084382
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##
@@ -2332,7 +2332,8 @@ ANY, and(logical(LogicalTyp
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886083289
##
docs/data/sql_functions.yml:
##
@@ -679,9 +679,15 @@ temporal:
- sql: TO_DATE(string1[, string2])
table: toDate(STRING1[, STRING2])
description: Conve
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886094264
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ToTimestampLtzFunction.java:
##
@@ -0,0 +1,165 @@
+/*
+ * Licensed to
reswqa merged PR #25795:
URL: https://github.com/apache/flink/pull/25795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache
[
https://issues.apache.org/jira/browse/FLINK-36906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaochen.zhou updated FLINK-36906:
--
Description: When determining if a split is finished, process only the
partitions with data fr
[
https://issues.apache.org/jira/browse/FLINK-36906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaochen.zhou updated FLINK-36906:
--
Labels: pull-request-available (was: )
> Optimize the logic for determining if a split is fin
[
https://issues.apache.org/jira/browse/FLINK-36906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaochen.zhou updated FLINK-36906:
--
Priority: Minor (was: Major)
> Optimize the logic for determining if a split is finished.
> -
[
https://issues.apache.org/jira/browse/FLINK-36906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaochen.zhou updated FLINK-36906:
--
Component/s: Connectors / Kafka
> Optimize the logic for determining if a split is finished.
>
xiaochen.zhou created FLINK-36906:
-
Summary: Optimize the logic for determining if a split is finished.
Key: FLINK-36906
URL: https://issues.apache.org/jira/browse/FLINK-36906
Project: Flink
xiaochen-zhou commented on PR #141:
URL:
https://github.com/apache/flink-connector-kafka/pull/141#issuecomment-2544655796
Friendly ping, do you have time to take a look @AHeise 🙏 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886093369
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java:
##
@@ -385,6 +388,18 @@ public static TimestampData toTimestampData(i
[
https://issues.apache.org/jira/browse/FLINK-36892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17905873#comment-17905873
]
Zakelly Lan commented on FLINK-36892:
-
Merged 8aeb2ff into master.
> Properly handl
Zakelly merged PR #25792:
URL: https://github.com/apache/flink/pull/25792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apach
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886086309
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala:
##
@@ -1308,29 +1303,42 @@ class TemporalTypesTe
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886085970
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala:
##
@@ -1140,41 +1140,41 @@ class TemporalTypesTe
yiyutian1 commented on PR #25763:
URL: https://github.com/apache/flink/pull/25763#issuecomment-2544463015
> Reviewed by Chi on 12/12/24 Group to test and/or review outside of the
meeting (Nic Townsend from IBM has some insight he will add on this)
Hi @davidradl, I appreciate your invo
[
https://issues.apache.org/jira/browse/FLINK-36160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhuanshenbsj1 updated FLINK-36160:
--
Description:
Currently, Flink only supports advanced parameter configuration for its direct
i
zhuanshenbsj1 commented on code in PR #25258:
URL: https://github.com/apache/flink/pull/25258#discussion_r1886263037
##
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java:
##
@@ -226,6 +243,37 @@ public HiveCatalog(
}
zhuanshenbsj1 commented on PR #25258:
URL: https://github.com/apache/flink/pull/25258#issuecomment-2544738657
@luoyuxia cc~
> @zhuanshenbsj1 Thanks for contribution. And sorry for late reply. I left
some comments; Also, please fill the motivation in JIRA
[FLINK-36160](https://issues
zhuanshenbsj1 commented on PR #25258:
URL: https://github.com/apache/flink/pull/25258#issuecomment-2544739370
@luoyuxia cc~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zhuanshenbsj1 commented on code in PR #25258:
URL: https://github.com/apache/flink/pull/25258#discussion_r1886265775
##
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java:
##
@@ -226,6 +243,37 @@ public HiveCatalog(
}
lvyanquan opened a new pull request, #19:
URL: https://github.com/apache/flink-connector-hive/pull/19
Refer to the discussion in
https://lists.apache.org/thread/v44y2yh4b5wyp1lqrxgxc8qh680wpgfr, bumping to
1.20 can help us to better prepare next release.
A following pr to cherry-pic
boring-cyborg[bot] commented on PR #19:
URL:
https://github.com/apache/flink-connector-hive/pull/19#issuecomment-2544745765
Thanks for opening this pull request! Please check out our contributing
guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
--
This is an
[
https://issues.apache.org/jira/browse/FLINK-36887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-36887:
---
Labels: pull-request-available (was: )
> Add support for Flink 1.20 in Flink Hive connector
AHeise commented on PR #139:
URL:
https://github.com/apache/flink-connector-kafka/pull/139#issuecomment-2544777216
Hi @lvyanquan , thank you very much for tackling the release. Unfortunately,
I don't have time to review it this year and per prior agreement, I expected
@PatrickRen and @leon
[
https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhanghao Chen updated FLINK-3:
--
Description:
FLINK-34123 introduced built-in serialization support for java.util.List, which
[ https://issues.apache.org/jira/browse/FLINK-3 ]
Zhanghao Chen deleted comment on FLINK-3:
---
was (Author: zhanghao chen):
FLINK-23420 is similar to our case here. We can extend ListSerializer to allow
null values via a binary mask fo
flinkbot commented on PR #25798:
URL: https://github.com/apache/flink/pull/25798#issuecomment-2543873996
## CI report:
* 1f3a7b8dc0a6b1f4bc13c239c804bd466950b906 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-36069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-36069:
---
Labels: pull-request-available (was: )
> Extending job detail rest API to adapt to Incremen
yuchen-ecnu opened a new pull request, #25798:
URL: https://github.com/apache/flink/pull/25798
## What is the purpose of the change
- Extending job detail rest API to adapt to Incremental JobGraph
Generation in batch mode.
- Modify web ui to support job graph auto-refr
yuchen-ecnu commented on PR #25798:
URL: https://github.com/apache/flink/pull/25798#issuecomment-2543873799
Hi @JunRuiLee, can you help to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
alenzo-arch commented on PR #29:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/29#issuecomment-2543936042
Are there any plans to merge this PR? Seem like its there just one open
question about 1.18 (and now 1.20 as well...)
--
This is an automated message from the Apache G
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1883493055
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/TemporalTypesTest.scala:
##
@@ -1140,41 +1140,41 @@ class TemporalTypesTe
[ https://issues.apache.org/jira/browse/FLINK-34932 ]
liudu deleted comment on FLINK-34932:
---
was (Author: JIRAUSER308089):
I am willing to do this.could someone assign this to me?
> Translate concepts of Flink-Kubernetes-Operator documentation
>
reswqa commented on PR #25795:
URL: https://github.com/apache/flink/pull/25795#issuecomment-2544325095
Do Chinese documents also have this problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
grahambunce commented on PR #29:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/29#issuecomment-2543937396
Is this still waiting on @MartijnVisser ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
JunRuiLee commented on code in PR #25798:
URL: https://github.com/apache/flink/pull/25798#discussion_r1886070318
##
flink-runtime/src/main/java/org/apache/flink/runtime/execution/ExecutionState.java:
##
@@ -70,6 +70,8 @@ public enum ExecutionState {
RECONCILING,
+PE
[
https://issues.apache.org/jira/browse/FLINK-36897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zakelly Lan resolved FLINK-36897.
-
Resolution: Won't Do
> Error executing processElement when inheriting from
> AbstractAsyncState
[
https://issues.apache.org/jira/browse/FLINK-36892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zakelly Lan resolved FLINK-36892.
-
Resolution: Fixed
> Properly handle the watermark status
>
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886085683
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java:
##
@@ -783,8 +790,15 @@ private Stream toTimestamp
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886087882
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##
@@ -2332,14 +2332,24 @@ ANY, and(logical(LogicalT
yiyutian1 commented on code in PR #25763:
URL: https://github.com/apache/flink/pull/25763#discussion_r1886093553
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/DateTimeUtils.java:
##
@@ -386,6 +406,18 @@ public static TimestampData toTimestampData(D
AHeise commented on PR #141:
URL:
https://github.com/apache/flink-connector-kafka/pull/141#issuecomment-2544772849
Afaik this doesn't work and was the main reason for #100. If you last
message is a transaction marker, then you would never check the stop condition
on that partition at the p
sharonx commented on code in PR #3775:
URL: https://github.com/apache/flink-cdc/pull/3775#discussion_r1885836067
##
flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/PipelineExecution.java:
##
@@ -27,10 +29,18 @@ public interface PipelineExecution {
class Execu
X-czh commented on PR #25795:
URL: https://github.com/apache/flink/pull/25795#issuecomment-2544332334
@reswqa I just checked the Chinese doc, the serialization part has not been
updated for long and does not reflect the new changes brought by FLIP-398. I'll
create a new issue to update it.
liuyongvs commented on code in PR #25690:
URL: https://github.com/apache/flink/pull/25690#discussion_r1886058245
##
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/PruneEmptyRulesTest.xml:
##
Review Comment:
@snuyanzin do
liuyongvs commented on code in PR #25690:
URL: https://github.com/apache/flink/pull/25690#discussion_r1875162913
##
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/PruneEmptyRulesTest.xml:
##
Review Comment:
@snuyanzin te
liuyongvs commented on code in PR #25690:
URL: https://github.com/apache/flink/pull/25690#discussion_r1875168910
##
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/PruneEmptyRulesTest.xml:
##
Review Comment:
if you think
hiliuxg commented on code in PR #25710:
URL: https://github.com/apache/flink/pull/25710#discussion_r1886067914
##
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/AbstractPrometheusReporter.java:
##
@@ -104,7 +104,7 @@ public void notifyOf
hiliuxg commented on code in PR #25710:
URL: https://github.com/apache/flink/pull/25710#discussion_r1886067914
##
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/AbstractPrometheusReporter.java:
##
@@ -104,7 +104,7 @@ public void notifyOf
[
https://issues.apache.org/jira/browse/FLINK-36904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhanghao Chen resolved FLINK-36904.
---
Fix Version/s: 2.0.0
Resolution: Fixed
Resolved via d541997954e7b28ffa9df5e4bcaea817c
Zhanghao Chen created FLINK-36905:
-
Summary: Update Chinese document to reflect the changes of FLIP-398
Key: FLINK-36905
URL: https://issues.apache.org/jira/browse/FLINK-36905
Project: Flink
flinkbot commented on PR #25799:
URL: https://github.com/apache/flink/pull/25799#issuecomment-2544634558
## CI report:
* b712aa2a841e8ef2114ecfaa06cc26668628204c UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
chenyuzhi459 commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1886236906
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##
@@ -264,15 +278,21 @@ protected void initChannel(SocketChannel socketChannel) {
chenyuzhi459 commented on code in PR #25788:
URL: https://github.com/apache/flink/pull/25788#discussion_r1886236906
##
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java:
##
@@ -264,15 +278,21 @@ protected void initChannel(SocketChannel socketChannel) {
RocMarshal closed pull request #25737: Flink 33387 33388 draft1 for CI
URL: https://github.com/apache/flink/pull/25737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
67 matches
Mail list logo
