Re: [PR] [FLINK-33470] Implement restore tests for Join node [flink]

2023-12-05 Thread via GitHub
dawidwys commented on code in PR #23869: URL: https://github.com/apache/flink/pull/23869#discussion_r1416038404 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java: ## @@ -107,7 +107,7 @@ public class Jo

[jira] [Commented] (FLINK-24237) Consider disabling or lowering DNS caching timeout in docker image

2023-12-05 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793381#comment-17793381 ] Salva commented on FLINK-24237: --- Are there any news? Can someone confirm any plans for wor

[jira] [Comment Edited] (FLINK-24237) Consider disabling or lowering DNS caching timeout in docker image

2023-12-05 Thread Salva (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793381#comment-17793381 ] Salva edited comment on FLINK-24237 at 12/5/23 6:17 PM: Are ther

[jira] [Created] (FLINK-33756) Missing record with CUMULATE/HOP windows using an optimization

2023-12-05 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33756: -- Summary: Missing record with CUMULATE/HOP windows using an optimization Key: FLINK-33756 URL: https://issues.apache.org/jira/browse/FLINK-33756 Project: Flink I

[jira] [Updated] (FLINK-33756) Missing record with CUMULATE/HOP windows using an optimization

2023-12-05 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Hughes updated FLINK-33756: --- Description: I have seen an optimization cause a window fail to emit a record. With the optimizatio

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-12-05 Thread via GitHub
gyfora commented on code in PR #712: URL: https://github.com/apache/flink-kubernetes-operator/pull/712#discussion_r1416192622 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java: ## @@ -1075,4 +1106,59 @@ protected v

Re: [PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.17) [flink]

2023-12-05 Thread via GitHub
dannycranmer merged PR #23841: URL: https://github.com/apache/flink/pull/23841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.18) [flink]

2023-12-05 Thread via GitHub
dannycranmer merged PR #23840: URL: https://github.com/apache/flink/pull/23840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [docs][hotfix] Update AWS connector docs to v4.2 (Flink 1.19) [flink]

2023-12-05 Thread via GitHub
dannycranmer merged PR #23839: URL: https://github.com/apache/flink/pull/23839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1841618310 @cuibo01 @MartijnVisser I just run into this issue (Flink 1.17) and was happy to find this PR. Any reason this stalled? Can I help get this to the finish line? -- This is an automated m

[jira] [Created] (FLINK-33757) Implement restore tests for Rank node

2023-12-05 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33757: -- Summary: Implement restore tests for Rank node Key: FLINK-33757 URL: https://issues.apache.org/jira/browse/FLINK-33757 Project: Flink Issue Type: Sub-task

[PR] [FLINK-33757] Implement restore tests for Rank node [flink]

2023-12-05 Thread via GitHub
jnh5y opened a new pull request, #23878: URL: https://github.com/apache/flink/pull/23878 ## What is the purpose of the change Implement restore tests for Rank node ## Verifying this change This change added tests and can be verified as follows: * Added restore test

[jira] [Updated] (FLINK-33757) Implement restore tests for Rank node

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33757: --- Labels: pull-request-available (was: ) > Implement restore tests for Rank node > --

Re: [PR] [FLINK-33757] Implement restore tests for Rank node [flink]

2023-12-05 Thread via GitHub
flinkbot commented on PR #23878: URL: https://github.com/apache/flink/pull/23878#issuecomment-1841752000 ## CI report: * 0c6402b8f833df3a05a60b4a5d0fbbc15ae55cda UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-33758) Implement restore tests for TemporalSort node

2023-12-05 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33758: -- Summary: Implement restore tests for TemporalSort node Key: FLINK-33758 URL: https://issues.apache.org/jira/browse/FLINK-33758 Project: Flink Issue Type: Sub-tas

[jira] [Assigned] (FLINK-33758) Implement restore tests for TemporalSort node

2023-12-05 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Hughes reassigned FLINK-33758: -- Assignee: Jim Hughes > Implement restore tests for TemporalSort node > --

[PR] [FLINK-33758] Implement restore tests for TemporalSort node [flink]

2023-12-05 Thread via GitHub
jnh5y opened a new pull request, #23879: URL: https://github.com/apache/flink/pull/23879 ## What is the purpose of the change Implement restore tests for TemporalSort node ## Verifying this change This change added tests and can be verified as follows: * Added rest

[jira] [Updated] (FLINK-33758) Implement restore tests for TemporalSort node

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33758: --- Labels: pull-request-available (was: ) > Implement restore tests for TemporalSort node > --

Re: [PR] [FLINK-33758] Implement restore tests for TemporalSort node [flink]

2023-12-05 Thread via GitHub
flinkbot commented on PR #23879: URL: https://github.com/apache/flink/pull/23879#issuecomment-1841777502 ## CI report: * 3a3ae47704eb419e33eb8ffc643c83f83befcb43 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-12-05 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793457#comment-17793457 ] Mason Chen commented on FLINK-33545: The reason why you don't find any synchronizati

[jira] [Comment Edited] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2023-12-05 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793457#comment-17793457 ] Mason Chen edited comment on FLINK-33545 at 12/5/23 11:40 PM:

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-05 Thread via GitHub
zhengzhili333 closed pull request #23866: [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation URL: https://github.com/apache/flink/pull/23866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
cuibo01 commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1841927134 @tweise , Of course you can, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (FLINK-33724) Application mode doesn't support multiple lines argument

2023-12-05 Thread Jiaxing Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793478#comment-17793478 ] Jiaxing Chen commented on FLINK-33724: -- Noticed that this issue has been mentioned

[jira] [Closed] (FLINK-33724) Application mode doesn't support multiple lines argument

2023-12-05 Thread Jiaxing Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiaxing Chen closed FLINK-33724. Resolution: Done > Application mode doesn't support multiple lines argument >

[jira] [Updated] (FLINK-25593) A redundant scan could be skipped if it is an input of join and the other input is empty after partition prune

2023-12-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-25593: - Fix Version/s: 1.19.0 > A redundant scan could be skipped if it is an input of join and the other > inp

[jira] [Reopened] (FLINK-25593) A redundant scan could be skipped if it is an input of join and the other input is empty after partition prune

2023-12-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reopened FLINK-25593: -- > A redundant scan could be skipped if it is an input of join and the other > input is empty after partit

[jira] [Closed] (FLINK-25593) A redundant scan could be skipped if it is an input of join and the other input is empty after partition prune

2023-12-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-25593. Resolution: Fixed > A redundant scan could be skipped if it is an input of join and the other > input is

Re: [PR] [FLINK-33691] Support agg push down for 'count(*)/count(1)/count(column not null)' [flink]

2023-12-05 Thread via GitHub
swuferhong commented on code in PR #23828: URL: https://github.com/apache/flink/pull/23828#discussion_r1416555940 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/PushLocalSortAggWithSortAndCalcIntoScanRule.java: ## @@ -85

Re: [PR] [FLINK-33691] Support agg push down for 'count(*)/count(1)/count(column not null)' [flink]

2023-12-05 Thread via GitHub
swuferhong commented on code in PR #23828: URL: https://github.com/apache/flink/pull/23828#discussion_r1416564050 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/PushLocalSortAggWithCalcIntoScanRule.java: ## @@ -74,9 +74,

Re: [PR] [FLINK-33713][core] Deprecate RuntimeContext#getExecutionConfig [flink]

2023-12-05 Thread via GitHub
zhuzhurk commented on code in PR #23848: URL: https://github.com/apache/flink/pull/23848#discussion_r1416568345 ## flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java: ## @@ -83,10 +86,27 @@ public AbstractRuntimeUDFContext( }

Re: [PR] [FLINK-33713][core] Deprecate RuntimeContext#getExecutionConfig [flink]

2023-12-05 Thread via GitHub
zhuzhurk commented on code in PR #23848: URL: https://github.com/apache/flink/pull/23848#discussion_r1416568345 ## flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java: ## @@ -83,10 +86,27 @@ public AbstractRuntimeUDFContext( }

Re: [PR] [FLINK-33726][sql-client] print time cost for streaming queries [flink]

2023-12-05 Thread via GitHub
fsk119 commented on code in PR #23868: URL: https://github.com/apache/flink/pull/23868#discussion_r1416572012 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java: ## @@ -114,6 +108,30 @@ public void displayResults() throws Sq

Re: [PR] [FLINK-33691] Support agg push down for 'count(*)/count(1)/count(column not null)' [flink]

2023-12-05 Thread via GitHub
swuferhong commented on code in PR #23828: URL: https://github.com/apache/flink/pull/23828#discussion_r1416573713 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/batch/PushLocalSortAggWithSortAndCalcIntoScanRule.java: ## @@ -94

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1841996519 @cuibo01 thanks, I resolved conflicts and pushed the merge for testing - will do a rebase after we see tests pass. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-05 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416588553 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java: ## @@ -59,4 +59,7 @@ public interface ResultProvider { *

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-05 Thread via GitHub
zoudan commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416588553 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ResultProvider.java: ## @@ -59,4 +59,7 @@ public interface ResultProvider { *

Re: [PR] [FLINK-33710] Prevent triggering cluster upgrades for permutations of the same overrides [flink-kubernetes-operator]

2023-12-05 Thread via GitHub
1996fanrui commented on code in PR #721: URL: https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1416590912 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizerTest.java: ## @@ -30,12 +31,23 @

[jira] [Closed] (FLINK-31659) java.lang.ClassNotFoundException: org.apache.flink.table.planner.delegation.DialectFactory when bundled Hive connector jar is in classpath

2023-12-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-31659. Fix Version/s: 1.18.0 Resolution: Invalid Should be fixed after https://issues.apache.org/jira/brow

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-05 Thread via GitHub
luoyuxia commented on code in PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#discussion_r1416565534 ## flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java: ## @@ -0,0 +1,1000 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-05 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793488#comment-17793488 ] Yue Ma commented on FLINK-27681: [~masteryhx] [~pnowojski] [~fanrui]  Thanks for the dis

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-12-05 Thread via GitHub
luoyuxia commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1842010718 @snuyanzin Hi, I also found some pages(https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/hive-compatibility/hive-dialect/overview/ , https://nightlies.apache.o

[jira] [Resolved] (FLINK-24819) Higher APIServer cpu load after using SharedIndexInformer replaced naked Kubernetes watch

2023-12-05 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-24819. -- Resolution: Fixed > Higher APIServer cpu load after using SharedIndexInformer replaced naked > Kubern

[jira] [Updated] (FLINK-24819) Higher APIServer cpu load after using SharedIndexInformer replaced naked Kubernetes watch

2023-12-05 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-24819: - Fix Version/s: 1.19.0 1.18.1 1.17.3 > Higher APIServer cpu load af

[jira] [Commented] (FLINK-32028) Error handling for the new Elasticsearch sink

2023-12-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793492#comment-17793492 ] Weijie Guo commented on FLINK-32028: Thanks for taking this, I will take a look at t

[jira] [Assigned] (FLINK-32028) Error handling for the new Elasticsearch sink

2023-12-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-32028: -- Assignee: Peter Schulz > Error handling for the new Elasticsearch sink >

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1842026548 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1842032773 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-05 Thread via GitHub
zhengzhili333 opened a new pull request, #23880: URL: https://github.com/apache/flink/pull/23880 ## What is the purpose of the change *Currently, submitting a job starts with storing the JobGraph (in HA setups) in the JobGraphStore. This includes writing the file to S3 (or some other

Re: [PR] [FLINK-33502][network] Prevent DiskTierProducerAgent#getSegmentIdByIndexOfFirstBufferInSegment from throwing NPE when the task is released [flink]

2023-12-05 Thread via GitHub
WencongLiu commented on PR #23863: URL: https://github.com/apache/flink/pull/23863#issuecomment-1842037511 > Thanks for the update, I'm + 1 for this one. Could you please also align commit message with the title of this PR. Done. -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33713][core] Deprecate RuntimeContext#getExecutionConfig [flink]

2023-12-05 Thread via GitHub
JunRuiLee commented on PR #23848: URL: https://github.com/apache/flink/pull/23848#issuecomment-1842040305 Hi @zhuzhurk , thanks for your feedback. I have updated the pull request based on your comments. Please take a look when you have a moment. -- This is an automated message from the Ap

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-05 Thread via GitHub
flinkbot commented on PR #23880: URL: https://github.com/apache/flink/pull/23880#issuecomment-1842042843 ## CI report: * db9949a710f0dcf6d317053732a0e96b75568944 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Reopened] (FLINK-25857) Add committer metrics to track the status of committables

2023-12-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reopened FLINK-25857: Re-open this per discuss in mail-list. > Add committer metrics to track the status of committables >

[jira] [Commented] (FLINK-27291) Translate the "List of Data Types" section of "Data Types" in to Chinese

2023-12-05 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793496#comment-17793496 ] 韩宏旭 commented on FLINK-27291: - Hey Chengkai Yang,Cason I am experienced in flink. I have se

[jira] (FLINK-27291) Translate the "List of Data Types" section of "Data Types" in to Chinese

2023-12-05 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-27291 ] 韩宏旭 deleted comment on FLINK-27291: - was (Author: maomao): Hey Chengkai Yang,Cason I am experienced in flink. I have seen this issue is created at 18/Apr/22 19:51 and Updated at 27/Mar/23 11:34. It

[jira] [Commented] (FLINK-27291) Translate the "List of Data Types" section of "Data Types" in to Chinese

2023-12-05 Thread hongxu han (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793497#comment-17793497 ] hongxu han commented on FLINK-27291: Hey Chengkai Yang,Cason I am experienced in fl

[jira] (FLINK-27291) Translate the "List of Data Types" section of "Data Types" in to Chinese

2023-12-05 Thread hongxu han (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27291 ] hongxu han deleted comment on FLINK-27291: was (Author: maomao): Hey Chengkai Yang,Cason I am experienced in flink. I have seen this issue is created at 18/Apr/22 19:51 and Updated at 27/Ma

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-05 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793505#comment-17793505 ] Zakelly Lan commented on FLINK-33734: - hi [~Feifan Wang] ,   I'm wondering if this

Re: [PR] [FLINK-33752][Configuration] Change the displayed timeunit to day when the duration is an integral multiple of 1 day [flink]

2023-12-05 Thread via GitHub
1996fanrui merged PR #23873: URL: https://github.com/apache/flink/pull/23873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Created] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
Cai Liuyang created FLINK-33759: --- Summary: flink parquet writer support write nested array or map type Key: FLINK-33759 URL: https://issues.apache.org/jira/browse/FLINK-33759 Project: Flink Is

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-33759: Description: When we use flink-parquet format wirte Map[] type (which will be read by spark job),

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-33759: Description: When we use flink-parquet format wirte Map[] type (which will be read by spark job),

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-33759: Description: When we use flink-parquet format wirte Map[] type (which will be read by spark job),

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-33759: Description: When we use flink-parquet format wirte Map[] type (which will be read by spark job),

[jira] [Commented] (FLINK-33752) When Duration is greater than or equal to 1 day, the display unit is ms.

2023-12-05 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793517#comment-17793517 ] Rui Fan commented on FLINK-33752: - Merged to master<1.19> via: 9b61b137bdc7eff773847b84

[jira] [Resolved] (FLINK-33752) When Duration is greater than or equal to 1 day, the display unit is ms.

2023-12-05 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33752. - Resolution: Fixed > When Duration is greater than or equal to 1 day, the display unit is ms. > -

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread Cai Liuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cai Liuyang updated FLINK-33759: Description: When we use flink-parquet format wirte Map[] type (which will be read by spark job),

Re: [PR] Draft FLINK-32898 [CI] [flink]

2023-12-05 Thread via GitHub
caodizhou commented on PR #23842: URL: https://github.com/apache/flink/pull/23842#issuecomment-1842126287 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [FLINK-33759] flink parquet writer support write nested array or map type [flink]

2023-12-05 Thread via GitHub
LoveHeat opened a new pull request, #23881: URL: https://github.com/apache/flink/pull/23881 ## What is the purpose of the change see: [FLINK-33759](https://issues.apache.org/jira/browse/FLINK-33759) ## Brief change log *(for example:)* - *The TaskInfo is

[jira] [Updated] (FLINK-33759) flink parquet writer support write nested array or map type

2023-12-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33759: --- Labels: pull-request-available (was: ) > flink parquet writer support write nested array or

Re: [PR] [FLINK-33759] flink parquet writer support write nested array or map type [flink]

2023-12-05 Thread via GitHub
flinkbot commented on PR #23881: URL: https://github.com/apache/flink/pull/23881#issuecomment-1842150254 ## CI report: * beeb17b4d54d2c2ed0ea61df6e07892bc792e2e0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-33760) Group Window agg has different result when only consuming -D records while using or not using minibatch

2023-12-05 Thread xuyang (Jira)
xuyang created FLINK-33760: -- Summary: Group Window agg has different result when only consuming -D records while using or not using minibatch Key: FLINK-33760 URL: https://issues.apache.org/jira/browse/FLINK-33760

Re: [PR] [FLINK-33666][table] Use the same constraint name in MergeTableLikeUtil and Schema [flink]

2023-12-05 Thread via GitHub
jeyhunkarimov commented on PR #23877: URL: https://github.com/apache/flink/pull/23877#issuecomment-1842153994 Hi @twalthr could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[PR] [hotfix][test] Migrate JsonRowDeserializationSchemaTest/JsonRowSerializationSchemaTest to Junit5 and Assertj [flink]

2023-12-05 Thread via GitHub
swuferhong opened a new pull request, #23882: URL: https://github.com/apache/flink/pull/23882 ## What is the purpose of the change When reading the code about json format, I found the test classes `JsonRowDeserializationSchemaTest` and `JsonRowSerializationSchemaTest`

Re: [PR] [hotfix][test] Migrate JsonRowDeserializationSchemaTest/JsonRowSerializationSchemaTest to Junit5 and Assertj [flink]

2023-12-05 Thread via GitHub
flinkbot commented on PR #23882: URL: https://github.com/apache/flink/pull/23882#issuecomment-1842175348 ## CI report: * bf391fd5e7547df3e574138b264cb7802f150c62 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp [flink]

2023-12-05 Thread via GitHub
tweise commented on PR #18304: URL: https://github.com/apache/flink/pull/18304#issuecomment-1842179446 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-05 Thread via GitHub
xiangforever2014 commented on code in PR #23253: URL: https://github.com/apache/flink/pull/23253#discussion_r1416745308 ## flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java: ## @@ -188,6 +207,21 @@ CompletableFuture triggerSavepoint( */ Co

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-05 Thread via GitHub
xiangforever2014 commented on PR #23253: URL: https://github.com/apache/flink/pull/23253#issuecomment-1842188948 > Hi @xiangforever2014 @masteryhx sorry for jumping in... And I'm wondering if we could use the capital '-D' for short option? Or I suggest we do not leave any short option for t

[jira] [Created] (FLINK-33761) Snowflake as JDBC source

2023-12-05 Thread Boris Litvak (Jira)
Boris Litvak created FLINK-33761: Summary: Snowflake as JDBC source Key: FLINK-33761 URL: https://issues.apache.org/jira/browse/FLINK-33761 Project: Flink Issue Type: Bug Reporter

[jira] [Updated] (FLINK-33761) Snowflake as JDBC source

2023-12-05 Thread Boris Litvak (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Litvak updated FLINK-33761: - Issue Type: New Feature (was: Bug) > Snowflake as JDBC source > > >

[jira] [Updated] (FLINK-33761) Snowflake as JDBC source

2023-12-05 Thread Boris Litvak (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Litvak updated FLINK-33761: - Description: Following [https://flink.apache.org/how-to-contribute/contribute-code/,] I can con

[jira] [Updated] (FLINK-33761) Snowflake as JDBC source

2023-12-05 Thread Boris Litvak (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Litvak updated FLINK-33761: - Component/s: Connectors / JDBC > Snowflake as JDBC source > > >

[jira] [Updated] (FLINK-33761) Snowflake as JDBC source

2023-12-05 Thread Boris Litvak (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Litvak updated FLINK-33761: - Description: Following [https://flink.apache.org/how-to-contribute/contribute-code/,] I would l

Re: [PR] Draft FLINK-32898 [CI] [flink]

2023-12-05 Thread via GitHub
caodizhou commented on PR #23842: URL: https://github.com/apache/flink/pull/23842#issuecomment-1842266742 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-33266][sql-gateway] Support plan cache for DQL in SQL Gateway [flink]

2023-12-05 Thread via GitHub
libenchao commented on code in PR #23849: URL: https://github.com/apache/flink/pull/23849#discussion_r1416754135 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/SessionContext.java: ## @@ -136,6 +158,10 @@ public URLClassLoader getUs

<    1   2