luoyuxia commented on code in PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#discussion_r1416565534
########## flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSinkITCase.java: ########## @@ -0,0 +1,1000 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connectors.hive; + +import org.apache.flink.FlinkVersion; +import org.apache.flink.api.common.restartstrategy.RestartStrategies; +import org.apache.flink.api.common.typeinfo.Types; +import org.apache.flink.api.java.typeutils.RowTypeInfo; +import org.apache.flink.connector.file.table.FileSystemConnectorOptions; +import org.apache.flink.core.fs.Path; +import org.apache.flink.streaming.api.datastream.DataStream; +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment; +import org.apache.flink.streaming.util.FiniteTestSource; +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.api.ExplainDetail; +import org.apache.flink.table.api.Expressions; +import org.apache.flink.table.api.Schema; +import org.apache.flink.table.api.SqlDialect; +import org.apache.flink.table.api.Table; +import org.apache.flink.table.api.TableEnvironment; +import org.apache.flink.table.api.bridge.java.StreamTableEnvironment; +import org.apache.flink.table.catalog.CatalogPartitionSpec; +import org.apache.flink.table.catalog.ObjectPath; +import org.apache.flink.table.catalog.hive.HiveCatalog; +import org.apache.flink.table.catalog.hive.HiveTestUtils; +import org.apache.flink.table.catalog.stats.CatalogTableStatistics; +import org.apache.flink.types.Row; +import org.apache.flink.util.CloseableIterator; +import org.apache.flink.util.CollectionUtil; +import org.apache.flink.util.TestLoggerExtension; + +import org.apache.flink.shaded.guava31.com.google.common.collect.Lists; + +import org.apache.hadoop.hive.conf.HiveConf; +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; + +import java.io.File; +import java.io.IOException; +import java.net.URI; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.time.ZoneId; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.Comparator; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.function.Consumer; + +import static org.apache.flink.connector.file.table.FileSystemConnectorOptions.PARTITION_TIME_EXTRACTOR_TIMESTAMP_PATTERN; +import static org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_DELAY; +import static org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_POLICY_CLASS; +import static org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_POLICY_KIND; +import static org.apache.flink.connector.file.table.FileSystemConnectorOptions.SINK_PARTITION_COMMIT_SUCCESS_FILE_NAME; +import static org.apache.flink.table.api.Expressions.$; +import static org.apache.flink.table.planner.utils.TableTestUtil.readFromResource; +import static org.apache.flink.table.planner.utils.TableTestUtil.replaceNodeIdInOperator; +import static org.apache.flink.table.planner.utils.TableTestUtil.replaceStageId; +import static org.apache.flink.table.planner.utils.TableTestUtil.replaceStreamNodeId; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatCode; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +/** Tests {@link HiveTableSink}. */ +@ExtendWith(TestLoggerExtension.class) +class HiveTableSinkITCase { + + private static HiveCatalog hiveCatalog; + + @BeforeAll + static void createCatalog() { + hiveCatalog = HiveTestUtils.createHiveCatalog(); + hiveCatalog.open(); + } + + @AfterAll + static void closeCatalog() { + if (hiveCatalog != null) { + hiveCatalog.close(); + } + } + + @Test + void testHiveTableSinkWithParallelismInBatch() throws Exception { + final TableEnvironment tEnv = HiveTestUtils.createTableEnvInBatchMode(SqlDialect.HIVE); + testHiveTableSinkWithParallelismBase( + tEnv, "/explain/testHiveTableSinkWithParallelismInBatch.out"); + } + + @Test + void testHiveTableSinkWithParallelismInStreaming() throws Exception { + final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment(); + final TableEnvironment tEnv = + HiveTestUtils.createTableEnvInStreamingMode(env, SqlDialect.HIVE); + // see https://issues.apache.org/jira/browse/FLINK-32620 + String expectedResourceFileName = + FlinkVersion.current() == FlinkVersion.v1_18 + ? "/explain/testHiveTableSinkWithParallelismInStreaming18.out" + : "/explain/testHiveTableSinkWithParallelismInStreaming.out"; + testHiveTableSinkWithParallelismBase(tEnv, expectedResourceFileName); + } + + private void testHiveTableSinkWithParallelismBase( + final TableEnvironment tEnv, final String expectedResourceFileName) throws Exception { + tEnv.registerCatalog(hiveCatalog.getName(), hiveCatalog); + tEnv.useCatalog(hiveCatalog.getName()); + if (FlinkVersion.current() == FlinkVersion.v1_18) { Review Comment: nit: Seems like there some code ducplicated in here and in line [154](https://github.com/apache/flink-connector-hive/pull/5/files#diff-d854ec6577a7ee748c98aef66fc72a22f8059929c8c2851be8d2c7ba234d6803R154). Can they share a common code fragment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
