xiangforever2014 commented on code in PR #23253:
URL: https://github.com/apache/flink/pull/23253#discussion_r1416745308
##########
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java:
##########
@@ -188,6 +207,21 @@ CompletableFuture<String> triggerSavepoint(
*/
CompletableFuture<Long> triggerCheckpoint(JobID jobId, CheckpointType
checkpointType);
+ /**
+ * Triggers a detached savepoint for the job identified by the job id. The
savepoint will be
+ * written to the given savepoint directory, or {@link
+ *
org.apache.flink.configuration.CheckpointingOptions#SAVEPOINT_DIRECTORY} if it
is null.
+ * Notice that: detach savepoint will return with a savepoint trigger id
instead of the path
+ * future, that means the client will return very quickly.
+ *
+ * @param jobId job id
+ * @param savepointDirectory directory the savepoint should be written to
+ * @param formatType a binary format of the savepoint
+ * @return The savepoint trigger id
+ */
+ CompletableFuture<String> triggerDetachSavepoint(
Review Comment:
Thanks for your comment, sorry but I want to ensure that this means we
should implement `stopWithDetachedSavepoint` by invoking
`triggerDetachedSavepoint`? Or we should abstract an interface which is
responsible for implementing normal detached savepoint and
stop-with-detached-savepoint? I think currently it is clear that we use two
different function to trigger savepoint in detached mode, that is
`triggerDetachSavepoint` & `stopWithDetachedSavepoint`, do you want to merge
these two into one function? Hope to get your opinion~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
