[jira] [Created] (FLINK-33464) JoinITCase.testRightOuterJoin failed due to heartbeat timeout

2023-11-06 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33464: - Summary: JoinITCase.testRightOuterJoin failed due to heartbeat timeout Key: FLINK-33464 URL: https://issues.apache.org/jira/browse/FLINK-33464 Project: Flink

[jira] [Updated] (FLINK-33464) JoinITCase.testRightOuterJoin failed due to heartbeat timeout

2023-11-06 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33464: -- Description: https://github.com/XComp/flink/actions/runs/6756936036/job/18367079822#step:12:11

[jira] [Created] (FLINK-33465) Make SingleThreadFetcherManager and FutureCompletingBlockingQueue as PublicEvolving.

2023-11-06 Thread Hongshun Wang (Jira)
Hongshun Wang created FLINK-33465: - Summary: Make SingleThreadFetcherManager and FutureCompletingBlockingQueue as PublicEvolving. Key: FLINK-33465 URL: https://issues.apache.org/jira/browse/FLINK-33465

[jira] [Assigned] (FLINK-33437) Flink 1.17 sink commited legacy Committable state, but it was not removed from state backend

2023-11-06 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu reassigned FLINK-33437: Assignee: Yuchi Duan > Flink 1.17 sink commited legacy Committable state, but it was not

[jira] [Commented] (FLINK-33437) Flink 1.17 sink commited legacy Committable state, but it was not removed from state backend

2023-11-06 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783134#comment-17783134 ] Hangxiang Yu commented on FLINK-33437: -- [~dyccode] Thanks for reporting this. Alre

[jira] [Commented] (FLINK-33465) Make SingleThreadFetcherManager and FutureCompletingBlockingQueue as PublicEvolving.

2023-11-06 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783135#comment-17783135 ] Hongshun Wang commented on FLINK-33465: --- [~becket_qin] , [~renqs] , [~Leonard] , [

[jira] [Updated] (FLINK-33465) Make SingleThreadFetcherManager and FutureCompletingBlockingQueue as PublicEvolving.

2023-11-06 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-33465: -- Description: As discussed in FLINK-31324, though the {{SingleThreadFetcherManager}} is annota

[jira] [Updated] (FLINK-33465) Make SingleThreadFetcherManager and FutureCompletingBlockingQueue as PublicEvolving.

2023-11-06 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-33465: -- Description: As discussed in FLINK-31324, though the {{SingleThreadFetcherManager}} is annota

Re: [PR] [FLINK-33147] Introduce endpoint field in REST API and deprecate host field [flink]

2023-11-06 Thread via GitHub
X-czh commented on PR #23465: URL: https://github.com/apache/flink/pull/23465#issuecomment-1794328075 Thanks @huwh for the comments. I've rebased the PR onto master and addressed the comments. Could you review it again when you have time? -- This is an automated message from the Apache Gi

[jira] [Updated] (FLINK-33465) Make SingleThreadFetcherManager and FutureCompletingBlockingQueue as PublicEvolving.

2023-11-06 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-33465: -- Description: As discussed in FLINK-31324, though the {{SingleThreadFetcherManager}} is annota

Re: [PR] [FLINK-33262][table-api] Extend source provider interfaces with the new parallelism provider interface [flink]

2023-11-06 Thread via GitHub
X-czh commented on PR #23663: URL: https://github.com/apache/flink/pull/23663#issuecomment-1794330120 @libenchao Could you help review it when you have time? Many thanks in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-31481][table] Support enhanced show databases syntax [flink]

2023-11-06 Thread via GitHub
jeyhunkarimov commented on PR #23612: URL: https://github.com/apache/flink/pull/23612#issuecomment-1794335092 Hi @MartijnVisser could you please check this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FLINK-32986][test] Fix createTemporaryFunction type inference error [flink]

2023-11-06 Thread via GitHub
jeyhunkarimov commented on PR #23586: URL: https://github.com/apache/flink/pull/23586#issuecomment-1794335640 Hi @MartijnVisser could you please check this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FLINK-18286][table] Port type inference for collection types [flink]

2023-11-06 Thread via GitHub
dawidwys closed pull request #19468: [FLINK-18286][table] Port type inference for collection types URL: https://github.com/apache/flink/pull/19468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-18286] Implement type inference for functions on composite types [flink]

2023-11-06 Thread via GitHub
dawidwys merged PR #23622: URL: https://github.com/apache/flink/pull/23622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Closed] (FLINK-18286) Implement type inference for functions on composite types

2023-11-06 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-18286. Fix Version/s: 1.19.0 Resolution: Fixed Implemented in fa8ea3f9a443f555de5c5479d725

Re: [PR] [FLINK-18286][table] Port type inference for collection types [flink]

2023-11-06 Thread via GitHub
dawidwys commented on PR #19468: URL: https://github.com/apache/flink/pull/19468#issuecomment-1794342810 Subsumed by fa8ea3f9a443f555de5c5479d725e16befefc957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-06 Thread via GitHub
masteryhx commented on PR #23239: URL: https://github.com/apache/flink/pull/23239#issuecomment-1794343153 > Hi @masteryhx , thank you for the review again, I also synced my fork with the upstream, if that was what you meant by 'Could you also rebase all your commits to the master ?' BTW: re

[PR] Update checkpoint_monitoring.md [flink]

2023-11-06 Thread via GitHub
luyizhizaio opened a new pull request, #23672: URL: https://github.com/apache/flink/pull/23672 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring the

Re: [PR] Update checkpoint_monitoring.md [flink]

2023-11-06 Thread via GitHub
luyizhizaio closed pull request #23672: Update checkpoint_monitoring.md URL: https://github.com/apache/flink/pull/23672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Update checkpoint_monitoring.md [flink]

2023-11-06 Thread via GitHub
flinkbot commented on PR #23672: URL: https://github.com/apache/flink/pull/23672#issuecomment-1794364189 ## CI report: * 4212897c705b945e57f8f60ed7f7353e8af4b89d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31275) Flink supports reporting and storage of source/sink tables relationship

2023-11-06 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783147#comment-17783147 ] Fang Yong commented on FLINK-31275: --- Hi [~mobuchowski] Thanks for your reply. I think

[jira] [Comment Edited] (FLINK-31275) Flink supports reporting and storage of source/sink tables relationship

2023-11-06 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783147#comment-17783147 ] Fang Yong edited comment on FLINK-31275 at 11/6/23 9:17 AM:

Re: [PR] [FLINK-33257][connectors/mongodb] Support filter pushdown in MongoDB connector [flink-connector-mongodb]

2023-11-06 Thread via GitHub
Jiabao-Sun commented on PR #17: URL: https://github.com/apache/flink-connector-mongodb/pull/17#issuecomment-1794389313 Hi @leonardBang, sorry for the CI failure. Please help trigger the CI again. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] [FLINK-33057] Add options to disable creating job-id subdirectories under the checkpoint directory [flink]

2023-11-06 Thread via GitHub
masteryhx commented on code in PR #23509: URL: https://github.com/apache/flink/pull/23509#discussion_r1382969491 ## flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java: ## @@ -228,6 +228,32 @@ public class CheckpointingOptions {

[jira] [Commented] (FLINK-27114) On JM restart, the information about the initial checkpoints can be lost

2023-11-06 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783164#comment-17783164 ] Zakelly Lan commented on FLINK-27114: - Hi [~roman] I'm revisiting this ticket and FL

[jira] [Commented] (FLINK-33401) Kafka connector has broken version

2023-11-06 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783166#comment-17783166 ] Yuxin Tan commented on FLINK-33401: --- [~pavelhp] I noticed that it has been released. Y

[PR] [FLINK-33164][docs] Add document for the write option sink.ignore-null-value [flink-connector-hbase]

2023-11-06 Thread via GitHub
Tan-JiaLiang opened a new pull request, #31: URL: https://github.com/apache/flink-connector-hbase/pull/31 Add document for the write option sink.ignore-null-value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-06 Thread via GitHub
gaborgsomogyi commented on PR #689: URL: https://github.com/apache/flink-kubernetes-operator/pull/689#issuecomment-1794492192 Hi @tagarr ! Thanks for your efforts! Before we go deeply in the feature I would like to understand the problem statement clearly. If I understand correctly then th

Re: [PR] [FLINK-33164][docs] Add document for the write option sink.ignore-null-value [flink-connector-hbase]

2023-11-06 Thread via GitHub
Tan-JiaLiang commented on PR #31: URL: https://github.com/apache/flink-connector-hbase/pull/31#issuecomment-1794503253 @ferenc-csaky @MartijnVisser Sorry my mentor, I realized that [[FLINK-33164] Support write option sink.ignore-null-value](https://github.com/apache/flink-connector-hbase/

[jira] [Commented] (FLINK-33401) Kafka connector has broken version

2023-11-06 Thread Pavel Khokhlov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783174#comment-17783174 ] Pavel Khokhlov commented on FLINK-33401: [~tanyuxin] thank you! I will take a lo

[jira] [Updated] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-7: --- Description: Remaining open PRs: https://github.com/facebook/rocksdb/pull/11646 ~https://gi

[jira] [Updated] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-7: --- Description: Remaining open PRs: https://github.com/facebook/rocksdb/pull/11646 -https://gi

[jira] [Updated] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-11-06 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-7: --- Description: Remaining open PRs: https://github.com/facebook/rocksdb/pull/11646 Already me

[PR] [FLINK-33437][connectors] SinkV2 clear legacy state [flink]

2023-11-06 Thread via GitHub
dyccode opened a new pull request, #23673: URL: https://github.com/apache/flink/pull/23673 ## What is the purpose of the change Flink SinkV2 commited legacy Committable state, but it was not removed from state backend. ## Brief change log SinkV2 clear legacy state org/a

[jira] [Updated] (FLINK-33437) Flink 1.17 sink commited legacy Committable state, but it was not removed from state backend

2023-11-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33437: --- Labels: pull-request-available (was: ) > Flink 1.17 sink commited legacy Committable state,

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-06 Thread via GitHub
tagarr commented on PR #689: URL: https://github.com/apache/flink-kubernetes-operator/pull/689#issuecomment-1794577724 Thats correct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33437][connectors] SinkV2 clear legacy state [flink]

2023-11-06 Thread via GitHub
flinkbot commented on PR #23673: URL: https://github.com/apache/flink/pull/23673#issuecomment-1794580001 ## CI report: * 24e2d35cf0d35941ef7d999083cb221f24f1c8ba UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-33466) Bounded Kafka source never finishes after restore from savepoint

2023-11-06 Thread Jonas Weile (Jira)
Jonas Weile created FLINK-33466: --- Summary: Bounded Kafka source never finishes after restore from savepoint Key: FLINK-33466 URL: https://issues.apache.org/jira/browse/FLINK-33466 Project: Flink

Re: [PR] [FLINK-32650][protobuf]Added the ability to split flink-protobuf code… [flink]

2023-11-06 Thread via GitHub
libenchao commented on PR #23162: URL: https://github.com/apache/flink/pull/23162#issuecomment-1794633947 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-33428) Flink SQL CEP support 'followed','notNext' and 'notFollowedBy' semantics

2023-11-06 Thread xiaoran (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783194#comment-17783194 ] xiaoran commented on FLINK-33428: - [~martijnvisser] hi,I have already sent a [discuss] e

[jira] [Created] (FLINK-33467) Support concurrent serialization in akka

2023-11-06 Thread dizhou cao (Jira)
dizhou cao created FLINK-33467: -- Summary: Support concurrent serialization in akka Key: FLINK-33467 URL: https://issues.apache.org/jira/browse/FLINK-33467 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-33428] Flink SQL CEP support 'followed','notNext' and 'notFollowedBy' semantics [flink]

2023-11-06 Thread via GitHub
ValjeanShaw commented on PR #23646: URL: https://github.com/apache/flink/pull/23646#issuecomment-1794659702 > Like I've commented in the Jira ticket, I think we should first have discussion on the Dev mailing list and perhaps even a FLIP on the mailing list. This does look really promising.

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-06 Thread via GitHub
gaborgsomogyi commented on PR #689: URL: https://github.com/apache/flink-kubernetes-operator/pull/689#issuecomment-1794673038 Then why not simply mounting `/etc/tls/` in the operator and put certs in the proper dir? I mean one can add configs like: ``` security.ssl.enabled: 'tr

Re: [PR] [FLINK-26585][state-processor-api] replace implementation of MultiStateKeyIterator with Stream-free implementation [flink]

2023-11-06 Thread via GitHub
RainerMatthiasS commented on PR #23239: URL: https://github.com/apache/flink/pull/23239#issuecomment-1794694360 > > Hi @masteryhx , thank you for the review again, I also synced my fork with the upstream, if that was what you meant by 'Could you also rebase all your commits to the master ?'

Re: [PR] [FLINK-28050][connectors] Migrate StreamExecutionEnvironment#fromElements() implementation to FLIP-27 Source API [flink]

2023-11-06 Thread via GitHub
afedulov commented on PR #23553: URL: https://github.com/apache/flink/pull/23553#issuecomment-1794701474 @zentol thanks for the feedback. The only remaining item currently is the [architecture tests failures](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=54352&view=

[jira] [Assigned] (FLINK-33467) Support concurrent serialization in akka

2023-11-06 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo reassigned FLINK-33467: -- Assignee: dizhou cao > Support concurrent serialization in akka > ---

[jira] [Commented] (FLINK-33376) Add AuthInfo config option for Zookeeper configuration

2023-11-06 Thread Oleksandr Nitavskyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783220#comment-17783220 ] Oleksandr Nitavskyi commented on FLINK-33376: - Thanks for the detailed listi

Re: [PR] [FLINK-32563] Allow to execute archunit tests only with Flink version that connectors were built against [flink-connector-shared-utils]

2023-11-06 Thread via GitHub
echauchot commented on code in PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1383402031 ## .github/workflows/ci.yml: ## @@ -88,6 +93,10 @@ jobs: if: ${{ inputs.run_dependency_convergence }} run: echo "MVN_DEPENDENCY_C

Re: [PR] [FLINK-32563] Allow to execute archunit tests only with Flink version that connectors were built against [flink-connector-shared-utils]

2023-11-06 Thread via GitHub
echauchot commented on PR #23: URL: https://github.com/apache/flink-connector-shared-utils/pull/23#issuecomment-1794939589 > @zentol I fixed the PR: mainly separated dep convergence checks and archunit tests. > > I have also simulated an archunit violation with the behavior of the ji

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-06 Thread via GitHub
tagarr commented on PR #689: URL: https://github.com/apache/flink-kubernetes-operator/pull/689#issuecomment-1794978019 @gaborgsomogyi Thanks for looking at this. So the problem is that user declared flinkdeployments could specify the cert directory wherever they want to, I didn't want to

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-06 Thread via GitHub
dawidwys commented on code in PR #23660: URL: https://github.com/apache/flink/pull/23660#discussion_r1383475759 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-06 Thread via GitHub
dawidwys commented on code in PR #23660: URL: https://github.com/apache/flink/pull/23660#discussion_r1383476953 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java: ## @@ -0,0 +1,109 @@ +/* + * Licensed

Re: [PR] [FLINK-31599] Update kafka version to 3.4.0 [flink-connector-kafka]

2023-11-06 Thread via GitHub
jm-paulin commented on PR #11: URL: https://github.com/apache/flink-connector-kafka/pull/11#issuecomment-1795171922 Is there a chance to revive this PR? We are on link 1.18 and tried to force Kafka 3.4.0 (because of CVE) and hit that error: ``` 2023-11-06 15:19:58 java.lang.Runtime

Re: [PR] [FLINK-33437][connectors] SinkV2 clear legacy state [flink]

2023-11-06 Thread via GitHub
dyccode closed pull request #23673: [FLINK-33437][connectors] SinkV2 clear legacy state URL: https://github.com/apache/flink/pull/23673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [FLINK-31599] Update kafka version to 3.4.0 [flink-connector-kafka]

2023-11-06 Thread via GitHub
Ge commented on PR #11: URL: https://github.com/apache/flink-connector-kafka/pull/11#issuecomment-1795338757 This patch was merged in f970dd7 and should be available since the connector version 3.0.0. -- This is an automated message from the Apache Git Service. To respond to the mess

[jira] [Assigned] (FLINK-30593) Determine restart time on the fly for Autoscaler

2023-11-06 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov reassigned FLINK-30593: - Assignee: Alexander Fedulov > Determine restart time on the fly for Autoscaler

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-11-06 Thread via GitHub
gyfora commented on code in PR #23490: URL: https://github.com/apache/flink/pull/23490#discussion_r1383614529 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java: ## @@ -89,6 +89,10 @@ public final class PojoSerializer extends TypeSeriali

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-11-06 Thread via GitHub
gyfora commented on code in PR #23490: URL: https://github.com/apache/flink/pull/23490#discussion_r1383627567 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java: ## @@ -473,25 +519,41 @@ public T deserialize(T reuse, DataInputView source)

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-11-06 Thread via GitHub
gyfora commented on code in PR #23490: URL: https://github.com/apache/flink/pull/23490#discussion_r1383628349 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java: ## @@ -473,25 +519,41 @@ public T deserialize(T reuse, DataInputView source)

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-11-06 Thread via GitHub
gyfora commented on code in PR #23490: URL: https://github.com/apache/flink/pull/23490#discussion_r1383632966 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java: ## @@ -400,21 +444,23 @@ public T deserialize(DataInputView source) throws

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-11-06 Thread via GitHub
XComp commented on code in PR #23490: URL: https://github.com/apache/flink/pull/23490#discussion_r1383635290 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java: ## @@ -473,25 +519,41 @@ public T deserialize(T reuse, DataInputView source)

[PR] [FLINK-33437][connector] SinkV2 clear legacy state [flink]

2023-11-06 Thread via GitHub
dyccode opened a new pull request, #23674: URL: https://github.com/apache/flink/pull/23674 ## What is the purpose of the change This pull request clears the legacy state of Sinkv2. ## Brief change log SinkV2 clears legacy states after initialization. ## Verifying t

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-11-06 Thread via GitHub
gyfora commented on code in PR #23490: URL: https://github.com/apache/flink/pull/23490#discussion_r1383650850 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java: ## @@ -473,25 +519,41 @@ public T deserialize(T reuse, DataInputView source)

Re: [PR] [FLINK-33437][connector] SinkV2 clear legacy state [flink]

2023-11-06 Thread via GitHub
dyccode commented on PR #23674: URL: https://github.com/apache/flink/pull/23674#issuecomment-1795480027 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33437][connector] SinkV2 clear legacy state [flink]

2023-11-06 Thread via GitHub
flinkbot commented on PR #23674: URL: https://github.com/apache/flink/pull/23674#issuecomment-1795482536 ## CI report: * e9d1ae3410540dca565f612b73b6bb25becc8d7b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-33468) Run Kubernetes IT test fails due to wrong Maven version

2023-11-06 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33468: - Summary: Run Kubernetes IT test fails due to wrong Maven version Key: FLINK-33468 URL: https://issues.apache.org/jira/browse/FLINK-33468 Project: Flink Iss

[jira] [Commented] (FLINK-25420) Port JDBC Source to new Source API (FLIP-27)

2023-11-06 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-25420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783286#comment-17783286 ] João Boto commented on FLINK-25420: --- Sounds good [~RocMarshal] > Port JDBC Source to

Re: [PR] [FLINK-31599] Update kafka version to 3.4.0 [flink-connector-kafka]

2023-11-06 Thread via GitHub
jm-paulin commented on PR #11: URL: https://github.com/apache/flink-connector-kafka/pull/11#issuecomment-1795517028 Right, that's also what I thought. so I added the dependecy: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-06 Thread via GitHub
bvarghese1 commented on code in PR #23660: URL: https://github.com/apache/flink/pull/23660#discussion_r1383682230 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java: ## @@ -0,0 +1,109 @@ +/* + * License

Re: [PR] [FLINK-33455] Implement restore tests for SortLimit node [flink]

2023-11-06 Thread via GitHub
bvarghese1 commented on code in PR #23660: URL: https://github.com/apache/flink/pull/23660#discussion_r1383682889 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/SortTestPrograms.java: ## @@ -0,0 +1,109 @@ +/* + * License

[jira] [Commented] (FLINK-33458) Add env.java.opts.gateway option in flink-conf.yaml

2023-11-06 Thread Sharath Avadoot Gururaj (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783289#comment-17783289 ] Sharath Avadoot Gururaj commented on FLINK-33458: - Wow nice! thanks a lo

[jira] [Resolved] (FLINK-33458) Add env.java.opts.gateway option in flink-conf.yaml

2023-11-06 Thread Sharath Avadoot Gururaj (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sharath Avadoot Gururaj resolved FLINK-33458. - Resolution: Fixed > Add env.java.opts.gateway option in flink-conf.yaml

[jira] [Resolved] (FLINK-33285) e2e 1 stage: Wordcount on Docker test (custom fs plugin)

2023-11-06 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-33285. --- Resolution: Fixed This issue was actually caused by the e2e tests running in a container. Mo

Re: [PR] [FLINK-31599] Update kafka version to 3.4.0 [flink-connector-kafka]

2023-11-06 Thread via GitHub
tzulitai commented on PR #11: URL: https://github.com/apache/flink-connector-kafka/pull/11#issuecomment-1795559991 @jm-paulin Kafka version upgrade to 3.4.x is not part of the 3.0.x Kafka connector series. We're treating it as a major new feature and would only come with a new 3.1.x

Re: [PR] [FLINK-33099][autoscaler] Introduce the Standalone Autoscaler and support flink cluster [flink-kubernetes-operator]

2023-11-06 Thread via GitHub
gyfora commented on code in PR #698: URL: https://github.com/apache/flink-kubernetes-operator/pull/698#discussion_r1383701572 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/LoggableEventHandler.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Softwa

Re: [PR] [Flink 31966] Flink Kubernetes operator lacks TLS support [flink-kubernetes-operator]

2023-11-06 Thread via GitHub
gaborgsomogyi commented on PR #689: URL: https://github.com/apache/flink-kubernetes-operator/pull/689#issuecomment-1795575344 Please see my comments inline: > So the problem is that user declared flinkdeployments could specify the cert directory wherever they want to, I didn't want t

Re: [PR] [FLINK-29452] Allow unit tests to be executed independently [flink]

2023-11-06 Thread via GitHub
RyanSkraba commented on PR #21289: URL: https://github.com/apache/flink/pull/21289#issuecomment-1795602499 Rebased and squashed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-31599] Update kafka version to 3.4.0 [flink-connector-kafka]

2023-11-06 Thread via GitHub
jm-paulin commented on PR #11: URL: https://github.com/apache/flink-connector-kafka/pull/11#issuecomment-1795602705 Ah, that explains @tzulitai. thanks you! We are looking at moving to Kafka 3.4.0 early next year (Jan 2024). This upgrade is driven by [CVE-2023-25194](https://www.men

Re: [PR] [FLINK-33437][connector] SinkV2 clear legacy state [flink]

2023-11-06 Thread via GitHub
dyccode commented on PR #23674: URL: https://github.com/apache/flink/pull/23674#issuecomment-1795734309 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-32902) Docs creation and checks in multiple locations

2023-11-06 Thread ZY tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17783336#comment-17783336 ] ZY tang commented on FLINK-32902: - [~mapohl]  > Docs creation and checks in multiple lo

[jira] (FLINK-32902) Docs creation and checks in multiple locations

2023-11-06 Thread ZY tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32902 ] ZY tang deleted comment on FLINK-32902: - was (Author: JIRAUSER302551): [~mapohl]  > Docs creation and checks in multiple locations > -- > >

[jira] [Comment Edited] (FLINK-32902) Docs creation and checks in multiple locations

2023-11-06 Thread ZY tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17782804#comment-17782804 ] ZY tang edited comment on FLINK-32902 at 11/6/23 6:54 PM: -- [~ma

Re: [PR] [FLINK-31599] Update kafka version to 3.4.0 [flink-connector-kafka]

2023-11-06 Thread via GitHub
tzulitai commented on PR #11: URL: https://github.com/apache/flink-connector-kafka/pull/11#issuecomment-1796185531 @jm-paulin I think we can definitely do a 3.1.x release before that. Given the CVE it would make sense to do this sooner as well. First step would be to start a thread in dev

[jira] [Created] (FLINK-33469) Implement restore tests for Limit node

2023-11-06 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33469: -- Summary: Implement restore tests for Limit node Key: FLINK-33469 URL: https://issues.apache.org/jira/browse/FLINK-33469 Project: Flink Issue Type: Sub-task

[PR] [FLINK-33469] Implement restore tests for Limit node [flink]

2023-11-06 Thread via GitHub
jnh5y opened a new pull request, #23675: URL: https://github.com/apache/flink/pull/23675 ## What is the purpose of the change Implement restore tests for Limit node ## Verifying this change This change added tests and can be verified as follows: * Added restore tes

[jira] [Updated] (FLINK-33469) Implement restore tests for Limit node

2023-11-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33469: --- Labels: pull-request-available (was: ) > Implement restore tests for Limit node >

Re: [PR] [FLINK-33469] Implement restore tests for Limit node [flink]

2023-11-06 Thread via GitHub
flinkbot commented on PR #23675: URL: https://github.com/apache/flink/pull/23675#issuecomment-1796380778 ## CI report: * 58a68c00e76272dac969ca389f705f612b7517bf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-06 Thread via GitHub
jnh5y commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1383949729 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java: ## @@ -242,6 +245,139 @@ public static boolean hasWellD

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-06 Thread via GitHub
jnh5y commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1383951328 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java: ## @@ -242,6 +245,139 @@ public static boolean hasWellD

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-06 Thread via GitHub
jnh5y commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1383961004 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SubQueryInputTypeStrategy.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-06 Thread via GitHub
jnh5y commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1383965282 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/expressions/subquery.scala: ## @@ -1,78 +0,0 @@ -/* - * Licensed to the Apache Software F

Re: [PR] [FLINK-33439] Implement type inference for IN function [flink]

2023-11-06 Thread via GitHub
jnh5y commented on code in PR #23652: URL: https://github.com/apache/flink/pull/23652#discussion_r1383978823 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/strategies/SubQueryInputTypeStrategyTest.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed

[jira] [Updated] (FLINK-33466) Bounded Kafka source never finishes after restore from savepoint

2023-11-06 Thread Jonas Weile (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonas Weile updated FLINK-33466: Description: When setting up a bounded Kafka source, if the job is restored from a savepoint befo

[jira] [Updated] (FLINK-33466) Bounded Kafka source never finishes after restore from savepoint

2023-11-06 Thread Jonas Weile (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonas Weile updated FLINK-33466: Description: When setting up a bounded Kafka source, if the job is restored from a savepoint befo

[jira] [Updated] (FLINK-33466) Bounded Kafka source never finishes after restore from savepoint

2023-11-06 Thread Jonas Weile (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonas Weile updated FLINK-33466: Component/s: Connectors / Common (was: Connectors / Kafka)

[jira] [Created] (FLINK-33470) Implement restore tests for Join node

2023-11-06 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-33470: -- Summary: Implement restore tests for Join node Key: FLINK-33470 URL: https://issues.apache.org/jira/browse/FLINK-33470 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-11-06 Thread via GitHub
gyfora commented on PR #23490: URL: https://github.com/apache/flink/pull/23490#issuecomment-1796954415 Updated the PR @XComp , I did not address the test naming question because I can't reply to it, I think it's fine to distinguish by prefix. -- This is an automated message from the Apach

[jira] [Created] (FLINK-33471) Kubernetes operator supports compiling with Java 21

2023-11-06 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33471: --- Summary: Kubernetes operator supports compiling with Java 21 Key: FLINK-33471 URL: https://issues.apache.org/jira/browse/FLINK-33471 Project: Flink Iss

[PR] [FLINK-33471] Make flink kubernetes opeartor compilable with jdk21 [flink-kubernetes-operator]

2023-11-06 Thread via GitHub
snuyanzin opened a new pull request, #701: URL: https://github.com/apache/flink-kubernetes-operator/pull/701 ## What is the purpose of the change The PR is aiming to support compilation with java 21 Since spotless and google java format needs to be updated to work with java 21

  1   2   >