gyfora commented on code in PR #23490:
URL: https://github.com/apache/flink/pull/23490#discussion_r1383650850


##########
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializer.java:
##########
@@ -473,25 +519,41 @@ public T deserialize(T reuse, DataInputView source) 
throws IOException {
             }
         }
 
-        if ((flags & NO_SUBCLASS) != 0) {
+        if (isRecord) {

Review Comment:
   oh yea you are right, I will actually revery my deserialise refactor, to 
avoid this unintended change. 
   
   I will not do this refactoring now. The consumers in theory can solve this 
but I suspect there will be an intended performance hit. I also don't want to 
spend investigating that too much. Will open a follow up ticket.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to