[GitHub] flink issue #2430: [FLINK-3874] Rewrite Kafka JSON Table sink tests

2016-09-29 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2430 Hi @fhueske Thank you for your review. I've updated my PR accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-3874) Add a Kafka TableSink with JSON serialization

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532104#comment-15532104 ] ASF GitHub Bot commented on FLINK-3874: --- Github user mushketyk commented on the issu

[jira] [Commented] (FLINK-3656) Rework Table API tests

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532117#comment-15532117 ] ASF GitHub Bot commented on FLINK-3656: --- Github user asfgit closed the pull request

[GitHub] flink pull request #2563: [FLINK-3656] [table] Reduce number of ITCases

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2563 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (FLINK-4707) Including flink-connector-filesystem as dependency fails build

2016-09-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler resolved FLINK-4707. - Resolution: Duplicate This issue should already be fixed in master. If this is not the cas

[jira] [Commented] (FLINK-4706) Is there a way to load user classes first?

2016-09-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532125#comment-15532125 ] Chesnay Schepler commented on FLINK-4706: - Please direct questions to the mailing

[GitHub] flink pull request #2546: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-09-29 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2546#discussion_r81088167 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultTimeServiceProvider.java --- @@ -99,7 +100,7 @@ public void run() {

[jira] [Commented] (FLINK-4329) Fix Streaming File Source Timestamps/Watermarks Handling

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532167#comment-15532167 ] ASF GitHub Bot commented on FLINK-4329: --- Github user kl0u commented on a diff in the

[jira] [Commented] (FLINK-4704) Move Table API to org.apache.flink.table

2016-09-29 Thread Liwei Lin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532176#comment-15532176 ] Liwei Lin commented on FLINK-4704: -- +1 on this! > Move Table API to org.apache.flink.tab

[GitHub] flink pull request #2546: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-09-29 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2546#discussion_r81089031 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/DefaultTimeServiceProvider.java --- @@ -99,7 +100,7 @@ public void run() {

[jira] [Commented] (FLINK-4329) Fix Streaming File Source Timestamps/Watermarks Handling

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532181#comment-15532181 ] ASF GitHub Bot commented on FLINK-4329: --- Github user kl0u commented on a diff in the

[GitHub] flink pull request #2559: [FLINK-4702] [kafka connector] Commit offets to Ka...

2016-09-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2559#discussion_r81089161 --- Diff: flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java --- @@

[jira] [Commented] (FLINK-4702) Kafka consumer must commit offsets asynchronously

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532184#comment-15532184 ] ASF GitHub Bot commented on FLINK-4702: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-4707) Including flink-connector-filesystem as dependency fails build

2016-09-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1553#comment-1553 ] Stephan Ewen commented on FLINK-4707: - I think the root cause of the recently added mi

[jira] [Created] (FLINK-4708) Scope Mini Kerberos Cluster dependencies as test dependencies

2016-09-29 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4708: --- Summary: Scope Mini Kerberos Cluster dependencies as test dependencies Key: FLINK-4708 URL: https://issues.apache.org/jira/browse/FLINK-4708 Project: Flink Is

[jira] [Created] (FLINK-4709) InputStreamFSInputWrapper does not close wrapped stream

2016-09-29 Thread Holger Frydrych (JIRA)
Holger Frydrych created FLINK-4709: -- Summary: InputStreamFSInputWrapper does not close wrapped stream Key: FLINK-4709 URL: https://issues.apache.org/jira/browse/FLINK-4709 Project: Flink Iss

[jira] [Commented] (FLINK-4709) InputStreamFSInputWrapper does not close wrapped stream

2016-09-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532237#comment-15532237 ] Stephan Ewen commented on FLINK-4709: - Good catch. Do you want to open a pull request

[jira] [Created] (FLINK-4710) Remove transitive Guice dependency from Hadoop

2016-09-29 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4710: --- Summary: Remove transitive Guice dependency from Hadoop Key: FLINK-4710 URL: https://issues.apache.org/jira/browse/FLINK-4710 Project: Flink Issue Type: Bug

[GitHub] flink issue #2435: [FLINK-4478] [flip-6] Add HeartbeatManager

2016-09-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2435 I've rebased the PR on the latest Flip-6 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[jira] [Commented] (FLINK-4478) Implement heartbeat logic

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532273#comment-15532273 ] ASF GitHub Bot commented on FLINK-4478: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2520: [FLINK-4530] [Distributed Coordination] Generalize TaskEx...

2016-09-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2520 I think we can close this PR. Could you please do this @zhuhaifengleon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[jira] [Commented] (FLINK-4530) Generalize TaskExecutorToResourceManagerConnection to be reusable

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532295#comment-15532295 ] ASF GitHub Bot commented on FLINK-4530: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-09-29 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532305#comment-15532305 ] Anton Mushin commented on FLINK-4563: - Ok this case if we get f1 in method we must ret

[jira] [Commented] (FLINK-3656) Rework Table API tests

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532332#comment-15532332 ] ASF GitHub Bot commented on FLINK-3656: --- GitHub user twalthr opened a pull request:

[GitHub] flink pull request #2566: [FLINK-3656] [table] Consolidate ITCases

2016-09-29 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2566 [FLINK-3656] [table] Consolidate ITCases This PR merges ITCases that are belong together logically. It also ensures that all tests extend from TableProgramsTest base. It reduces the build t

[GitHub] flink pull request #2520: [FLINK-4530] [Distributed Coordination] Generalize...

2016-09-29 Thread zhuhaifengleon
Github user zhuhaifengleon closed the pull request at: https://github.com/apache/flink/pull/2520 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-09-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532338#comment-15532338 ] Chesnay Schepler commented on FLINK-4563: - that looks about right. > [metrics] sc

[jira] [Commented] (FLINK-4530) Generalize TaskExecutorToResourceManagerConnection to be reusable

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532339#comment-15532339 ] ASF GitHub Bot commented on FLINK-4530: --- Github user zhuhaifengleon closed the pull

[jira] [Comment Edited] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-09-29 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532305#comment-15532305 ] Anton Mushin edited comment on FLINK-4563 at 9/29/16 9:54 AM: --

[jira] [Commented] (FLINK-4563) [metrics] scope caching not adjusted for multiple reporters

2016-09-29 Thread Anton Mushin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532355#comment-15532355 ] Anton Mushin commented on FLINK-4563: - Thanks. Then I will wait resolution of PR http

[jira] [Commented] (FLINK-4709) InputStreamFSInputWrapper does not close wrapped stream

2016-09-29 Thread Holger Frydrych (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532401#comment-15532401 ] Holger Frydrych commented on FLINK-4709: Gladly. I'll try to do it on the weekend,

[GitHub] flink issue #2542: [FLINK-4613] [ml] Extend ALS to handle implicit feedback ...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on the issue: https://github.com/apache/flink/pull/2542 Hi @thvasilo, thanks for reviewing my code. You are right, @jfeher told me that the numbers in the left column indicate the number of non-zero elements in the rating matrix. We are actua

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532406#comment-15532406 ] ASF GitHub Bot commented on FLINK-4613: --- Github user gaborhermann commented on the i

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532472#comment-15532472 ] ASF GitHub Bot commented on FLINK-4613: --- Github user gaborhermann commented on a dif

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81112516 --- Diff: docs/dev/libs/ml/als.md --- @@ -49,6 +49,21 @@ By applying this step alternately to the matrices $U$ and $V$, we can iterativel The

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81112526 --- Diff: docs/dev/libs/ml/als.md --- @@ -99,6 +114,26 @@ The alternating least squares implementation can be controlled by the following

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532473#comment-15532473 ] ASF GitHub Bot commented on FLINK-4613: --- Github user gaborhermann commented on a dif

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81112771 --- Diff: docs/dev/libs/ml/als.md --- @@ -99,6 +114,26 @@ The alternating least squares implementation can be controlled by the following

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532478#comment-15532478 ] ASF GitHub Bot commented on FLINK-4613: --- Github user gaborhermann commented on a dif

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532501#comment-15532501 ] ASF GitHub Bot commented on FLINK-4613: --- Github user gaborhermann commented on a dif

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81114406 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -581,6 +637,16 @@ object ALS { val us

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81115229 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/recommendation/ImplicitALSTest.scala --- @@ -0,0 +1,171 @@ +/* + * License

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532517#comment-15532517 ] ASF GitHub Bot commented on FLINK-4613: --- Github user gaborhermann commented on a dif

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81115301 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/recommendation/ImplicitALSTest.scala --- @@ -0,0 +1,171 @@ +/* + * License

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532520#comment-15532520 ] ASF GitHub Bot commented on FLINK-4613: --- Github user gaborhermann commented on a dif

[GitHub] flink issue #2542: [FLINK-4613] [ml] Extend ALS to handle implicit feedback ...

2016-09-29 Thread gaborhermann
Github user gaborhermann commented on the issue: https://github.com/apache/flink/pull/2542 I did some minor changes according to user suggestions, and put it in a separate commit (Minor fixes in IALS), so you can see my fixes. Note that before merging I'd prefer to squash the commit w

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532527#comment-15532527 ] ASF GitHub Bot commented on FLINK-4613: --- Github user gaborhermann commented on the i

[GitHub] flink issue #2560: [FLINK-4068] [table] Move constant computations out of co...

2016-09-29 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2560 Hi @twalthr , I have updated this PR , could you have a look again ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532576#comment-15532576 ] ASF GitHub Bot commented on FLINK-4068: --- Github user wuchong commented on the issue:

[GitHub] flink pull request #2565: [FLINK-4406] [cluster management] Implement job ma...

2016-09-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2565#discussion_r81122520 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -457,14 +505,88 @@ public Acknowledge updateTaskExecutio

[jira] [Commented] (FLINK-4406) Implement job master registration at resource manager

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532614#comment-15532614 ] ASF GitHub Bot commented on FLINK-4406: --- Github user tillrohrmann commented on a dif

[GitHub] flink issue #2565: [FLINK-4406] [cluster management] Implement job master re...

2016-09-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2565 Changes look good to me. +1 for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[jira] [Commented] (FLINK-4406) Implement job master registration at resource manager

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532617#comment-15532617 ] ASF GitHub Bot commented on FLINK-4406: --- Github user tillrohrmann commented on the i

[jira] [Commented] (FLINK-4329) Fix Streaming File Source Timestamps/Watermarks Handling

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532622#comment-15532622 ] ASF GitHub Bot commented on FLINK-4329: --- Github user kl0u commented on the issue:

[GitHub] flink issue #2546: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...

2016-09-29 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2546 Thanks for the comments @StephanEwen and @aljoscha ! I integrated most of them. Please have a look. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Closed] (FLINK-4708) Scope Mini Kerberos Cluster dependencies as test dependencies

2016-09-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4708. --- > Scope Mini Kerberos Cluster dependencies as test dependencies >

[jira] [Resolved] (FLINK-4710) Remove transitive Guice dependency from Hadoop

2016-09-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-4710. - Resolution: Fixed Fixed via 84af0b90ec81bbe2af73a56cc0483166314a492a > Remove transitive Guice de

[jira] [Resolved] (FLINK-4708) Scope Mini Kerberos Cluster dependencies as test dependencies

2016-09-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-4708. - Resolution: Fixed Fixed via 8243138c3ffb0849a7150d3c2df56eaffccd8d75 > Scope Mini Kerberos Cluste

[jira] [Closed] (FLINK-4710) Remove transitive Guice dependency from Hadoop

2016-09-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4710. --- > Remove transitive Guice dependency from Hadoop > -- > >

[GitHub] flink issue #2512: [FLINK-4379] Rescalable non-partitioned state

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2512 Had an in-depth code walkthrough with @StefanRRichter - comments are addresses as additional commits. Comments: - Use `StateDescriptor` as well for operator state - For the `s

[jira] [Commented] (FLINK-4379) Add Rescalable Non-Partitioned State

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532698#comment-15532698 ] ASF GitHub Bot commented on FLINK-4379: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-4706) Is there a way to load user classes first?

2016-09-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532710#comment-15532710 ] Stephan Ewen commented on FLINK-4706: - You can try and put the user JAR into the "lib"

[jira] [Commented] (FLINK-4706) Is there a way to load user classes first?

2016-09-29 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532711#comment-15532711 ] Stephan Ewen commented on FLINK-4706: - What dependencies are clashing for you? > Is t

[GitHub] flink issue #2557: [FLINK-3734] Close stream state handles after state resto...

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2557 There is a big change to the internal state life cycle coming up: #2512 Could you have a look whether the problem you found still exists in that code? --- If your project is set up fo

[jira] [Commented] (FLINK-3734) Unclosed DataInputView in AbstractAlignedProcessingTimeWindowOperator#restoreState()

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532722#comment-15532722 ] ASF GitHub Bot commented on FLINK-3734: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-4573) Potential resource leak due to unclosed RandomAccessFile in TaskManagerLogHandler

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532724#comment-15532724 ] ASF GitHub Bot commented on FLINK-4573: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2556: [FLINK-4573] Fix potential resource leak due to unclosed ...

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2556 I think this is good to merge... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #2559: [FLINK-4702] [kafka connector] Commit offets to Kafka asy...

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2559 @tzulitai Thanks for thorough review! I don't understand the problem why the `commitSpecificOffsetsToKafka` method is designed to commit synchronously. The `FlinkKafkaConsumerBase` has t

[jira] [Commented] (FLINK-4702) Kafka consumer must commit offsets asynchronously

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532771#comment-15532771 ] ASF GitHub Bot commented on FLINK-4702: --- Github user StephanEwen commented on the is

[GitHub] flink pull request #2565: [FLINK-4406] [cluster management] Implement job ma...

2016-09-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2565#discussion_r81135329 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -457,14 +505,94 @@ public Acknowledge updateTaskExecutionState(Ta

[jira] [Commented] (FLINK-4406) Implement job master registration at resource manager

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532781#comment-15532781 ] ASF GitHub Bot commented on FLINK-4406: --- Github user mxm commented on a diff in the

[jira] [Commented] (FLINK-4406) Implement job master registration at resource manager

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532782#comment-15532782 ] ASF GitHub Bot commented on FLINK-4406: --- Github user mxm commented on a diff in the

[GitHub] flink pull request #2565: [FLINK-4406] [cluster management] Implement job ma...

2016-09-29 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2565#discussion_r81134995 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -457,14 +505,94 @@ public Acknowledge updateTaskExecutionState(Ta

[GitHub] flink pull request #2565: [FLINK-4406] [cluster management] Implement job ma...

2016-09-29 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2565#discussion_r81139389 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -457,14 +505,94 @@ public Acknowledge updateTaskExecutionSt

[jira] [Commented] (FLINK-4406) Implement job master registration at resource manager

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532810#comment-15532810 ] ASF GitHub Bot commented on FLINK-4406: --- Github user KurtYoung commented on a diff i

[GitHub] flink pull request #2566: [FLINK-3656] [table] Consolidate ITCases

2016-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2566 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-3656) Rework Table API tests

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532818#comment-15532818 ] ASF GitHub Bot commented on FLINK-3656: --- Github user asfgit closed the pull request

[GitHub] flink pull request #2565: [FLINK-4406] [cluster management] Implement job ma...

2016-09-29 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/2565#discussion_r81141545 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java --- @@ -457,14 +505,94 @@ public Acknowledge updateTaskExecutionSt

[jira] [Commented] (FLINK-4406) Implement job master registration at resource manager

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532836#comment-15532836 ] ASF GitHub Bot commented on FLINK-4406: --- Github user KurtYoung commented on a diff i

[GitHub] flink issue #2565: [FLINK-4406] [cluster management] Implement job master re...

2016-09-29 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/2565 Thanks for the review @tillrohrmann @mxm , both of you raised some very good points. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[jira] [Commented] (FLINK-4406) Implement job master registration at resource manager

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532876#comment-15532876 ] ASF GitHub Bot commented on FLINK-4406: --- Github user KurtYoung commented on the issu

[GitHub] flink pull request #2567: [FLINK-3656] [table] Convert expression tests to u...

2016-09-29 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/2567 [FLINK-3656] [table] Convert expression tests to unit tests This PR replaces 6 ITCases with unit tests in `ScalarOperatorsTest`. It reduces the build time by about 10 seconds. You can merge

[jira] [Commented] (FLINK-3656) Rework Table API tests

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532882#comment-15532882 ] ASF GitHub Bot commented on FLINK-3656: --- GitHub user twalthr opened a pull request:

[GitHub] flink issue #2559: [FLINK-4702] [kafka connector] Commit offets to Kafka asy...

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2559 Actually, just discovered that the problem is different all together. While the KafkaConsumer is polling for new data (with a timeout), it holds the consumer lock. If no data comes in Kaf

[jira] [Commented] (FLINK-4702) Kafka consumer must commit offsets asynchronously

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532900#comment-15532900 ] ASF GitHub Bot commented on FLINK-4702: --- Github user StephanEwen commented on the is

[GitHub] flink pull request #2568: [FLINK-4636] Add boundary check for priorityqueue ...

2016-09-29 Thread jaxbihani
GitHub user jaxbihani opened a pull request: https://github.com/apache/flink/pull/2568 [FLINK-4636] Add boundary check for priorityqueue for cep operator Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into considerati

[jira] [Commented] (FLINK-4636) AbstractCEPPatternOperator fails to restore state

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532937#comment-15532937 ] ASF GitHub Bot commented on FLINK-4636: --- GitHub user jaxbihani opened a pull request

[jira] [Created] (FLINK-4711) TaskManager can crash due to failing onPartitionStateUpdate call

2016-09-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4711: Summary: TaskManager can crash due to failing onPartitionStateUpdate call Key: FLINK-4711 URL: https://issues.apache.org/jira/browse/FLINK-4711 Project: Flink

[GitHub] flink issue #2560: [FLINK-4068] [table] Move constant computations out of co...

2016-09-29 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2560 Thanks for updating the PR @wuchong. I found a little bug, but I will fix it myself and merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532959#comment-15532959 ] ASF GitHub Bot commented on FLINK-4068: --- Github user twalthr commented on the issue:

[GitHub] flink pull request #2569: [FLINK-4711] Let the Task trigger partition state ...

2016-09-29 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/2569 [FLINK-4711] Let the Task trigger partition state requests and handle their responses This PR makes changes the partition state check in a way that the Task is now responsible for triggeri

[jira] [Commented] (FLINK-4711) TaskManager can crash due to failing onPartitionStateUpdate call

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532964#comment-15532964 ] ASF GitHub Bot commented on FLINK-4711: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #2568: [FLINK-4636] Add boundary check for priorityqueue ...

2016-09-29 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2568#discussion_r81155827 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractCEPPatternOperator.java --- @@ -126,11 +126,12 @@ public void resto

[jira] [Commented] (FLINK-4636) AbstractCEPPatternOperator fails to restore state

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533001#comment-15533001 ] ASF GitHub Bot commented on FLINK-4636: --- Github user greghogan commented on a diff i

[jira] [Updated] (FLINK-4636) AbstractCEPPatternOperator fails to restore state

2016-09-29 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-4636: - Assignee: Jagadish Bihani > AbstractCEPPatternOperator fails to restore state > --

[jira] [Assigned] (FLINK-4678) Add SessionRow row-windows for streaming tables (FLIP-11)

2016-09-29 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-4678: --- Assignee: Timo Walther > Add SessionRow row-windows for streaming tables (FLIP-11) >

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81159171 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -581,6 +637,16 @@ object ALS { val userXy

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533024#comment-15533024 ] ASF GitHub Bot commented on FLINK-4613: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81159482 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/recommendation/ImplicitALSTest.scala --- @@ -0,0 +1,171 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15533029#comment-15533029 ] ASF GitHub Bot commented on FLINK-4613: --- Github user thvasilo commented on a diff in

  1   2   3   >