[ https://issues.apache.org/jira/browse/FLINK-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532724#comment-15532724 ]
ASF GitHub Bot commented on FLINK-4573: --------------------------------------- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2556 I think this is good to merge... > Potential resource leak due to unclosed RandomAccessFile in > TaskManagerLogHandler > --------------------------------------------------------------------------------- > > Key: FLINK-4573 > URL: https://issues.apache.org/jira/browse/FLINK-4573 > Project: Flink > Issue Type: Bug > Reporter: Ted Yu > Priority: Minor > > {code} > try { > raf = new > RandomAccessFile(file, "r"); > } catch > (FileNotFoundException e) { > display(ctx, request, > "Displaying TaskManager log failed."); > LOG.error("Displaying > TaskManager log failed.", e); > return; > } > long fileLength = > raf.length(); > final FileChannel fc = > raf.getChannel(); > {code} > If length() throws IOException, raf would be left unclosed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)