[
https://issues.apache.org/jira/browse/FLINK-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356732#comment-15356732
]
ASF GitHub Bot commented on FLINK-3943:
---
Github user mushketyk commented on the issu
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2169
@fhueske Thank you for the detailed review! I've updated my code according
to your comments.
I noticed that @wuchong is performing some type conversions in his
INTERSECT implementation:
h
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2146
Hmm what about using the `JobID` to disambiguate jobs with the same name?
I cannot remember whether this peculiarity concerning the job naming is
documented or not. If not, then it shoul
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356745#comment-15356745
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user tillrohrmann commented on the i
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r69093616
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to th
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356747#comment-15356747
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2158#discussion_r69093837
--- Diff: docs/apis/common/index.md ---
@@ -1350,3 +1350,397 @@ You may specify program arguments before the job is
executed. The plan visualiza
the
[
https://issues.apache.org/jira/browse/FLINK-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356750#comment-15356750
]
ASF GitHub Bot commented on FLINK-4116:
---
Github user tillrohrmann commented on a dif
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2146
What is this discussion about; changing the default format or finding a
general way to avoid naming collisions?
---
If your project is set up for it, you can reply to this email and have your
reply a
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356758#comment-15356758
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user zentol commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356759#comment-15356759
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user zentol commented on a diff in t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r69094834
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apac
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2146
For clarification: including the JobID is exactly what the user is supposed
to do when he runs multiple jobs with the same name.
The current scope format is designed to provide the most readab
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356781#comment-15356781
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user zentol commented on the issue:
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2187
I moved one existing environment variable `FLINK_CONF_DIR` to
`ConfigConstants`. I added the `FLINK_LIB_DIR` environment variable to load a
library folder (optional). I'm not sure whether we should add t
[
https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356784#comment-15356784
]
ASF GitHub Bot commented on FLINK-3675:
---
Github user mxm commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356791#comment-15356791
]
ASF GitHub Bot commented on FLINK-3675:
---
Github user mxm commented on the issue:
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2187
All builds are passing in my branch:
https://travis-ci.org/mxm/flink/builds/141155293
CC @rmetzger
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2174#discussion_r69100533
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -334,9 +342,11 @@ publ
[
https://issues.apache.org/jira/browse/FLINK-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356808#comment-15356808
]
ASF GitHub Bot commented on FLINK-4075:
---
Github user rmetzger commented on a diff in
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r69101854
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -132,9 +132,9 @@
- private final Configuration confi
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2149
Thanks for the update. We're getting there :) Great work so far!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356819#comment-15356819
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356817#comment-15356817
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r69101922
--- Diff: flink-dist/src/main/flink-bin/bin/flink ---
@@ -17,20 +17,41 @@
# limitations under the License.
#
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356820#comment-15356820
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356822#comment-15356822
]
ASF GitHub Bot commented on FLINK-4118:
---
Github user aljoscha commented on a diff in
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2176#discussion_r69102159
--- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
@@ -16,21 +18,23 @@
# limitations under the License.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2174#discussion_r69102339
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileReaderOperator.java
---
@@ -334,9 +342,11 @@ publ
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2176
Nice work! I didn't know how to use docker but I managed to set it up and
use the new version on OS X without a problem. So it seems to work well, and
the code is a lot simpler and the image is smal
[
https://issues.apache.org/jira/browse/FLINK-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356825#comment-15356825
]
ASF GitHub Bot commented on FLINK-4075:
---
Github user rmetzger commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356824#comment-15356824
]
ASF GitHub Bot commented on FLINK-4118:
---
Github user aljoscha commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek reassigned FLINK-4124:
---
Assignee: Aljoscha Krettek
> Unstable test WrapperSetupHelperTest.testCreateTopologyC
[
https://issues.apache.org/jira/browse/FLINK-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler reassigned FLINK-4124:
---
Assignee: Chesnay Schepler (was: Aljoscha Krettek)
> Unstable test WrapperSetupHelpe
[
https://issues.apache.org/jira/browse/FLINK-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-4124:
Assignee: Aljoscha Krettek (was: Chesnay Schepler)
> Unstable test WrapperSetupHelperTest.t
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2187
Change looks good! +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/FLINK-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356849#comment-15356849
]
ASF GitHub Bot commented on FLINK-3675:
---
Github user rmetzger commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356856#comment-15356856
]
Jens Kat commented on FLINK-3294:
-
[~rmetzger] I've been looking into the Kafka09Fetcher a
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356868#comment-15356868
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user zentol commented on a diff in t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r69107628
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to the Apac
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2131
@rmetzger
Just pushed the changes to address comments + rebase on the exactly-once
fix / user-agent fix.
Sorry, had some trouble with the rebasing and took more time than I
expected.
---
I
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356909#comment-15356909
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on the issue
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2186
Is the documentation still usable offline?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2053#discussion_r69121871
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java
---
@@ -0,0 +1,535 @@
+/*
+ * Licensed
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2053#discussion_r69121905
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/AffinityPropagation.java
---
@@ -0,0 +1,535 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357002#comment-15357002
]
ASF GitHub Bot commented on FLINK-1707:
---
Github user greghogan commented on a diff i
[
https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357003#comment-15357003
]
ASF GitHub Bot commented on FLINK-1707:
---
Github user greghogan commented on a diff i
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r69123278
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
@@ -459,4 +476,14 @@ public static InfoOptions parseInfoCommand(Stri
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357013#comment-15357013
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r69123376
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.flink.client;
+
+
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r69123415
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.flink.client;
+
+
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r69123467
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.flink.client;
+
+
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357017#comment-15357017
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357014#comment-15357014
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357019#comment-15357019
]
ASF GitHub Bot commented on FLINK-4084:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r69123978
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -269,26 +269,26 @@
* Percentage of heap space to remove fro
[
https://issues.apache.org/jira/browse/FLINK-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357022#comment-15357022
]
ASF GitHub Bot commented on FLINK-4127:
---
Github user mxm commented on a diff in the
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r69124072
--- Diff: docs/setup/config.md ---
@@ -230,8 +240,8 @@ definition. This scheme is used **ONLY** if no other
scheme is specified (explic
## YARN
[
https://issues.apache.org/jira/browse/FLINK-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357024#comment-15357024
]
ASF GitHub Bot commented on FLINK-4127:
---
Github user mxm commented on a diff in the
Stefan Richter created FLINK-4134:
-
Summary: EventTimeSessionWindows trigger for empty windows when
dropping late events
Key: FLINK-4134
URL: https://issues.apache.org/jira/browse/FLINK-4134
Project:
[
https://issues.apache.org/jira/browse/FLINK-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Richter reassigned FLINK-4134:
-
Assignee: Stefan Richter
> EventTimeSessionWindows trigger for empty windows when droppin
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1813
Sure, I'll give a full review now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357030#comment-15357030
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on the issue
Greg Hogan created FLINK-4135:
-
Summary: Replace ChecksumHashCode as GraphAnalytic
Key: FLINK-4135
URL: https://issues.apache.org/jira/browse/FLINK-4135
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan closed FLINK-3822.
-
Resolution: Won't Fix
This utility function will be replaced by a {{GraphAnalytic}}.
> Document checksum
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/1813
@mjsax
I think the failing `JMXReporterTest.testJMXAvailability` was just hotfixed
with this commit yesterday:
https://github.com/apache/flink/commit/53630da01bcbfe05eda90869b1198b4e1c554a8
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357039#comment-15357039
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on the issue
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2146
Alright. I just reported my observation while trying this PR out.
You're right that it would blow up the scope of this PR. I guess the
easiest solution would be to properly document the
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357040#comment-15357040
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user tillrohrmann commented on the i
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r69127489
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/JobManagerMetricTest.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed to th
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357042#comment-15357042
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user tillrohrmann commented on a dif
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2108
Thank you for your review @tillrohrmann and @zentol . I tried addressing
all your concerns.
Please let me know what you think about it.
---
If your project is set up for it, you can reply to th
[
https://issues.apache.org/jira/browse/FLINK-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357044#comment-15357044
]
ASF GitHub Bot commented on FLINK-4027:
---
Github user rmetzger commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-4135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357051#comment-15357051
]
ASF GitHub Bot commented on FLINK-4135:
---
GitHub user greghogan opened a pull request
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2188
[FLINK-4135] [gelly] Replace ChecksumHashCode as GraphAnalytic
Adds a GraphAnalytic to replace the checksumHashCode Java and Scala utility
functions.
You can merge this pull request into a Git re
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357067#comment-15357067
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r69129641
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2108#discussion_r69130106
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/AtLeastOnceProducerTest.java
---
[
https://issues.apache.org/jira/browse/FLINK-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357068#comment-15357068
]
ASF GitHub Bot commented on FLINK-4027:
---
Github user tillrohrmann commented on a dif
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r69130874
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/KinesisConfigConstants.java
---
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357072#comment-15357072
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357081#comment-15357081
]
ASF GitHub Bot commented on FLINK-4075:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek resolved FLINK-4124.
-
Resolution: Fixed
Fixed in
https://github.com/apache/flink/commit/a9733a9ae0b063ab51b5683
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek resolved FLINK-4075.
-
Resolution: Fixed
Fixed in
https://github.com/apache/flink/commit/bd273a8f435b222eb67840f
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69132723
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/FlinkJedisPoolConfig.java
---
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357089#comment-15357089
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69134099
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,217 @@
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357099#comment-15357099
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69134232
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,217 @@
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357102#comment-15357102
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2124
@kl0u could you please close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
[
https://issues.apache.org/jira/browse/FLINK-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357103#comment-15357103
]
ASF GitHub Bot commented on FLINK-3647:
---
Github user aljoscha commented on the issue
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r69135245
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisMapper.java
---
@@ -
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357105#comment-15357105
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user tzulitai commented on a diff in
Github user iemejia commented on the issue:
https://github.com/apache/flink/pull/2176
Nice, I just fixed as you suggested. I have three questions:
1. This container is based on the Java JRE (to keep it small), Does Flink
in any part do some magic that requires a full JDK (like
[
https://issues.apache.org/jira/browse/FLINK-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357106#comment-15357106
]
ASF GitHub Bot commented on FLINK-4118:
---
Github user iemejia commented on the issue:
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2108#discussion_r69136271
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/AtLeastOnceProducerTest.java
---
[
https://issues.apache.org/jira/browse/FLINK-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357110#comment-15357110
]
ASF GitHub Bot commented on FLINK-4027:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2108#discussion_r69136462
--- Diff:
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/AtLeastOnceProducerTest.java
---
1 - 100 of 296 matches
Mail list logo
