[ 
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357013#comment-15357013
 ] 

ASF GitHub Bot commented on FLINK-4084:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2149#discussion_r69123278
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java 
---
    @@ -459,4 +476,14 @@ public static InfoOptions parseInfoCommand(String[] 
args) throws CliArgsExceptio
                }
        }
     
    +   public static MainOptions parseMainCommand(String[] args) throws 
CliArgsException {
    +           try {
    +                   DefaultParser parser = new DefaultParser();
    +                   CommandLine line = parser.parse(MAIN_OPTIONS, args, 
false);
    --- End diff --
    
    You're parsing the entire arguments here. What if the user jar has 
`--configDir` as parameter?


> Add configDir parameter to CliFrontend and flink shell script
> -------------------------------------------------------------
>
>                 Key: FLINK-4084
>                 URL: https://issues.apache.org/jira/browse/FLINK-4084
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Andrea Sella
>            Priority: Minor
>
> At the moment there is no other way than the environment variable 
> FLINK_CONF_DIR to specify the configuration directory for the CliFrontend if 
> it is started via the flink shell script. In order to improve the user 
> exprience, I would propose to introduce a {{--configDir}} parameter which the 
> user can use to specify a configuration directory more easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to