[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357014#comment-15357014
]
ASF GitHub Bot commented on FLINK-4084:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r69123376
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendMainTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.flink.client;
+
+
+import org.apache.flink.client.cli.CliArgsException;
+import org.apache.flink.client.cli.CliFrontendParser;
+import org.apache.flink.client.cli.MainOptions;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import java.io.FileNotFoundException;
+import java.net.MalformedURLException;
+
+import static org.apache.flink.client.CliFrontendTestUtils.getTestJarPath;
+import static org.junit.Assert.assertEquals;
+
+public class CliFrontendMainTest {
+
+
+ @BeforeClass
+ public static void init() {
+ CliFrontendTestUtils.pipeSystemOutToNull();
+ CliFrontendTestUtils.clearGlobalConfiguration();
+ }
+
+ @Test
+ public void testMain() throws CliArgsException, FileNotFoundException,
MalformedURLException {
+ // test configure configDir
+ {
+ String[] parameters = {"--configDir",
"expectedConfigDirectory", getTestJarPath()};
+ MainOptions options =
CliFrontendParser.parseMainCommand(parameters);
+ assertEquals("expectedConfigDirectory",
options.getConfigDir());
+ }
+ }
--- End diff --
We need more tests here to assure the parameter is correctly parsed.
> Add configDir parameter to CliFrontend and flink shell script
> -------------------------------------------------------------
>
> Key: FLINK-4084
> URL: https://issues.apache.org/jira/browse/FLINK-4084
> Project: Flink
> Issue Type: Improvement
> Components: Client
> Affects Versions: 1.1.0
> Reporter: Till Rohrmann
> Assignee: Andrea Sella
> Priority: Minor
>
> At the moment there is no other way than the environment variable
> FLINK_CONF_DIR to specify the configuration directory for the CliFrontend if
> it is started via the flink shell script. In order to improve the user
> exprience, I would propose to introduce a {{--configDir}} parameter which the
> user can use to specify a configuration directory more easily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
