[
https://issues.apache.org/jira/browse/FLINK-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344041#comment-15344041
]
ASF GitHub Bot commented on FLINK-4092:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-4092.
---
Resolution: Fixed
Fixed in e04239dd7397b67ce7d12ae70da8e37d4c351e4b
> Stringify map function'
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2136
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fea
[
https://issues.apache.org/jira/browse/FLINK-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344047#comment-15344047
]
ASF GitHub Bot commented on FLINK-3626:
---
Github user zentol commented on the issue:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2144#discussion_r68026831
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
---
@@ -81
[
https://issues.apache.org/jira/browse/FLINK-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344057#comment-15344057
]
ASF GitHub Bot commented on FLINK-3626:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344058#comment-15344058
]
ASF GitHub Bot commented on FLINK-4097:
---
Github user zentol commented on a diff in t
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2144
found a minor formatting issue, otherwise +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-3626.
---
Resolution: Fixed
Fix Version/s: 1.1.0
Implemented in 93c61c097a889c55f412ff31524c74985
[
https://issues.apache.org/jira/browse/FLINK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344062#comment-15344062
]
ASF GitHub Bot commented on FLINK-4097:
---
Github user zentol commented on the issue:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2111
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344075#comment-15344075
]
ASF GitHub Bot commented on FLINK-4076:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-4076.
---
Resolution: Fixed
Fix Version/s: 1.1.0
Fixed in e7dfa28947f1582ab0b60ab9483b3fe06017f1f
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2144
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
[
https://issues.apache.org/jira/browse/FLINK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344088#comment-15344088
]
ASF GitHub Bot commented on FLINK-4097:
---
Github user zentol commented on the issue:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/FLINK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-4097.
---
Resolution: Fixed
Fix Version/s: 1.1.0
Fixed in a973d84b251ddf87bc47d9806d37d353febcab4
[
https://issues.apache.org/jira/browse/FLINK-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344091#comment-15344091
]
ASF GitHub Bot commented on FLINK-4097:
---
Github user asfgit closed the pull request
Chesnay Schepler created FLINK-4100:
---
Summary: RocksDBStateBackend#close() can throw NPE
Key: FLINK-4100
URL: https://issues.apache.org/jira/browse/FLINK-4100
Project: Flink
Issue Type: Bug
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2145
[FLINK-4087] [metrics] Improved JMX port handling
This PR modifies the JMX port handling.
Instead of setting a specific configured port on JVM start-up we use an
ephemeral port for the JVM's
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344117#comment-15344117
]
ASF GitHub Bot commented on FLINK-4087:
---
GitHub user zentol opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344120#comment-15344120
]
ASF GitHub Bot commented on FLINK-1550:
---
GitHub user zentol opened a pull request:
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2146
[FLINK-1550/FLINK-4057] Add JobManager Metrics
This PR relies on #2145.
This PR exposes several Metrics on the JobManager.
The first change made was the separation of the "metrics.jm
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68035265
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -170,8 +170,12 @@ public ScopeFormats getScopeFormats() {
[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344131#comment-15344131
]
ASF GitHub Bot commented on FLINK-4074:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68035356
--- Diff:
flink-metric-reporters/flink-metrics-statsd/src/main/java/org/apache/flink/metrics/statsd/StatsDReporter.java
---
@@ -53,6 +53,8 @@
// pu
[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344132#comment-15344132
]
ASF GitHub Bot commented on FLINK-4074:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68036072
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -86,11 +88,11 @@ public MetricRegistry(Configuration config) {
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68036113
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -118,40 +120,38 @@ public MetricRegistry(Configuration config) {
[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344136#comment-15344136
]
ASF GitHub Bot commented on FLINK-4074:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344140#comment-15344140
]
ASF GitHub Bot commented on FLINK-4074:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344137#comment-15344137
]
ASF GitHub Bot commented on FLINK-4074:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-4100:
Priority: Trivial (was: Major)
> RocksDBStateBackend#close() can throw NPE
> --
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68036163
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -118,40 +120,38 @@ public MetricRegistry(Configuration config) {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68036496
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -170,8 +170,12 @@ public ScopeFormats getScopeFormats() {
* @pa
[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344141#comment-15344141
]
ASF GitHub Bot commented on FLINK-4074:
---
Github user zentol commented on a diff in t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68036583
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -86,11 +88,11 @@ public MetricRegistry(Configuration config) {
[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344142#comment-15344142
]
ASF GitHub Bot commented on FLINK-4074:
---
Github user zentol commented on a diff in t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68037092
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -118,40 +120,38 @@ public MetricRegistry(Configuration config) {
[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344147#comment-15344147
]
ASF GitHub Bot commented on FLINK-4074:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2105
Good improvements to make the Reporters less blocking @zentol. I had only
some minor comments. After addressing them, I think the PR is good to be merged
:-)
---
If your project is set up for
[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344152#comment-15344152
]
ASF GitHub Bot commented on FLINK-4074:
---
Github user tillrohrmann commented on the i
[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344154#comment-15344154
]
ASF GitHub Bot commented on FLINK-4074:
---
Github user zentol commented on a diff in t
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68037781
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -118,40 +120,38 @@ public MetricRegistry(Configuration config) {
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2095
+1 to merge. Both the direct state transition and test are good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
[
https://issues.apache.org/jira/browse/FLINK-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344169#comment-15344169
]
ASF GitHub Bot commented on FLINK-4046:
---
Github user uce commented on the issue:
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2096#discussion_r68039809
--- Diff: docs/internals/job_scheduling.md ---
@@ -74,7 +74,28 @@ Besides the vertices, the ExecutionGraph also contains
the {% gh_link /flink-run
[
https://issues.apache.org/jira/browse/FLINK-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344175#comment-15344175
]
ASF GitHub Bot commented on FLINK-3800:
---
Github user uce commented on a diff in the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2096#discussion_r68039992
--- Diff: docs/internals/job_scheduling.md ---
@@ -74,7 +74,28 @@ Besides the vertices, the ExecutionGraph also contains
the {% gh_link /flink-run
[
https://issues.apache.org/jira/browse/FLINK-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344181#comment-15344181
]
ASF GitHub Bot commented on FLINK-3800:
---
Github user uce commented on a diff in the
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1996#discussion_r68041009
--- Diff:
flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/math/distributed/DistributedRowMatrix.scala
---
@@ -0,0 +1,162 @@
+/*
+ * Li
[
https://issues.apache.org/jira/browse/FLINK-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344187#comment-15344187
]
ASF GitHub Bot commented on FLINK-3919:
---
Github user chiwanpark commented on a diff
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68041209
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -85,7 +87,14 @@ public MetricRegistry(Configuration config) {
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344190#comment-15344190
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68041287
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -73,10 +86,61 @@ public JMXReporter() {
//
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344192#comment-15344192
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user tillrohrmann commented on a dif
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68041836
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -73,10 +86,61 @@ public JMXReporter() {
//
--
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344204#comment-15344204
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user zentol commented on a diff in t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68042265
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -265,4 +329,72 @@ public Object getValue() {
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344212#comment-15344212
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344223#comment-15344223
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68043291
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -73,10 +86,61 @@ public JMXReporter() {
//
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68043366
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -73,10 +86,61 @@ public JMXReporter() {
//
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344224#comment-15344224
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68043573
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -73,10 +86,61 @@ public JMXReporter() {
//
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344226#comment-15344226
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user tillrohrmann commented on a dif
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68043651
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -265,4 +329,72 @@ public Object getValue() {
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344228#comment-15344228
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user zentol commented on a diff in t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68043825
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -265,4 +329,72 @@ public Object getValue() {
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344229#comment-15344229
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2145#discussion_r68044577
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/reporter/JMXReporter.java ---
@@ -265,4 +329,72 @@ public Object getValue() {
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344241#comment-15344241
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2145
Good work @zentol. I mostly had general questions for my understanding.
Before merging, I think it would be good to add a JMXReporter test which checks
that we can start multiple JMXReporter on
[
https://issues.apache.org/jira/browse/FLINK-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344244#comment-15344244
]
ASF GitHub Bot commented on FLINK-4087:
---
Github user tillrohrmann commented on the i
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/1996
Looks good to me, +1. I'll merge this in few hours.
But I think we should change the type of row index to `Long` in near
future. I think we can deal with the incompatibility problem with l
[
https://issues.apache.org/jira/browse/FLINK-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344254#comment-15344254
]
ASF GitHub Bot commented on FLINK-3919:
---
Github user chiwanpark commented on the iss
[
https://issues.apache.org/jira/browse/FLINK-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344257#comment-15344257
]
ASF GitHub Bot commented on FLINK-4046:
---
Github user uce commented on the issue:
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2095
PS: Should the early abort check for the `CANCELED` state in
`ExecutionGraph.restart()` be extended to any terminal state? The `restart`
method assumes that it's the only one transitioning away from `RES
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2096#discussion_r68046896
--- Diff: flink-runtime/src/test/resources/log4j-test.properties ---
@@ -16,7 +16,7 @@
# limitations under the License.
[
https://issues.apache.org/jira/browse/FLINK-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344263#comment-15344263
]
ASF GitHub Bot commented on FLINK-3800:
---
Github user uce commented on a diff in the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68047271
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerJobMetricGroup.java
---
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Ap
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344268#comment-15344268
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user tillrohrmann commented on a dif
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2032
Hi @vasia,
Configurations can be merged if there exists a configuration which
satisfies all configuration constraints. It is left to the algorithm to decide
whether and how to merged the v
[
https://issues.apache.org/jira/browse/FLINK-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344282#comment-15344282
]
ASF GitHub Bot commented on FLINK-3965:
---
Github user greghogan commented on the issu
[
https://issues.apache.org/jira/browse/FLINK-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344286#comment-15344286
]
Greg Hogan commented on FLINK-3879:
---
When I tested the performance of FLINK-3879 it was
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68050729
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apac
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344291#comment-15344291
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68051176
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apac
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344293#comment-15344293
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68052027
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/JobManagerMetricGroup.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apac
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344302#comment-15344302
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344311#comment-15344311
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68053983
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/scope/ScopeFormat.java
---
@@ -66,23 +68,44 @@
// Scope Variables
//
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68053080
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/TaskManagerJobMetricGroup.java
---
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344320#comment-15344320
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user tillrohrmann commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344328#comment-15344328
]
Andrea Sella commented on FLINK-4084:
-
Hi [~mxm], thanks for follow me in this issue.
[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344322#comment-15344322
]
ASF GitHub Bot commented on FLINK-1550:
---
Github user tillrohrmann commented on a dif
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2146#discussion_r68054269
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/groups/scope/ScopeFormat.java
---
@@ -240,7 +305,7 @@ public OperatorScopeFormat(String form
1 - 100 of 270 matches
Mail list logo
