[
https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344120#comment-15344120
]
ASF GitHub Bot commented on FLINK-1550:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2146
[FLINK-1550/FLINK-4057] Add JobManager Metrics
This PR relies on #2145.
This PR exposes several Metrics on the JobManager.
The first change made was the separation of the "metrics.jmx.port" key into
2 version, one 1 Task- and JobManagers respectively.
("(job/task)manager.metrics.jmx.port") This was necessary since otherwise you
could never access TM metrics in a local setup.
Next up the metric infrastructure was introduced in the JM.
This includes
* defining a new Scope format key (metrics.scope.jm) and default Scope
format
* add a JobManagerMetricGroup
* refactoring the old TaskManager(Job)Group so that the JobMetricGroup can
be used by both JM and TM
* creating/teardown MetricRegistry/JobManagerMetricGroup in the JobManager
Now metrics could be added.
In the JobManager scope we have:
* JMV metrics, which are a copy&paste from the TM
* availableSlots, totalSlots
* numRegisteredTaskManagers
* numRunningJobs
Adding these was straight-forward.
In the Job scope we have
* lastCheckpointSize
* lastCheckpointDuration
For this we have to pass a metricGroup through the ExecutionGraph into the
CheckpointCoordinator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink metrics_jm
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2146
----
commit 65ce27a823944ec722949730e65e545e1e76b147
Author: zentol <ches...@apache.org>
Date: 2016-06-15T07:21:51Z
[FLINK-456] Introduce separate keys for TM/JM JMX port
commit 63966bec8b2db0fd458b26c4cef77b78f1ce79e5
Author: zentol <ches...@apache.org>
Date: 2016-06-17T09:04:25Z
[FLINK-456] Basic JM Metric Infrastructure
commit b13a0c51d7008977d5ecb31b66b6579a84da2cd3
Author: zentol <ches...@apache.org>
Date: 2016-06-15T11:42:07Z
[FLINK-1550] JM JVM Metrics
commit 3d2f6c59fb47d0ef23f0bc0ff3576cc9cae8b89c
Author: zentol <ches...@apache.org>
Date: 2016-06-15T10:30:22Z
[FLINK-4057] Slots/regTaskManagers/numJobs
commit 3c3ca95e97de98108963988a9e38646808cf5ee2
Author: zentol <ches...@apache.org>
Date: 2016-06-15T11:19:56Z
[FLINK-4057] Checkpoint Metrics
----
> Show JVM Metrics for JobManager
> -------------------------------
>
> Key: FLINK-1550
> URL: https://issues.apache.org/jira/browse/FLINK-1550
> Project: Flink
> Issue Type: Sub-task
> Components: JobManager, Metrics
> Reporter: Robert Metzger
> Assignee: Chesnay Schepler
> Fix For: pre-apache
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
