[
https://issues.apache.org/jira/browse/FLINK-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344142#comment-15344142
]
ASF GitHub Bot commented on FLINK-4074:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2105#discussion_r68036583
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -86,11 +88,11 @@ public MetricRegistry(Configuration config) {
// by default, create JMX metrics
LOG.info("No metrics reporter configured, exposing
metrics via JMX");
this.reporter = new JMXReporter();
- this.timer = null;
+ this.executor = null;
}
else {
MetricReporter reporter;
- java.util.Timer timer;
+ ScheduledExecutorService executor =
Executors.newSingleThreadScheduledExecutor();
--- End diff --
good idea.
> Reporter can block TaskManager shutdown
> ---------------------------------------
>
> Key: FLINK-4074
> URL: https://issues.apache.org/jira/browse/FLINK-4074
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Minor
> Fix For: 1.1.0
>
>
> If a report is being submitted while a TaskManager is shutting down the
> reporter can cause the shutdown to be delayed since it submits the complete
> report.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
