Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-18 Thread via GitHub
lincoln-lil merged PR #721: URL: https://github.com/apache/flink-web/pull/721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-17 Thread via GitHub
lincoln-lil commented on PR #721: URL: https://github.com/apache/flink-web/pull/721#issuecomment-2002757799 Finalize the commits before merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-14 Thread via GitHub
leonardBang commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1525013212 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,501 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "202

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-13 Thread via GitHub
lincoln-lil commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1523241548 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,501 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "202

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-13 Thread via GitHub
lincoln-lil commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1522831889 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,501 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "202

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-12 Thread via GitHub
PatrickRen commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1522504285 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,501 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-12 Thread via GitHub
lincoln-lil commented on PR #721: URL: https://github.com/apache/flink-web/pull/721#issuecomment-1993232847 @Myasuka Thanks! I've updated the pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-12 Thread via GitHub
Myasuka commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1522360842 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,501 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024-03

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-12 Thread via GitHub
lincoln-lil commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1521623410 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- Review Comment: @MartijnVisser As we discussed at the sync meeting, I've added the

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-12 Thread via GitHub
lincoln-lil commented on PR #721: URL: https://github.com/apache/flink-web/pull/721#issuecomment-1991840142 @xintongsong @rmoff As per the conclusion of our discussion, I've tweaked these examples and tried to keep them to just describing what the functionality looks like (and avoiding over

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-12 Thread via GitHub
rmetzger commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1521014951 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,470 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024-0

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
JunRuiLee commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1520726747 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024-

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
xintongsong commented on PR #721: URL: https://github.com/apache/flink-web/pull/721#issuecomment-1989726878 @lincoln-lil, thanks for the quick reply. Regarding the examples, it's just a suggestion to remove them but I'd not insist. There's no more concerns from my side. -- This is an aut

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
lincoln-lil commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1520017882 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- Review Comment: @MartijnVisser Thanks for reviewing this! Yes, these changes need

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
lincoln-lil commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1520017882 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- Review Comment: @MartijnVisser Thanks for reviewing this! Yes, these changes need

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
lincoln-lil commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1519964324 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "202

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
rmoff commented on PR #721: URL: https://github.com/apache/flink-web/pull/721#issuecomment-1988775115 FWIW on [the question of inline examples](https://github.com/apache/flink-web/pull/721#discussion_r1519951825) I would be in favour of including some light-weight content. Definitely not r

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
lincoln-lil commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1519951825 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "202

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
masteryhx commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1519492535 ## docs/data/release_archive.yml: ## @@ -1,6 +1,10 @@ release_archive: flink: -- version_short: "1.18" +- version_short: "1.19" + version_long: 1.18.

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
JunRuiLee commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1519522297 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024-

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
JunRuiLee commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1519522297 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024-

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
Sxnan commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1519464357 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024-03-x

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
MartijnVisser commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1519461611 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- Review Comment: @lincoln-lil I think we're missing something on the changes to t

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-11 Thread via GitHub
xintongsong commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1519286951 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "202

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-08 Thread via GitHub
lincoln-lil commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1517781917 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,466 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "202

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-07 Thread via GitHub
lincoln-lil commented on PR #721: URL: https://github.com/apache/flink-web/pull/721#issuecomment-1984885393 > Not sure if we should also update the following files in this PR: https://github.com/apache/flink-web/blob/asf-site/docs/data/flink.yml https://github.com/apache/flink-web/blob/

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-07 Thread via GitHub
rmoff commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1516486388 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,466 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024-03-0

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-07 Thread via GitHub
rmoff commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1516436624 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,466 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024-03-0

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-07 Thread via GitHub
Myasuka commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1515992776 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,466 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024-03

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-04 Thread via GitHub
lincoln-lil commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1512211263 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,466 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "202