Re: [PR] [FLINK-34554] Introduce transaction strategies [flink-connector-kafka]

2025-03-04 Thread via GitHub
pnowojski commented on code in PR #154: URL: https://github.com/apache/flink-connector-kafka/pull/154#discussion_r1979381461 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/internal/TransactionAbortStrategyImpl.java: ## @@ -107,6 +119,64 @@ private

Re: [PR] [FLINK-34554] Introduce transaction strategies [flink-connector-kafka]

2025-03-04 Thread via GitHub
fapaul commented on code in PR #154: URL: https://github.com/apache/flink-connector-kafka/pull/154#discussion_r1979035891 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriterStateSerializer.java: ## @@ -47,8 +54,15 @@ public byte[] serialize(

Re: [PR] [FLINK-34554] Introduce transaction strategies [flink-connector-kafka]

2025-02-28 Thread via GitHub
fapaul commented on code in PR #154: URL: https://github.com/apache/flink-connector-kafka/pull/154#discussion_r1975559008 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/internal/TransactionNamingStrategyImpl.java: ## @@ -0,0 +1,77 @@ +/* + * Licens

Re: [PR] [FLINK-34554] Introduce transaction strategies [flink-connector-kafka]

2025-02-24 Thread via GitHub
AHeise commented on code in PR #154: URL: https://github.com/apache/flink-connector-kafka/pull/154#discussion_r1969184961 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/ExactlyOnceKafkaWriter.java: ## @@ -224,13 +243,32 @@ private void abortLingeri

Re: [PR] [FLINK-34554] Introduce transaction strategies [flink-connector-kafka]

2025-02-24 Thread via GitHub
AHeise commented on code in PR #154: URL: https://github.com/apache/flink-connector-kafka/pull/154#discussion_r1969172042 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/ExactlyOnceKafkaWriter.java: ## @@ -136,13 +158,10 @@ public void initialize()

Re: [PR] [FLINK-34554] Introduce transaction strategies [flink-connector-kafka]

2025-02-24 Thread via GitHub
AHeise commented on code in PR #154: URL: https://github.com/apache/flink-connector-kafka/pull/154#discussion_r1969167167 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/TransactionAbortStrategy.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apac

Re: [PR] [FLINK-34554] Introduce transaction strategies [flink-connector-kafka]

2025-02-24 Thread via GitHub
fapaul commented on code in PR #154: URL: https://github.com/apache/flink-connector-kafka/pull/154#discussion_r1967898094 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/ExactlyOnceKafkaWriter.java: ## @@ -53,7 +56,14 @@ */ class ExactlyOnceKafka