AHeise commented on code in PR #154: URL: https://github.com/apache/flink-connector-kafka/pull/154#discussion_r1969167167
########## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/TransactionAbortStrategy.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.kafka.sink; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.connector.kafka.sink.internal.TransactionAbortStrategyImpl; + +/** + * The strategy to abort a transactions left by ungraceful job termination, which is the usual case + * for failures in Flink. On start of the sink, the strategy will be used to abort any ongoing + * transactions left open while cautiously avoid to abort transactions that are still trying to + * commit. + */ +@PublicEvolving +public enum TransactionAbortStrategy { Review Comment: You can use the list transaction abort strategy with the incrementing naming strategy if you don't experience pressure on the memory of the broker. There are some advantages in having unique transaction ids per checkpoints (such as ease of debugging). A major point why I separated it is because both the default abortion and the default naming strategies are already battle-tested. Folks will be reluctant to set the new strategies on prod and have the option to migrate in separate steps. I'm also assuming that we will have more strategies in the future with more possible combinations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
