ferenc-csaky commented on PR #25525:
URL: https://github.com/apache/flink/pull/25525#issuecomment-2434614251
@jnh5y @ruanwenjun Thanks for the added thoughts! I am okay with updating
this PR with simply bumping the spotless version to `2.35.0`, putting the index
under `target/` is not harmf
jnh5y commented on PR #25525:
URL: https://github.com/apache/flink/pull/25525#issuecomment-2432283636
> Here are some things I want to confirm
>
> 1. If we upgrade the spotless to 2.35.0, then where do we disable it, in
CI or disable it by default? Is there any way we can
know the
ruanwenjun commented on PR #25525:
URL: https://github.com/apache/flink/pull/25525#issuecomment-2430674613
> I think it'd be better to enable this by default (if there are concerns
about CI, it could be disabled there), and also to upgrade the Spotless plugin
version.
>
> The default
jnh5y commented on PR #25525:
URL: https://github.com/apache/flink/pull/25525#issuecomment-2430105599
I think it'd be better to enable this by default (if there are concerns
about CI, it could be disabled there), and also to upgrade the Spotless plugin
version.
The default is for thi
ferenc-csaky commented on PR #25525:
URL: https://github.com/apache/flink/pull/25525#issuecomment-2427353187
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
ferenc-csaky commented on PR #25525:
URL: https://github.com/apache/flink/pull/25525#issuecomment-2426536625
> @ferenc-csaky Thanks for your review, as far as I know, the index file
will be generated under root/target, this will not be put into binary package,
so will not break the RAT lice
ruanwenjun commented on PR #25525:
URL: https://github.com/apache/flink/pull/25525#issuecomment-2426100238
@ferenc-csaky Thanks for your review, as far as I know, the index file will
be generated under root/target, this will not be put into binary package, so
will not break the RAT license
ferenc-csaky commented on PR #25525:
URL: https://github.com/apache/flink/pull/25525#issuecomment-2425881444
I think this would be pretty useful, just wondering about if we enable it by
default could it break something in any CI? My understanding is that by default
the index file is placed
ruanwenjun commented on PR #25525:
URL: https://github.com/apache/flink/pull/25525#issuecomment-2415562572
> Nice quick optimisation, thanks!
I am very happy to be able to make something that will help flink!
--
This is an automated message from the Apache Git Service.
To respond to
vahmed-hamdy commented on PR #25525:
URL: https://github.com/apache/flink/pull/25525#issuecomment-2414014614
Nice quick optimisation, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
flinkbot commented on PR #25525:
URL: https://github.com/apache/flink/pull/25525#issuecomment-2414013082
## CI report:
* e7172ed2e0b59c13252a17c30c5f580cc4a86cf9 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
ruanwenjun opened a new pull request, #25525:
URL: https://github.com/apache/flink/pull/25525
## What is the purpose of the change
Speed up the spotless.
JIRA: https://issues.apache.org/jira/browse/FLINK-36542
## Brief change log
- Enable upToDateChecking i
12 matches
Mail list logo
