ruanwenjun commented on PR #25525: URL: https://github.com/apache/flink/pull/25525#issuecomment-2430674613
> I think it'd be better to enable this by default (if there are concerns about CI, it could be disabled there), and also to upgrade the Spotless plugin version. > > The default is for this feature to be enabled in 2.35.0 and higher: https://github.com/diffplug/spotless/tree/main/plugin-maven#incremental-up-to-date-checking-and-formatting Thanks for remind this, I agree with upgrade spotless plugin. Here are some things I want to confirm 1. If we upgrade the spotless to 2.35.0, then where do we disable it, in CI or disable it by default? Is there any way we can know the effect of opening on CI? I got the result from `flinkbot` is SUCCESS. 2. Do we upgrade in this PR or submit a separate PR to upgrade？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
