jnh5y commented on PR #25525: URL: https://github.com/apache/flink/pull/25525#issuecomment-2432283636
> Here are some things I want to confirm > > 1. If we upgrade the spotless to 2.35.0, then where do we disable it, in CI or disable it by default? Is there any way we can know the effect of opening on CI? I got the result from `flinkbot` is SUCCESS. In a single run of CI, spotless is not going to fail the build. It _may_ slightly slow it down since there'd be extra IO to write whatever output it writes. My opinion is that we do not need to care and do not need to override anything. I have two reasons: A. The Flink build is already complex enough; fewer options is better. B. The maintainers for the Spotless plugin have made this setting the default. If it were causing issues, they would not have done so. > 2. Do we upgrade in this PR or submit a separate PR to upgrade？ Given my position above, I would suggest we update the version instead of exposing the configuration that this PR does. If @ferenc-csaky / the community is ok with that, then it just comes down to a question of updating this PR versus a new one. (And on that point, I do not have an opinion.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
