snuyanzin commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-2282912942
superseded by https://github.com/apache/flink/pull/24967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
snuyanzin closed pull request #24156: [FLINK-34111][table] Add JSON_QUOTE and
JSON_UNQUOTE function
URL: https://github.com/apache/flink/pull/24156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
anupamaggarwal commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-2180544647
thanks @jeyhunkarimov! linking the PR
https://github.com/apache/flink/pull/24967
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
jeyhunkarimov commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-2171513067
Hi @anupamaggarwal thanks for your proposal. Please feel free to continue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
anupamaggarwal commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-2162795228
Hi @jeyhunkarimov thank you for contributing this PR!. Just wanted to check
if you were planning on working further on this, otherwise I'd be happy to
continue and address some of
jeyhunkarimov commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1939523473
Thanks a lot for the comments. I agree. I was a bit influenced by the
definition of MySQL and didn't check the `json.org`.
--
This is an automated message from the Apache Git Ser
snuyanzin commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1938742257
> and json_unqote("\\"key\\"") will produce the same ("\\"key\\"") since the
input ("\\"key\\"") is not a valid json.
can you clarify why it the input here is not a valid json?
jeyhunkarimov commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1938706008
> > Is it mainly because of the definition of JSON_QUOTE that does not
require its input to be valid JSON, and JSON_UNQOTE that require its input to
be a valid JSON.
>
> I'm
snuyanzin commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1938687661
>Is it mainly because of the definition of JSON_QUOTE that does not require
its input to be valid JSON, and JSON_UNQOTE that require its input to be a
valid JSON.
I'm not sure th
jeyhunkarimov commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1938645548
Thanks for the comment @snuyanzin . I think we need more investigation about
the clear definition and behavior of these functions, since the ones adopted
from MySQL are a bit ambigu
jeyhunkarimov commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1486149775
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
snuyanzin commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1486024115
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
de
MartijnVisser commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1938428659
@snuyanzin Do you want to take another pass?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
jeyhunkarimov commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1928151122
> Thanks for moving to a new stack
>
> I feel like a lack of IT tests, I would suggest to follow similar approach
for tests Here it is a class for JSON function relates IT tes
jeyhunkarimov commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1478939919
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
jeyhunkarimov commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1478939919
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
jeyhunkarimov commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1478938877
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/BaseExpressions.java:
##
@@ -1090,6 +1092,21 @@ public OutType regexpExtract
snuyanzin commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1478778140
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
de
snuyanzin commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1478776254
##
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/BaseExpressions.java:
##
@@ -1090,6 +1092,21 @@ public OutType regexpExtract(InT
snuyanzin commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1927874096
Thanks for moving to a new stack
I feel like a lack of IT tests, I would suggest to follow similar approach
for tests
Here it is a class for JSON function relates IT tests
`or
snuyanzin commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1925915797
Yes, it's not marked as deprecated
however for new functions it's better to follow new stack which is a result
of FLIP-32 and FLIP-65.
--
This is an automated message from the Ap
jeyhunkarimov commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1925892580
Thanks @snuyanzin for the review. I will check the tests and add more
[failing] tests.About the implementation doesn't follow new stack
implementation, I havent noticed that my imp
jeyhunkarimov commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1477413831
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
jeyhunkarimov commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1477414392
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java:
##
@@ -1174,6 +1174,148 @@ public static String t
jeyhunkarimov commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1477413831
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
snuyanzin commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1477286758
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java:
##
@@ -1174,6 +1174,148 @@ public static String toBas
snuyanzin commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1477286758
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java:
##
@@ -1174,6 +1174,148 @@ public static String toBas
snuyanzin commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1477281273
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
de
snuyanzin commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1477281273
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
de
snuyanzin commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1925707087
I wonder why the implementation doesn't follow new stack implememntation
approach like e.g.
`org.apache.flink.table.runtime.functions.scalar.CoalesceFunction`,
`org.apache.flink.table.
snuyanzin commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1477281273
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
de
snuyanzin commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1477281273
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
de
snuyanzin commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1477281273
##
docs/data/sql_functions.yml:
##
@@ -377,6 +377,12 @@ string:
- sql: SUBSTR(string, integer1[, integer2])
table: STRING.substr(INTEGER1[, INTEGER2])
de
JingGe commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1922027269
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
jeyhunkarimov commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1474142442
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##
@@ -604,6 +604,20 @@ class ScalarFuncti
JingGe commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1472765262
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##
@@ -604,6 +604,20 @@ class ScalarFunctionsTest
JingGe commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1472765262
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##
@@ -604,6 +604,20 @@ class ScalarFunctionsTest
JingGe commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1472779610
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/FlinkSqlOperatorTable.java:
##
@@ -716,6 +716,28 @@ public SqlSyntax getSyn
JingGe commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1472765262
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##
@@ -604,6 +604,20 @@ class ScalarFunctionsTest
jeyhunkarimov commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1471759543
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##
@@ -604,6 +604,20 @@ class ScalarFuncti
jeyhunkarimov commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1471759543
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##
@@ -604,6 +604,20 @@ class ScalarFuncti
xjmdoo commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1471695921
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java:
##
@@ -1174,6 +1174,112 @@ public static String toBase64
xjmdoo commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1471695921
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java:
##
@@ -1174,6 +1174,112 @@ public static String toBase64
JingGe commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1471255451
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##
@@ -604,6 +604,20 @@ class ScalarFunctionsTest
jeyhunkarimov commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1466000951
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java:
##
@@ -1174,6 +1174,107 @@ public static String t
xjmdoo commented on code in PR #24156:
URL: https://github.com/apache/flink/pull/24156#discussion_r1464565498
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java:
##
@@ -1174,6 +1174,107 @@ public static String toBase64
jeyhunkarimov commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1904869427
Hi @MartijnVisser could you please review the PR in your available time?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please
flinkbot commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1901290843
## CI report:
* e7e7684af95b8571b6db9fda9a396d92b4256bc2 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
jeyhunkarimov opened a new pull request, #24156:
URL: https://github.com/apache/flink/pull/24156
## What is the purpose of the change
This pull request adds JSON_QUOTE and JSON_UNQUOTE functions
## Brief change log
- Add the necessary documentation and functions to
49 matches
Mail list logo
