jeyhunkarimov commented on PR #24156:
URL: https://github.com/apache/flink/pull/24156#issuecomment-1928151122
> Thanks for moving to a new stack
>
> I feel like a lack of IT tests, I would suggest to follow similar approach
for tests Here it is a class for JSON function relates IT tests
`org.apache.flink.table.planner.functions.JsonFunctionsITCase` The reason I
asked about that is that I fetched curent branch locally, build it, I can
confirm that existing tests are passing, however from user point of
`JSON_UNQOTE` does not seem to be working: if you run it e.g. under
`flink_sql_client` and execute any query e.g. `SELECT JSON_UNQUOTE('"abc"');`
it returns empty string.
>
> Another issue is that current tests are checking only sql (as mentioned
not at IT level) and do not check table api
Thanks for the review. I added IT cases.
> `SELECT JSON_UNQUOTE('"abc"');` it returns empty string.
Yes, it returns empty string (now I changed it, based on MySQL/MariaDB to
return the same value) because '"abc"' is not a valid json string (according to
the definition). For example, '["abc"]' is a valid json string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
