xjmdoo commented on code in PR #24156: URL: https://github.com/apache/flink/pull/24156#discussion_r1464565498
########## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlFunctionUtils.java: ########## @@ -1174,6 +1174,107 @@ public static String toBase64(byte[] bytes) { return Base64.getEncoder().encodeToString(bytes); } + public static BinaryStringData jsonQuote(BinaryStringData input) { + if (input == null) { + return null; + } + + StringBuilder result = new StringBuilder("\""); + + for (int i = 0; i < input.getSizeInBytes(); ++i) { + char c = (char) (input.byteAt(i) & 0xFF); Review Comment: I think this doesn't work for multi-byte characters, so it would be better to use code points instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org