dawidwys closed pull request #23869: [FLINK-33470] Implement restore tests for
Join node
URL: https://github.com/apache/flink/pull/23869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dawidwys commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1416038404
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -107,7 +107,7 @@ public class Jo
jnh5y commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1416020844
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,450 @@
+/*
+ * Licensed to
jnh5y commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415899730
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -107,7 +107,7 @@ public class JoinT
dawidwys commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415790788
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -107,7 +107,7 @@ public class Jo
jnh5y commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415680690
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -117,6 +122,11 @@ public EnumSet sup
jnh5y commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415682052
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -117,6 +122,11 @@ public EnumSet sup
dawidwys commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415631030
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -117,6 +122,11 @@ public EnumSet
dawidwys commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415628238
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,450 @@
+/*
+ * Licensed
dawidwys commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415600246
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -117,6 +122,11 @@ public EnumSet
flinkbot commented on PR #23869:
URL: https://github.com/apache/flink/pull/23869#issuecomment-1839167824
## CI report:
* e31e886a9f79fb413cffc74e685356d5d8e6ea7c UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
jnh5y commented on PR #23869:
URL: https://github.com/apache/flink/pull/23869#issuecomment-1839158522
This PR adds back the JoinRestore tests
(https://github.com/apache/flink/pull/23680) which were reverted
(https://github.com/apache/flink/pull/23861) after CI failures.
The issues
jnh5y opened a new pull request, #23869:
URL: https://github.com/apache/flink/pull/23869
## What is the purpose of the change
Implement restore tests for Join node
* Adds a clearData method to clean up the TestValuesFactory between
RestoreTests.
## Verifying this change
jnh5y commented on PR #23680:
URL: https://github.com/apache/flink/pull/23680#issuecomment-1837217788
> @dawidwys @jnh5y after merging this ci on master failed 4 times out of 6
e.g.
>
> ```
> Dec 02 04:42:26 04:42:26.408 [ERROR] Failures:
> Dec 02 04:42:26 04:42:26.408 [ERROR]
snuyanzin commented on PR #23680:
URL: https://github.com/apache/flink/pull/23680#issuecomment-1837157958
@dawidwys @jnh5y after merging this ci on master failed 4 times out of 6
e.g.
```
Dec 02 04:42:26 04:42:26.408 [ERROR] Failures:
Dec 02 04:42:26 04:42:26.408 [ERROR]
JoinR
dawidwys merged PR #23680:
URL: https://github.com/apache/flink/pull/23680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apac
jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1410763255
##
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java:
##
@@ -106,6 +113,8 @@ public static final class Builder extends
dawidwys commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1410669365
##
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java:
##
@@ -106,6 +113,8 @@ public static final class Builder exten
jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1410643440
##
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java:
##
@@ -106,6 +113,8 @@ public static final class Builder extends
dawidwys commented on PR #23680:
URL: https://github.com/apache/flink/pull/23680#issuecomment-1833528947
I think it looks mostly good. There is one comment from me left and the
comments from Timo. After that I think we're good to go.
--
This is an automated message from the Apache Git Ser
twalthr commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1410493959
##
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java:
##
@@ -106,6 +113,8 @@ public static final class Builder extend
twalthr commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1410492024
##
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java:
##
@@ -138,6 +147,16 @@ public Builder consumedAfterRestore(Str
twalthr commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1410491319
##
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java:
##
@@ -138,6 +147,16 @@ public Builder consumedAfterRestore(Str
dawidwys commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1410463990
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,272 @@
+/*
+ * Licensed
jnh5y commented on PR #23680:
URL: https://github.com/apache/flink/pull/23680#issuecomment-1828467648
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1406606618
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,409 @@
+/*
+ * Licensed to
jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1406606039
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java:
##
@@ -280,6 +280,15 @@ public static void register
jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1406604611
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -181,12 +186,25 @@ public void gener
jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1406605453
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -224,7 +242,9 @@ void testRestore(Ta
jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1406603980
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,272 @@
+/*
+ * Licensed to
jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1406603182
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,272 @@
+/*
+ * Licensed to
dawidwys commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1400462743
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -151,7 +156,7 @@ public void gene
jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1391719912
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,274 @@
+/*
+ * Licensed to
dawidwys commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1387876208
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,272 @@
+/*
+ * Licensed
dawidwys commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1387873562
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,272 @@
+/*
+ * Licensed
jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1386993678
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,272 @@
+/*
+ * Licensed to
jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1386985040
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/JoinTestPrograms.java:
##
@@ -0,0 +1,272 @@
+/*
+ * Licensed to
dawidwys commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1386592611
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/JoinJsonPlanTest.java:
##
@@ -1,144 +0,0 @@
-/*
- * Licensed to
flinkbot commented on PR #23680:
URL: https://github.com/apache/flink/pull/23680#issuecomment-1800285139
## CI report:
* 5da58a4bacbba7cc2547a7c3acb1b12fb662c667 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
jnh5y opened a new pull request, #23680:
URL: https://github.com/apache/flink/pull/23680
## What is the purpose of the change
Implement restore tests for Join node
## Verifying this change
This change added tests and can be verified as follows:
* Added restore test
40 matches
Mail list logo
