dawidwys commented on code in PR #23869:
URL: https://github.com/apache/flink/pull/23869#discussion_r1415600246


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##########
@@ -117,6 +122,11 @@ public EnumSet<TestKind> supportedRunSteps() {
         return EnumSet.of(TestKind.SQL);
     }
 
+    @BeforeEach
+    public void clearData() {

Review Comment:
   Nice find!
   
   I think we should be unified with how it's done at other places. 
`JsonPlanTestBase` does it in `AfterEach`. If we reuse a name between those 
two, `JsonPlanTestBase` can fail if executed after `RestoreTestBase`.
   
   Could we also clear the `localRawResultsObservers` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to