jnh5y commented on code in PR #23680:
URL: https://github.com/apache/flink/pull/23680#discussion_r1406605453
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##########
@@ -224,7 +242,9 @@ void testRestore(TableTestProgram program, ExecNodeMetadata
metadata) throws Exc
tEnv.loadPlan(PlanReference.fromFile(getPlanPath(program,
metadata)));
compiledPlan.execute().await();
for (SinkTestStep sinkTestStep : program.getSetupSinkTestSteps()) {
-
assertThat(TestValuesTableFactory.getRawResultsAsStrings(sinkTestStep.name))
+ // TODO: Fix this. If the records after a restore cause
retractions,
+ // this approach will not work.
+
assertThat(TestValuesTableFactory.getResultsAsStrings(sinkTestStep.name))
Review Comment:
Ok, I made the sinkTestStep configurable. Hopefully that is a reasonable
approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
